Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp814666pxb; Wed, 22 Sep 2021 13:37:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQIGpwZQxSTzNIdsaapJpc25ke9GGl+4fLNiYPWaVscMgzNq2w37ePDUQoTAdU3Bwu5K0L X-Received: by 2002:a5d:8612:: with SMTP id f18mr810456iol.66.1632343066980; Wed, 22 Sep 2021 13:37:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632343066; cv=none; d=google.com; s=arc-20160816; b=uPkzeWyqK71dLSl1yUk5k7nwDW/lk9Zj97NEsT0293gQJHHC/ej/9GtCr3qW2+mgk3 MjxRDOPZBw/2AxL6KlTwSTeT0HAmAEPpHkspNOLoLje47CtEILHVeE9rqfnlpS27b34l Kxp0b5m84sHTDqPice2tUnQDfuI9IG0QVXf7x6mSlr76fZMbA8/zu+qk450d3y+7ZQP3 Gt1Dq2npCyDfUCSaq2YmNCrtI3ay7JT7vVHxucXZzbOIkXfHgAnoE6vcuus/fGloi62w rEzFFksriPnCS2KoJXbYznukoykDLdey8gHg8hPiK1+9vTS1aKPOQyAJ5rKddCosuhGC jBGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=+nWsFySg5KYMWT11M9O6UqMF05HiZPcnD65f5f/E4J8=; b=kWdKMT4g6/7WFiWuW5oRNwrYcqguM49MA7oqxHUG8PHYG1bGDugUY1bmCrvaJFYUbF SalS0n7OuYSwRNjehhywUWS1C5TJ3sWrQcfoxdQMnRJP5OHsuZJS6tLIsEnQSJ8g2iP2 ZazqLssCnf/QSD95CXlO4nT7O3AM5+fiPZullFFCwhoiAXTOuS7iBssbW0iNultsG5QC WiY8L86APj0VLVtYSVAnf7M6O1k1QR9K9Z7XLy+SChRK+ff51QaVmbsQXRKIqjN9fWGs Agoeb5U/7kqeLpEv8bhRKpmDnPTNI7pfwEdTjNWB693t7zZkuCngRqo1Pxz1ShQyZDI+ f6RA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UYJpJfe8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q8si3353604iog.32.2021.09.22.13.37.11; Wed, 22 Sep 2021 13:37:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UYJpJfe8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237661AbhIVUhi (ORCPT + 99 others); Wed, 22 Sep 2021 16:37:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:45290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236860AbhIVUhi (ORCPT ); Wed, 22 Sep 2021 16:37:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7B8B260FC1; Wed, 22 Sep 2021 20:36:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632342967; bh=C+ju3SHP5Uenov8Y+HFErFOymkbRCzcFMjsRizW1tuo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=UYJpJfe8LoqYQafTaViwHocFDGKv9jOi4IAv7hs7ev2QdVGQPtOPvfQ1Qw9NTOxVp 83w+r3ic455kujmPS5fBxIOIHbTRNtV8PtLsi3gTbEM6Ft0KzUedwPGqFhoMx4+IHI 3Hy73EnahX+p9RZKs9CnC3yfjHzFQTEuMELUZJpT/T7khIiIfoayfdAvUR8TbKc7DU bXXoLQJevnvYol1GSNc55oZCnXCSTLnRJqHTye7WXLb4BNKV8p+uegADCzPKSFFgCx HW7DKz4JJMOCeDIdVBWzdSsLLDAgGe/V1dx/YcOSFeEQR9ekOAR0pQdjIy07tKhHO0 tUW0THZ+E1dMQ== Received: by mail-qk1-f182.google.com with SMTP id 194so14043661qkj.11; Wed, 22 Sep 2021 13:36:07 -0700 (PDT) X-Gm-Message-State: AOAM530oIuduZ4Lew46TLc6n0krwRpLxq8wCP/2Bg2q0cbD3+z4cYd3h 4wPA8LlVKfAxgb957u8bCLbJ5FbY9V3fm4Uqgg== X-Received: by 2002:a05:620a:1911:: with SMTP id bj17mr1295518qkb.202.1632342966710; Wed, 22 Sep 2021 13:36:06 -0700 (PDT) MIME-Version: 1.0 References: <20210916084714.311048-1-zhang.lyra@gmail.com> <20210916084714.311048-3-zhang.lyra@gmail.com> In-Reply-To: From: Rob Herring Date: Wed, 22 Sep 2021 15:35:55 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/4] dt-bindings: clk: sprd: Add bindings for ums512 clock controller To: Chunyan Zhang Cc: Stephen Boyd , linux-clk , DTML , Baolin Wang , Orson Zhai , Chunyan Zhang , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 21, 2021 at 10:33 PM Chunyan Zhang wrote: > > On Mon, 20 Sept 2021 at 20:42, Rob Herring wrote: > > > > On Fri, Sep 17, 2021 at 3:41 AM Chunyan Zhang wrote: > > > > > > On Thu, 16 Sept 2021 at 22:29, Rob Herring wrote: > > > > > > > > On Thu, Sep 16, 2021 at 04:47:12PM +0800, Chunyan Zhang wrote: > > > > > From: Chunyan Zhang > > > > > > > > > > Add a new bindings to describe ums512 clock compatible strings. > > > > > > > > > > Signed-off-by: Chunyan Zhang > > > > > --- > > > > > .../bindings/clock/sprd,ums512-clk.yaml | 106 ++++++++++++++++++ > > > > > 1 file changed, 106 insertions(+) > > > > > create mode 100644 Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml b/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml > > > > > new file mode 100644 > > > > > index 000000000000..be3c37180279 > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml > > > > > @@ -0,0 +1,106 @@ > > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > > +# Copyright 2019-2021 Unisoc Inc. > > > > > +%YAML 1.2 > > > > > +--- > > > > > +$id: "http://devicetree.org/schemas/clock/sprd,ums512-clk.yaml#" > > > > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > > > > + > > > > > +title: UMS512 Clock Control Unit Device Tree Bindings > > > > > + > > > > > +maintainers: > > > > > + - Orson Zhai > > > > > + - Baolin Wang > > > > > + - Chunyan Zhang > > > > > + > > > > > +properties: > > > > > + "#clock-cells": > > > > > + const: 1 > > > > > + > > > > > + compatible: > > > > > + enum: > > > > > + - sprd,ums512-apahb-gate > > > > > + - sprd,ums512-ap-clk > > > > > + - sprd,ums512-aonapb-clk > > > > > + - sprd,ums512-pmu-gate > > > > > + - sprd,ums512-g0-pll > > > > > + - sprd,ums512-g2-pll > > > > > + - sprd,ums512-g3-pll > > > > > + - sprd,ums512-gc-pll > > > > > + - sprd,ums512-aon-gate > > > > > + - sprd,ums512-audcpapb-gate > > > > > + - sprd,ums512-audcpahb-gate > > > > > + - sprd,ums512-gpu-clk > > > > > + - sprd,ums512-mm-clk > > > > > + - sprd,ums512-mm-gate-clk > > > > > + - sprd,ums512-apapb-gate > > > > > + > > > > > + clocks: > > > > > + minItems: 1 > > > > > + maxItems: 4 > > > > > + description: | > > > > > + The input parent clock(s) phandle for this clock, only list fixed > > > > > + clocks which are declared in devicetree. > > > > > + > > > > > + clock-names: > > > > > + minItems: 1 > > > > > + maxItems: 4 > > > > > + items: > > > > > + - const: ext-26m > > > > > + - const: ext-32k > > > > > + - const: ext-4m > > > > > + - const: rco-100m > > > > > + > > > > > + reg: > > > > > + maxItems: 1 > > > > > + > > > > > +required: > > > > > + - compatible > > > > > + - '#clock-cells' > > > > > + > > > > > +if: > > > > > + properties: > > > > > + compatible: > > > > > + enum: > > > > > + - sprd,ums512-ap-clk > > > > > + - sprd,ums512-aonapb-clk > > > > > + - sprd,ums512-mm-clk > > > > > +then: > > > > > + required: > > > > > + - reg > > > > > + > > > > > +else: > > > > > + description: | > > > > > + Other UMS512 clock nodes should be the child of a syscon node in > > > > > + which compatible string should be: > > > > > + "sprd,ums512-glbregs", "syscon", "simple-mfd" > > > > > + > > > > > + The 'reg' property for the clock node is also required if there is a sub > > > > > + range of registers for the clocks. > > > > > > > > In which cases is this not true? > > > > > > Seems not needed, I will remove 'reg' property for this kind of cases. > > > > Wrong direction. Please keep 'reg'. My question is why can't you > > always have it? That is the preference. > > Ok. I will address. BTW, do we need 'reg' even though the driver > doesn't read this property? Does that because DT should reflect > hardware topology? Yes and yes. Rob