Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964975AbWLOBhm (ORCPT ); Thu, 14 Dec 2006 20:37:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965000AbWLOBhZ (ORCPT ); Thu, 14 Dec 2006 20:37:25 -0500 Received: from 216-99-217-87.dsl.aracnet.com ([216.99.217.87]:46252 "EHLO sous-sol.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964996AbWLOBgp (ORCPT ); Thu, 14 Dec 2006 20:36:45 -0500 Message-Id: <20061215013738.383192000@sous-sol.org> References: <20061215013337.823935000@sous-sol.org> User-Agent: quilt/0.45-1 Date: Thu, 14 Dec 2006 17:33:53 -0800 From: Chris Wright To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk, v4l-dvb maintainer list , Adrian Bunk Subject: [patch 16/24] DVB: lgdt330x: fix signal / lock status detection bug Content-Disposition: inline; filename=dvb-lgdt330x-fix-signal-lock-status-detection-bug.patch Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1774 Lines: 52 2.6.18-stable review patch. If anyone has any objections, please let us know. ------------------ From: Michael Krufky In some cases when using VSB, the AGC status register has been known to falsely report "no signal" when in fact there is a carrier lock. The datasheet labels these status flags as QAM only, yet the lgdt330x module is using these flags for both QAM and VSB. This patch allows for the carrier recovery lock status register to be tested, even if the agc signal status register falsely reports no signal. Thanks to jcrews from #linuxtv in irc, for initially reporting this bug. Signed-off-by: Michael Krufky Signed-off-by: Chris Wright --- drivers/media/dvb/frontends/lgdt330x.c | 6 ------ 1 file changed, 6 deletions(-) --- linux-2.6.18.5.orig/drivers/media/dvb/frontends/lgdt330x.c +++ linux-2.6.18.5/drivers/media/dvb/frontends/lgdt330x.c @@ -435,9 +435,6 @@ static int lgdt3302_read_status(struct d /* Test signal does not exist flag */ /* as well as the AGC lock flag. */ *status |= FE_HAS_SIGNAL; - } else { - /* Without a signal all other status bits are meaningless */ - return 0; } /* @@ -500,9 +497,6 @@ static int lgdt3303_read_status(struct d /* Test input signal does not exist flag */ /* as well as the AGC lock flag. */ *status |= FE_HAS_SIGNAL; - } else { - /* Without a signal all other status bits are meaningless */ - return 0; } /* Carrier Recovery Lock Status Register */ -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/