Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 22 Sep 2021 15:53:27 -0500
From:   Rob Herring <robh@kernel.org>
To:     Shawn Guo <shawn.guo@linaro.org>
Cc:     Stephen Boyd <sboyd@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Loic Poulain <loic.poulain@linaro.org>,
        devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] clk: qcom: Add Global Clock Controller driver for
 QCM2290
Message-ID: <YUuXxzGnc9iU/eYN@robh.at.kernel.org>
References: <20210919023308.24498-1-shawn.guo@linaro.org>
 <20210919023308.24498-3-shawn.guo@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210919023308.24498-3-shawn.guo@linaro.org>
Precedence: bulk

On Sun, Sep 19, 2021 at 10:33:08AM +0800, Shawn Guo wrote:
> Add Global Clock Controller (GCC) driver for QCM2290.  This is a porting
> of gcc-scuba driver from CAF msm-4.19, with GDSC support added on top.
> 
> Because the alpha_pll on the platform has a different register
> layout (offsets), its own clk_alpha_pll_regs_offset[] is used in the
> driver.
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
>  drivers/clk/qcom/Kconfig                     |    7 +
>  drivers/clk/qcom/Makefile                    |    1 +
>  drivers/clk/qcom/gcc-qcm2290.c               | 3047 ++++++++++++++++++
>  include/dt-bindings/clock/qcom,gcc-qcm2290.h |  188 ++

Really this should be in the binding patch.

Acked-by: Rob Herring <robh@kernel.org>

>  4 files changed, 3243 insertions(+)
>  create mode 100644 drivers/clk/qcom/gcc-qcm2290.c
>  create mode 100644 include/dt-bindings/clock/qcom,gcc-qcm2290.h