Received: by 2002:a05:6520:4d:b0:139:a872:a4c9 with SMTP id i13csp758971lkm; Wed, 22 Sep 2021 14:17:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznIpnQBRswXPWDhV7v/x0pVlsjUhMii3HCvnuS6vUUUYZ1/7l/M3RpoboGmBDxB1fwZrzB X-Received: by 2002:a5d:93cf:: with SMTP id j15mr894735ioo.113.1632345471961; Wed, 22 Sep 2021 14:17:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632345471; cv=none; d=google.com; s=arc-20160816; b=g1gA2mQs1P47O/f3dG9Qvb9I61UqgckgWVj8ynA9LVsmeMmxq1vKgC4oe9YqQlbfLe tXbc2CqT/l7i8yTIMLN/7NzysW8wQE3U9yGh4ZzY7eqZxT4kiH6CL4AhtUX5vy4EUhW2 K5WK+VuUasFzOkPDNg50uGtGQfQ0ZnhwjD//lKtsFst26AKj79HvgqX0QGie/7zwLE3N pl1J0N7D2EhAvVpwTjx2rOOeOeNPJ3svXWI8EbW6szNexQEcyrBMpjyC1JApcWwSkAqn ZQOgiYgRBKXCAXSd/QelQih+VkqcOxMTELQ09YRQVxvtA6g6bkAxxXL3brJMa46OwgY7 hf2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=KuBBpq+e0QqSN9QC/zErEPIwp9Kp3C4stzow3Smk9No=; b=NpEW+GnTIZHvus/cdKh5lviPMzBarDqblCs+KYQsySqzKUW9Zp12Q3EqnHKjNUQ26Y rQ+H4NC+zozY17XYRQobZAkLT5hCsyp1IB4mjca2iO2G+NMJJISCMeyDyczJpB+WsyVp GYJaD7Rwane0Y0mfCvGNYYu8HNhZ7cBzJnV27/LQEDGGYpKIX7k3vK6HaInPzRsKEerC 7sZdtJZQHSmbaGpHj6yYvwTh8hSUprPCInqfhRfBRMCM1X4Hvn0KC34bTJwxjHQILT3+ o1lsqkSk4yISWJbYnrnWfH5jw1I1Y3V+7GwQd3ikSyvc2tGtZvZT8CvtI96iZIeCpehE aMbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bwUiztR0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u7si3810723ill.88.2021.09.22.14.17.40; Wed, 22 Sep 2021 14:17:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bwUiztR0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237936AbhIVVQd (ORCPT + 99 others); Wed, 22 Sep 2021 17:16:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:38744 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237820AbhIVVQc (ORCPT ); Wed, 22 Sep 2021 17:16:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 02B97611CA; Wed, 22 Sep 2021 21:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632345302; bh=p2kf8f9SneDcF5cbddfOin1pAOfAoaUXJFS9kC9C3RY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bwUiztR0HsputfFsZxeMu/pQezk4drxXmTvr/3WfsPockfj60nlyScjJ9nWdo5z1I Rs+ykRZIXW9MoO/wTLJuREfe7sf/57xjJBXRYUM7GjGF2dS4pXH6hAMkSG/IkTDHt9 61QGdTTnMkyhP6XAAKkdxKmAInAkQN1LQjiTNZZsQqYIgY9WcHl5UtzE+de1Z8p+dU lmYlvXp7oFXZlHU40/jmzV1S+gfW8Oz/AUahWoCsB0g3nVyakT061ujLlZzCRRyKY/ zrxcIB7fhsQdmSYAG66gt/AeiRp44y0ARk08r5j+3ykpqQoHZojKdPhYNW1RnXZQt2 FgCQpgZQm4Z5g== Received: by mail-ed1-f53.google.com with SMTP id eg28so15351880edb.1; Wed, 22 Sep 2021 14:15:01 -0700 (PDT) X-Gm-Message-State: AOAM532hE1AqSrRPwTMmAMKfjpdHH4hagCmjk1I8fMl2o1sk1ej5/9PC Xt4SxV3eFJhB84B7tMJngDUjrhPzz50/j5yFQw== X-Received: by 2002:a17:906:7145:: with SMTP id z5mr1367273ejj.363.1632345300554; Wed, 22 Sep 2021 14:15:00 -0700 (PDT) MIME-Version: 1.0 References: <20210922205458.358517-1-maz@kernel.org> <20210922205458.358517-5-maz@kernel.org> <86507f22-d824-4f7c-ba94-d3105c5206c2@www.fastmail.com> In-Reply-To: <86507f22-d824-4f7c-ba94-d3105c5206c2@www.fastmail.com> From: Rob Herring Date: Wed, 22 Sep 2021 16:14:49 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 04/10] PCI: apple: Add initial hardware bring-up To: Sven Peter Cc: Marc Zyngier , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , PCI , Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Alyssa Rosenzweig , Stan Skowronek , Mark Kettenis , Hector Martin , Robin Murphy , Android Kernel Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 22, 2021 at 4:08 PM Sven Peter wrote: > > Hi, > > > On Wed, Sep 22, 2021, at 22:54, Marc Zyngier wrote: > > From: Alyssa Rosenzweig > > > [...] > > + > > + /* Use the first reg entry to work out the port index */ > > + port->idx = idx >> 11; > > + port->pcie = pcie; > > + port->np = np; > > + > > + port->base = devm_platform_ioremap_resource(platform, port->idx + 2); > > + if (IS_ERR(port->base)) > > + return -ENODEV; Don't change error codes. > > + > > + rmw_set(PORT_APPCLK_EN, port + PORT_APPCLK); > > I think this should be > > rmw_set(PORT_APPCLK_EN, port->base + PORT_APPCLK); Or just removed if this was tested and worked. Rob