Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp82646pxb; Wed, 22 Sep 2021 16:35:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUXDMuypHCCHUCYUpvFKOSAAn1AztWr9blbdy5BQlYx2vv4CYO4zTAvU4ZkahXhUeg3z7t X-Received: by 2002:a05:6402:5250:: with SMTP id t16mr2172024edd.227.1632353726857; Wed, 22 Sep 2021 16:35:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632353726; cv=none; d=google.com; s=arc-20160816; b=GxHuYOpZNkXeP7bQ8aRA28T3sxFapXyC6klboylzB9CrEcY8EivB6YZd0vNaBRdGCn xfwXazt2S0scu4+16pWKAq0ivZf7k3CO3Tmu61f9tyy5SNJGakFkm8W8rybtk+8OqiMe i0jVab4N7HXlEB7Vm3fjujq5dCIMCt3oy2ZDjG0vZPDFHu0kY54sIStG26QcZnc/m1Xo knjvAu4jvtoYKE+lUIcV0XtUINCTNH7LXP2Yo93HyxN+J93OM3rB/tOaBpXOlZBClBoS E3KmB0g5OCb6u8z91DLLUMJduz9hgJ85h1YPtTctKzuC62/QyawE9mnjmjvbmDGNsuZ/ knhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:references:subject:in-reply-to:cc:to :from:date; bh=mzI1wOesZ5tCApjLAcLNkoezhqGQonJL1Os8KVXvBak=; b=1Jq00hT/gxPOwPdRU+BiT7wixOZa0saIlxFdHOCLmdwaUy0EfQd0mXDbjSpymqLuSZ ZqIYax1QfiNVAmmOnLPRnXPJpLtDHr4ahTYuaX+r84HdjGaOxtrAe6Y9cwwfOEPP0FFz v2PZxKYGPrc/EesI/3lMiSOSWLbI1DVd4ckIPkboGuuXiFm2psuc/YIJk4KvWnWUiV3c tnHKMmypkVestHG+R11UA4Lwf/wEbmzCWW/BMXoN+/PLw6yKIJ7d/8yGNVm7j1k6gGUD LV/T6kF4WruLrJPTehE8miRPldH7qw0O2XqQj/1qXmpox5ORt9M0A0t++P3GWTuvOm/c 0ysw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xs4all.nl Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s15si2984497edt.213.2021.09.22.16.35.03; Wed, 22 Sep 2021 16:35:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xs4all.nl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238484AbhIVXeT (ORCPT + 99 others); Wed, 22 Sep 2021 19:34:19 -0400 Received: from sibelius.xs4all.nl ([83.163.83.176]:56277 "EHLO sibelius.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238480AbhIVXeS (ORCPT ); Wed, 22 Sep 2021 19:34:18 -0400 Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id f6097b85; Thu, 23 Sep 2021 01:32:45 +0200 (CEST) Date: Thu, 23 Sep 2021 01:32:45 +0200 (CEST) From: Mark Kettenis To: Marc Zyngier Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, bhelgaas@google.com, robh+dt@kernel.org, lorenzo.pieralisi@arm.com, kw@linux.com, alyssa@rosenzweig.io, stan@corellium.com, kettenis@openbsd.org, sven@svenpeter.dev, marcan@marcan.st, Robin.Murphy@arm.com, kernel-team@android.com In-Reply-To: <20210922205458.358517-1-maz@kernel.org> (message from Marc Zyngier on Wed, 22 Sep 2021 21:54:48 +0100) Subject: Re: [PATCH v4 00/10] PCI: Add support for Apple M1 References: <20210922205458.358517-1-maz@kernel.org> Message-ID: <56147a3cb0fae762@bloch.sibelius.xs4all.nl> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Marc Zyngier > Date: Wed, 22 Sep 2021 21:54:48 +0100 > > This is v4 of the series adding PCIe support for the M1 SoC. Not a lot > has changed this time around, and most of what I was saying in [1] is > still valid. > > The most important change is that the driver now probes for the number > of RID-SID mapping registers instead of assuming 64 entries. The rest > is a bunch of limited cleanups and minor fixes. > > This should now be in a state that makes it mergeable, although I > expect that some of the clock bits may have to be adapted (I haven't > followed the recent developments on that front). The current understanding is that the M1 SoC really only has power domains. Fortunately power domains are handled automagically by the Linux kernel (and U-Boot) so this driver doesn't have to worry about this. I already changed the 4/4 diff of my DT bindings series to add a "power-domains" property instead of a "clocks" property. So once marcan's power manager driver lands everything should just work. Some coordination on the patch that changes the DT itself is probably required. But we could simply leave out the "power-domains" property until the power manager driver lands as m1n1 currently already turns on the power domain. Cheers, Mark > As always, comments welcome. > > [1] https://lore.kernel.org/r/20210913182550.264165-1-maz@kernel.org > > Alyssa Rosenzweig (2): > PCI: apple: Add initial hardware bring-up > PCI: apple: Set up reference clocks when probing > > Marc Zyngier (8): > irqdomain: Make of_phandle_args_to_fwspec generally available > of/irq: Allow matching of an interrupt-map local to an interrupt > controller > PCI: of: Allow matching of an interrupt-map local to a PCI device > PCI: apple: Add INTx and per-port interrupt support > arm64: apple: t8103: Add root port interrupt routing > PCI: apple: Implement MSI support > iommu/dart: Exclude MSI doorbell from PCIe device IOVA range > PCI: apple: Configure RID to SID mapper on device addition > > MAINTAINERS | 7 + > arch/arm64/boot/dts/apple/t8103.dtsi | 33 +- > drivers/iommu/apple-dart.c | 27 + > drivers/of/irq.c | 17 +- > drivers/pci/controller/Kconfig | 17 + > drivers/pci/controller/Makefile | 1 + > drivers/pci/controller/pcie-apple.c | 826 +++++++++++++++++++++++++++ > drivers/pci/of.c | 10 +- > include/linux/irqdomain.h | 4 + > kernel/irq/irqdomain.c | 6 +- > 10 files changed, 935 insertions(+), 13 deletions(-) > create mode 100644 drivers/pci/controller/pcie-apple.c > > -- > 2.30.2 > >