Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "allan.nielsen@microchip.com" <allan.nielsen@microchip.com>,
        "joergen.andreasen@microchip.com" <joergen.andreasen@microchip.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "vinicius.gomes@intel.com" <vinicius.gomes@intel.com>,
        "michael.chan@broadcom.com" <michael.chan@broadcom.com>,
        "vishal@chelsio.com" <vishal@chelsio.com>,
        "saeedm@mellanox.com" <saeedm@mellanox.com>,
        "jiri@mellanox.com" <jiri@mellanox.com>,
        "idosch@mellanox.com" <idosch@mellanox.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "kuba@kernel.org" <kuba@kernel.org>, Po Liu <po.liu@nxp.com>,
        Leo Li <leoyang.li@nxp.com>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: RE: [PATCH v4 net-next 7/8] net: mscc: ocelot: use index to set vcap
 policer
Thread-Topic: [PATCH v4 net-next 7/8] net: mscc: ocelot: use index to set vcap
 policer
Thread-Index: AQHXr56IVK6JKlDdYkKzYzpAt9AcBauwCXaAgADDz0A=
Date:   Thu, 23 Sep 2021 01:52:38 +0000
Message-ID: <DB8PR04MB578599F04A8764034485CE89F0A39@DB8PR04MB5785.eurprd04.prod.outlook.com>
References: <20210922105202.12134-1-xiaoliang.yang_1@nxp.com>
 <20210922105202.12134-8-xiaoliang.yang_1@nxp.com>
 <20210922131837.ocuk34z3njf5k3yp@skbuf>
In-Reply-To: <20210922131837.ocuk34z3njf5k3yp@skbuf>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TD4w9mW2wHqIREgrfpXxDufmr+aES2U69YOLU23mInDMWkBCUg170AQli/8U?=
 =?us-ascii?Q?HRoV5rNKV1rjYRnYoW9bWPp7J9V3PUt9bc+BkggR+FLjb+ShYAXhbEV9Fd9O?=
 =?us-ascii?Q?DkNiTsm8H2BzowzQTXfQqFIlGksl3avdSFOkW2wFbcU4eIW1nPZKJUzoUi8F?=
 =?us-ascii?Q?Go4+R9KFeLFzWqOqb3GSsQhL036Lg4aF8WL1Co0ccNhwjryV+GB3EMpL8okT?=
 =?us-ascii?Q?8+D1xWDb9w0AKwL2WFeYt2RQR3H3v5+UeNYnsQtIiLOK33e7UrhePXHQV+l/?=
 =?us-ascii?Q?esjTySZa9xxis6xBc6gwFQrk7H/7QwuPapf/c9CObf7rwbEhCwiskc//GIbH?=
 =?us-ascii?Q?HSwjqnmeJclsDAaCGbjvIVUyGe1Te0MGSertfihLY3f1Xa5/J0behSd2tfYi?=
 =?us-ascii?Q?PdAUA/YQBYeDGNQlp88dN2yaImVCKtU3fuGX/tfwQ6cB+EPvB9aU/COeC2mq?=
 =?us-ascii?Q?KA1a1NLBP0Lf517BIyXSnWhyAooQiGivpNXLeSA/EwQIWfYxho1ty5wcy/vR?=
 =?us-ascii?Q?gLM6c6jcrZ/cCIy8TXsmVl+4h+1w8IcIa05kywBiZHPkiXHPljcjI4ZjHDhc?=
 =?us-ascii?Q?DDtPijvj7wH7lQdz07HW66Fiy5imuXCMCcljbmI7ry7y1vZiX3yylOR8FYJP?=
 =?us-ascii?Q?vbkXJp+UYBFH+xB5eemiBuEaDgk5sRL8M5Fym9rwjGPTtxWnHfXrVTxODVGY?=
 =?us-ascii?Q?tUWKiQgFWGXb+KD+srFcqzkv2+7uXHutEX3tA+LEYDxx/GKCFnDs7UYhD8Jz?=
 =?us-ascii?Q?HsthZAaqmYOJgwJlz6R38JowfkNJUZYBblRXEDv64Lfh0YjrzokrGFq4iYRx?=
 =?us-ascii?Q?z+LuNNrpv7S7b7J354eh41f7AtCdlLDrgmcP4UrWg9WM7C9YijH/tlXfD/Ah?=
 =?us-ascii?Q?N0pM85BDERpBESFwC7V3rJF6bFR0PsWxxUvJb5kPO7qWlhW0rsBrMkIW53C2?=
 =?us-ascii?Q?GCzpRiBkWrp0mh5dVehqaDxrQ2q/SyLPlzxl2bwmkr6ptmreXX0tn27WRZoK?=
 =?us-ascii?Q?mWordM5XgXEIJOuQZD25Sv0DMnyVdNYgN0JanWAgvpnuwRz3weVhqMitc7jM?=
 =?us-ascii?Q?BT0PZWMM39ZOTLr0QAR3/P5UMy674gHV+PD7ze9JnZi7a+9GYuTdV/FdufWm?=
 =?us-ascii?Q?lnQBc3MJVojoMkK/75NBg9bvTAHapZczui65frWyJZDPoDUeLoXgKMUHrJKW?=
 =?us-ascii?Q?PcMHDreZFf6NhtyH0/8sFzok6p5vvn3OjN//2jia/RfAjYlaN0R+xXU1Lzur?=
 =?us-ascii?Q?mSOUpPr4XuvO1KdqrUIQBjC/XxXs75CHvRjXcL8SKDXSo/Ctt/LX68SkOuBr?=
 =?us-ascii?Q?WyQsJq5q5U0H4lxdL/wd1q15?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB5785.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f16d1d9b-6de2-467c-6772-08d97e34d2dd
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2021 01:52:38.9920
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tXOSua45trbmOZ6kiIx1J4W1R7Ecq+cSad2gN/pkdu/DB3lKPkIZBGM0lLwbwTNK6MzS5BJHI2bxIXYIytE60cSwyrRxtnXhGWp66PrID/c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4954
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Wed, Sep 22, 2021 at 13:18:37 +0000, Vladimir Oltean wrote:
> > Policer was previously automatically assigned from the highest index
> > to the lowest index from policer pool. But police action of tc flower
> > now uses index to set an police entry. This patch uses the police
> > index to set vcap policers, so that one policer can be shared by multip=
le
> rules.
> >
> > Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
> > ---
> > +#define VSC9959_VCAP_POLICER_BASE	63
> > +#define VSC9959_VCAP_POLICER_MAX	383
> >
>=20
> > +#define VSC7514_VCAP_POLICER_BASE			128
> > +#define VSC7514_VCAP_POLICER_MAX			191
>=20
> I think this deserves an explanation.
>=20
> The VSC7514 driver uses the max number of policers as 383 (0x17f) ever si=
nce
> commit b596229448dd ("net: mscc: ocelot: Add support for tcam"), aka the
> very beginning.
>=20
> Yet, the documentation at "3.10.1 Policer Allocation"
> https://ww1.microchip.com/downloads/en/DeviceDoc/VMDS-10491.pdf
> says very clearly that there are only 192 policers indeed.
>=20
> What's going on?

In commit commit b596229448dd ("net: mscc: ocelot: Add support for tcam"), =
Horatiu Vultur define the max number of policers as 383:
+#define OCELOT_POLICER_DISCARD 0x17f
VCAP IS2 use this policer to set drop action. I did not change this and set=
 the VCAP policers with 128-191 according to the VSC7514 document.

I don't know why 383 was used as the maximum value of policer in the origin=
al code. Can Microchip people check the code or the documentation for error=
s?

>=20
> Also, FWIW, Seville has this policer allocation:
>=20
>       0 ----+----------------------+
>             |  Port Policers (11)  |
>      11 ----+----------------------+
>             |  VCAP Policers (21)  |
>      32 ----+----------------------+
>             |   QoS Policers (88)  |
>     120 ----+----------------------+
>             |  VCAP Policers (43)  |
>     162 ----+----------------------+

I didn't find Seville's document, if this allocation is right, I will add i=
t in Seville driver.

Thanks,
Xiaoliang