Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp312839pxb; Wed, 22 Sep 2021 23:59:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOIPyWDgRnDgL4aMwMcGc5NAf+LiWC9hAWUqDLIChUWVbalkYyljNekSVgbD+ngxFmBlJN X-Received: by 2002:a17:906:1341:: with SMTP id x1mr3350223ejb.277.1632380391098; Wed, 22 Sep 2021 23:59:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632380391; cv=none; d=google.com; s=arc-20160816; b=AK4l34HdveNmU87gvm59YlX5teAZZfaHPgXUOk9ARk2SrglOfFwzQbRe35oVCIrrz3 h4ACambda+jwKrHoWh5nmQXtNOzzpnW7Z1PycQcOCgJFZ79oJuUBxUlYBMXVHMdzmK+o 2DzyGGto+KVXNkOoako5kC1X6qSxhpPC3H1FLdrQqoG1yW320BT41TW7pX7K3zYFMm6f /N6I1gSR31GK1sO6J7heg7nZ+Di/egXHx/79jree7XNNd/jWWELcksfQS+HKx9WSo1V7 Pkqedz178glqZX0Lv3uNrWmelfH4NLj82aQIUprmLjL252TnRll5Mbjn6orca9gftfZ+ crnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Fc6vpP8FqBbPsZnX7OmEY0kYGdml5Q/LdtxFp8UW6Ac=; b=glBiaA60OFdLXqkW3PrzKARLkP+PavQdR2ucdT8HE2Nh+WxZOm2SBFUMMB8WtpDJTU XjGu5fYy/c7yXXNK/GCXwFVO7OeO9bLpbLXxK44dKxHunloajxcEyNO4ZUJOUhHlJ/6t x27aDVmlRM0tBRg+UpmC1o1uzJ+jGWArkI13kjEduVvS0mJoqFOd7T6j5T/upk485eS5 qBEFu0IAPVKrHgtF1vQX9ioEaEgceHamDpuubhKk2Rb6r7wNToi6jsrGK8RQN2qOQfBk EuvOhmC8UvhszoQGBZe8ty7qYrptZ9lffFnorGdCTjYWjCguWw7bljdaNIy4CZlUHWy/ fvmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@0x0f.com header.s=google header.b="k4kPsG/g"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y21si4697369ejk.714.2021.09.22.23.59.27; Wed, 22 Sep 2021 23:59:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@0x0f.com header.s=google header.b="k4kPsG/g"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239562AbhIWG5X (ORCPT + 99 others); Thu, 23 Sep 2021 02:57:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239511AbhIWG5U (ORCPT ); Thu, 23 Sep 2021 02:57:20 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 972CFC061760 for ; Wed, 22 Sep 2021 23:55:49 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id 5so3396144plo.5 for ; Wed, 22 Sep 2021 23:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0x0f.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fc6vpP8FqBbPsZnX7OmEY0kYGdml5Q/LdtxFp8UW6Ac=; b=k4kPsG/gzpz0nKhfed6jf7oj6OLIDRzx9VS9pDWpBfMNIXsdU5W8izdzvmJa4A9wSN t/Pp5QQI5LEaHKUNKzWSLUa0jgZMmgbcxMHFGGt9YtU7oFi7ej0V55PYvbLugq7JxwuE 1Gde75a8XNLesRG6yfx/WV0/Hrf3kU5wLZT7w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fc6vpP8FqBbPsZnX7OmEY0kYGdml5Q/LdtxFp8UW6Ac=; b=qCGz05oGIU6NQli8U9SkGa/K6MPbFY9iZ2hQEIPxr7x0HMZY6u9ZNsjAd8dXJsSRSL dsg/iXCwJFJ2iEsGOs8jY8FMIehqHhjn7qPIoHs6pM9WfgIx3SeTGtOAJhn4Mq6Hu5+A /p+EWU0SPz2f3XkkdlPwW1uYIdU79QQ2TOgDpVNfxsWy12sET4yPTXCK95sFm2y7+mfQ aHLVBp/SvxL6jD1O3GYgcnQU1kOUWX7CfDZ2uj9sCBSWtNf/6XrFXjiNrhY6TiUEAAlo hlYKCUoIO25HTY/XDPjI3B2J8Gs4VR0scfrCWsF2WivLkEupSDDlOFp3CPk5813MeUfn IdeQ== X-Gm-Message-State: AOAM533sLjOPvLjskA3KxNUu828WMWEN6FG2cygXnkcS4IuO1mujVWyr Kea8fkikzh38Zy8kinFSiZnYEQ== X-Received: by 2002:a17:90b:1987:: with SMTP id mv7mr3584296pjb.91.1632380149208; Wed, 22 Sep 2021 23:55:49 -0700 (PDT) Received: from shiro.work ([2400:4162:2428:2f01:7285:c2ff:fe8e:66d7]) by smtp.googlemail.com with ESMTPSA id e12sm1581888pgv.82.2021.09.22.23.55.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Sep 2021 23:55:48 -0700 (PDT) From: Daniel Palmer To: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-leds@vger.kernel.org Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, robh+dt@kernel.org, pavel@ucw.cz, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Palmer Subject: [PATCH v2 04/11] gpio: msc313: Code clean ups Date: Thu, 23 Sep 2021 15:54:53 +0900 Message-Id: <20210923065500.2284347-5-daniel@0x0f.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210923065500.2284347-1-daniel@0x0f.com> References: <20210923065500.2284347-1-daniel@0x0f.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org - Remove the unneeded assignment of ret before returning it. - Remove an unneeded blank line Signed-off-by: Daniel Palmer Reviewed-by: Linus Walleij --- drivers/gpio/gpio-msc313.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-msc313.c b/drivers/gpio/gpio-msc313.c index da31a5ff7a2b..a894bafbd4c3 100644 --- a/drivers/gpio/gpio-msc313.c +++ b/drivers/gpio/gpio-msc313.c @@ -344,7 +344,6 @@ static int msc313_gpio_probe(struct platform_device *pdev) struct irq_domain *parent_domain; struct device_node *parent_node; struct device *dev = &pdev->dev; - int ret; match_data = of_device_get_match_data(dev); if (!match_data) @@ -399,8 +398,7 @@ static int msc313_gpio_probe(struct platform_device *pdev) gpioirqchip->handler = handle_bad_irq; gpioirqchip->default_type = IRQ_TYPE_NONE; - ret = devm_gpiochip_add_data(dev, gpiochip, gpio); - return ret; + return devm_gpiochip_add_data(dev, gpiochip, gpio); } static int msc313_gpio_remove(struct platform_device *pdev) @@ -456,5 +454,4 @@ static struct platform_driver msc313_gpio_driver = { .probe = msc313_gpio_probe, .remove = msc313_gpio_remove, }; - builtin_platform_driver(msc313_gpio_driver); -- 2.33.0