Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 1/2] xen-pciback: prepare for the split for stub and PV
To:     Oleksandr Andrushchenko <andr2000@gmail.com>
Cc:     boris.ostrovsky@oracle.com, jgross@suse.com, julien@xen.org,
        sstabellini@kernel.org,
        Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
References: <20210923095345.185489-1-andr2000@gmail.com>
From:   Jan Beulich <jbeulich@suse.com>
Message-ID: <d12b0bcd-e998-d4c5-e673-9c13a864eea4@suse.com>
Date:   Thu, 23 Sep 2021 13:10:50 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210923095345.185489-1-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1FpMVFzRmx1ZjZrMk5aSGFHaXE1cVI1TkFybHkybEhSQ1gvRER5TlFMeDFM?=
 =?utf-8?B?OFNzS3V0dUpYY3A1aURrTnRCRGpCZ3RsREJCN2d4UnM1NXFqTm1Ba3htTTZF?=
 =?utf-8?B?MWh3cThGY21WOW9FRXFtdGM5aFZOQ0V0QUNEU0NwMzVFTVNraDY5MUtpaStS?=
 =?utf-8?B?WmtLSHJJSUUyOW1PYTE2Wm8wa3JCTFlMR3dwRDlNd0tmVWpWTEUzZHVvNHdk?=
 =?utf-8?B?VTRYNmloNUMrMCtkeUJrOFlRYkdLN3NFZFNGMGFzSDByZXkvYmNQeHZjdTlt?=
 =?utf-8?B?WWF6UGlPSmhqVDl0TEZydEs0LzFrMlhzK25UWTdPU1NrQ0ZFZGU2RDh0MzRE?=
 =?utf-8?B?L0REbXNJYVpIK2Rpd2RmcUF5cFJjdXlzV3VMbmRERGswTTlpMTZmYVRlR1VG?=
 =?utf-8?B?TlpuYlI5N3N0TnNkOHc0RXhBRHlJeHBaa1BBMnhPWkRDV3JQcDM1VjNEc0pD?=
 =?utf-8?B?Vk9DMFFLbncwVURiSSsrY3E2NGU5OUlqVUVSdnlpcnN4UHVRb2xlL3ZTYzJF?=
 =?utf-8?B?cmFUTHNaeWZoeUZlbUxRejNCclV5Q0xVYVl0YjVPeFlGaTIxWUpqSnM5ZHlv?=
 =?utf-8?B?R1YvSUhnazdKRWhvL0p6MGw1YnJmWHFnOWV4Z0pSU2pWYS9BZmlTWXdxWDBG?=
 =?utf-8?B?Zm9uSldJQnRKWUlkKzd4TnhRaDhUd3dHWURwSUhrbkFqRlZZTXExdnRtNHhK?=
 =?utf-8?B?NS96SVkyWXQ1R0NoWEd4OTRvcHIxME15QVMrZU1pNjJGZzd6dGJQQS9NNCsv?=
 =?utf-8?B?a0hnYjJoejlWOC9oODlUaHJsUFQwRzhYMXpDdW9FQU9Ed3htejU5bUEwWFFE?=
 =?utf-8?B?UDVkV1RmbXc0MFB0R3NkMC9ETXUyckxuQnFLSzRCUS9vc25rQi93UGp2aWtM?=
 =?utf-8?B?NmJTSFRIcmNEWFVNQk11MGpvZUJ3MmxTWEVkZXdjVGxFMGFHQ3BubDJLVVRp?=
 =?utf-8?B?VFNRV3NHNkdYVEtRcFN6MHVmcm5xWUtDM2dpaEVUZkt1Y0FRQnFxZ3QrZ3gw?=
 =?utf-8?B?T25oMEZKckVwd2thYVV4TmpGS1FVc1FocXlTZ2pKbVNTNWRHYTRPL3Z0c0JE?=
 =?utf-8?B?OXRLZVBlenZPaXRqT1U1VVAvUXROM1FJbFlpY2w4NjJTMkZWaTJ5K0J5R1ZZ?=
 =?utf-8?B?bnptdktESitiSFBySnRUSDIxSHZCZDNnaEJqejRTYkdLWGcvWEVkOHFYa2Vm?=
 =?utf-8?B?bGs4d3FTcTFNYWc4SGw4N1hwM1JOcWFBTlovOGMwYVhKTjNZOUd0b2F0STBq?=
 =?utf-8?B?ZThxTSthVCsyYm5Ic3V4a0NuLzluYzVrTU8valROdFVMNEtPQWJVbkEvc3VQ?=
 =?utf-8?B?RGs0YkN5UHRxaTRrSGNQS1gvMDl3S0tvZXFZM1RHU2xNMlpPSkpsdE9XU3Jr?=
 =?utf-8?B?Nk9vQ0FtbjBPN2lxRjU3cjNwM1g4R2s1UHVMSWVaUU1uWW51T3dFK21rVitV?=
 =?utf-8?B?RWpTTXFzUjRsMys3d285ZGlKYUJPd0t6bEx3OHk0bjR1SXVQRzg1RXRsWWJM?=
 =?utf-8?B?VnByenhPTzAvVGxya3B2KzIxdUlvTTAvV3EzZUFFakQzcHc5NjI0UHVHMWRM?=
 =?utf-8?B?aC9BV1VDSHFLT1F2ZG9pc2VmTXdhK2Q5YUl6a3Z4ZWV3cExWSld5Y2xuZUpZ?=
 =?utf-8?B?V0tDSCtQSzhtYTE1SkZYbysvSk1uTW5MK1cwd28zKzlLTllGeGZGQmRPTG5R?=
 =?utf-8?B?YTVzNmVWZFExM2VOUEFqVFk5RTRQSEsvMVVMaiszcVd1c1ByK01JcDhDUFBK?=
 =?utf-8?Q?UAEjZSWeuc0TZR4mgFM1uV2jwzNGYfUYij+L3GG?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62403514-8f2a-4f56-2a16-08d97e82cdfb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2021 11:10:51.6943
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CyaRxDGeAFY5Oe4Ia2MB52FhyYLYzc1Dk+zU6JaONFxqQaAagLYxLVjkkFbw6cB+XbUPE3SNML+eJEhr63STww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4383
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 23.09.2021 11:53, Oleksandr Andrushchenko wrote:
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -180,10 +180,34 @@ config SWIOTLB_XEN
>  	select DMA_OPS
>  	select SWIOTLB
>  
> +config XEN_PCI_STUB
> +	bool
> +
> +config XEN_PCIDEV_STUB
> +	tristate "Xen PCI-device stub driver"
> +	depends on PCI && !X86 && XEN
> +	depends on XEN_BACKEND
> +	select XEN_PCI_STUB
> +	default m
> +	help
> +	  The PCI device stub driver provides limited version of the PCI
> +	  device backend driver without para-virtualized support for guests.
> +	  If you select this to be a module, you will need to make sure no
> +	  other driver has bound to the device(s) you want to make visible to
> +	  other guests.
> +
> +	  The "hide" parameter (only applicable if backend driver is compiled
> +	  into the kernel) allows you to bind the PCI devices to this module
> +	  from the default device drivers. The argument is the list of PCI BDFs:
> +	  xen-pciback.hide=(03:00.0)(04:00.0)
> +
> +	  If in doubt, say m.
> +
>  config XEN_PCIDEV_BACKEND
>  	tristate "Xen PCI-device backend driver"
>  	depends on PCI && X86 && XEN
>  	depends on XEN_BACKEND
> +	select XEN_PCI_STUB

Does kconfig not at least warn about this? The selected item has a
"depends on !X88" conflicting with the "depends on X86" here.

Jan