Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp504424pxb; Thu, 23 Sep 2021 05:06:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsf+NCFduoLZ6nQ6gcc1+0N5NQSI7bR/Np1M8/WR9cD/UNhpF6n2AhO5z/2lVYU601o3t7 X-Received: by 2002:a05:6402:3454:: with SMTP id l20mr5017169edc.83.1632398772113; Thu, 23 Sep 2021 05:06:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632398772; cv=none; d=google.com; s=arc-20160816; b=nY5Xrf1h45ffahRGM6zewRjzo9slvf0atbSvxQd31bJ0g9o98U4hJYd34Ai4IWi7rc noDZHXhkVMtueISIsbhUXZgRvqqLEShMcaK6PkEfgocGmDhuB5+k/B+RdAXyeh2RLcWT v74Y7GAdScladl+euqIcumc0ZnCfcx4SVyVQDiiFcyimx36tIBm3L3IzGIRjtZwi8heT nbBvx2PJwGQIKKnQozoc+AsuqoDOtN67VfYMEgUMLCUk4dNVA8t16pngW67DM8+nSL/E uZD2zbhg+ro/FujZCIlnj1N7KlFwnRxL0R/L6L1ojCWdIeyqNpHX5wc0yfokTO3+PYed jg0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=+ezdFxogPveYr6Wnpw1vhrZmdSSkIuv0vvytyRUgvsY=; b=C+EZp2mYmagX8Chao7/Nz157tIj/2rf+hjybMxz4o90a8z/SvNp/wjN/vdbyMTMqhu TdbBkBiURCq4LexoBh36TuFDvenYc4wlCyhGga7OOpzfXiudARD36/hTP7ke+PzjKU/r xrq6FkAShyVJHnQGhgtrIJKpKqNyJAGcSZ6fYsZ+dl/sXJMZ/O/d1Za/iSHK1g5nfcMf Ahrznl3xJLO+xh01fQGHf/OFz5zO71lul3lN1jQIyOVLxyK3V0UQ+548Dvqu0KuSSvyB vNg4XCjg350ZUmZWGoGkOWmELc973boCjP7o1w8/LS371ojaRfOpboDKK+QfDTt9RrPd YEbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dz15si1965809edb.601.2021.09.23.05.05.47; Thu, 23 Sep 2021 05:06:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240787AbhIWMFJ (ORCPT + 99 others); Thu, 23 Sep 2021 08:05:09 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:54900 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S240924AbhIWMEq (ORCPT ); Thu, 23 Sep 2021 08:04:46 -0400 X-UUID: a4bf2dc555be4187855d5c79a3e329d9-20210923 X-UUID: a4bf2dc555be4187855d5c79a3e329d9-20210923 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1988298339; Thu, 23 Sep 2021 20:03:11 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 23 Sep 2021 20:03:10 +0800 Received: from localhost.localdomain (10.17.3.154) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 23 Sep 2021 20:03:09 +0800 From: Yong Wu To: Joerg Roedel , Rob Herring , Matthias Brugger , Will Deacon , Robin Murphy CC: Krzysztof Kozlowski , Tomasz Figa , , , , , , , Hsin-Yi Wang , , , , , Subject: [PATCH v3 27/33] iommu/mediatek: Initialise bank HW for each a bank Date: Thu, 23 Sep 2021 19:58:34 +0800 Message-ID: <20210923115840.17813-28-yong.wu@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20210923115840.17813-1-yong.wu@mediatek.com> References: <20210923115840.17813-1-yong.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The mt8195 IOMMU HW max support 5 banks, and regarding the banks' registers, it looks like: ---------------------------------------- |bank0 | bank1 | bank2 | bank3 | bank4| ---------------------------------------- |global | |control| null |regs | ----------------------------------------- |bank |bank |bank |bank |bank | |regs |regs |regs |regs |regs | | | | | | | ----------------------------------------- Each bank has some special bank registers and it share bank0's global control registers. this patch initialise the bank hw with the bankid. In the hw_init, we always initialise bank0's control register since we don't know if the bank0 is initialised. Additionally, About each bank's register base, always delta 0x1000. like bank[x + 1] = bank[x] + 0x1000. Signed-off-by: Yong Wu --- drivers/iommu/mtk_iommu.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index 6ef3eb3cad92..c139675d99e6 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -152,7 +152,7 @@ struct mtk_iommu_domain { static const struct iommu_ops mtk_iommu_ops; -static int mtk_iommu_hw_init(const struct mtk_iommu_data *data); +static int mtk_iommu_hw_init(const struct mtk_iommu_data *data, unsigned int bankid); #define MTK_IOMMU_TLB_ADDR(iova) ({ \ dma_addr_t _addr = iova; \ @@ -520,12 +520,12 @@ static int mtk_iommu_attach_device(struct iommu_domain *domain, dom->bank = bank; } - if (!bank->m4u_dom) { /* Initialize the M4U HW */ + if (!bank->m4u_dom) { /* Initialize the M4U HW for each a BANK */ ret = pm_runtime_resume_and_get(m4udev); if (ret < 0) return ret; - ret = mtk_iommu_hw_init(data); + ret = mtk_iommu_hw_init(data, bankid); if (ret) { pm_runtime_put(m4udev); return ret; @@ -729,11 +729,16 @@ static const struct iommu_ops mtk_iommu_ops = { .owner = THIS_MODULE, }; -static int mtk_iommu_hw_init(const struct mtk_iommu_data *data) +static int mtk_iommu_hw_init(const struct mtk_iommu_data *data, unsigned int bankid) { + const struct mtk_iommu_bank_data *bankx = &data->bank[bankid]; const struct mtk_iommu_bank_data *bank0 = &data->bank[0]; u32 regval; + /* + * Global control settings are in bank0. May re-init these global registers + * since no sure if there is bank0 consumers. + */ if (data->plat_data->m4u_plat == M4U_MT8173) { regval = F_MMU_PREFETCH_RT_REPLACE_MOD | F_MMU_TF_PROT_TO_PROGRAM_ADDR_MT8173; @@ -776,13 +781,14 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data *data) } writel_relaxed(regval, bank0->base + REG_MMU_MISC_CTRL); + /* Independent settings for each bank */ regval = F_L2_MULIT_HIT_EN | F_TABLE_WALK_FAULT_INT_EN | F_PREETCH_FIFO_OVERFLOW_INT_EN | F_MISS_FIFO_OVERFLOW_INT_EN | F_PREFETCH_FIFO_ERR_INT_EN | F_MISS_FIFO_ERR_INT_EN; - writel_relaxed(regval, bank0->base + REG_MMU_INT_CONTROL0); + writel_relaxed(regval, bankx->base + REG_MMU_INT_CONTROL0); regval = F_INT_TRANSLATION_FAULT | F_INT_MAIN_MULTI_HIT_FAULT | @@ -791,19 +797,19 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data *data) F_INT_TLB_MISS_FAULT | F_INT_MISS_TRANSACTION_FIFO_FAULT | F_INT_PRETETCH_TRANSATION_FIFO_FAULT; - writel_relaxed(regval, bank0->base + REG_MMU_INT_MAIN_CONTROL); + writel_relaxed(regval, bankx->base + REG_MMU_INT_MAIN_CONTROL); if (MTK_IOMMU_HAS_FLAG(data->plat_data, HAS_LEGACY_IVRP_PADDR)) regval = (data->protect_base >> 1) | (data->enable_4GB << 31); else regval = lower_32_bits(data->protect_base) | upper_32_bits(data->protect_base); - writel_relaxed(regval, bank0->base + REG_MMU_IVRP_PADDR); + writel_relaxed(regval, bankx->base + REG_MMU_IVRP_PADDR); - if (devm_request_irq(bank0->pdev, bank0->irq, mtk_iommu_isr, 0, - dev_name(bank0->pdev), (void *)bank0)) { - writel_relaxed(0, bank0->base + REG_MMU_PT_BASE_ADDR); - dev_err(bank0->pdev, "Failed @ IRQ-%d Request\n", bank0->irq); + if (devm_request_irq(bankx->pdev, bankx->irq, mtk_iommu_isr, 0, + dev_name(bankx->pdev), (void *)bankx)) { + writel_relaxed(0, bankx->base + REG_MMU_PT_BASE_ADDR); + dev_err(bankx->pdev, "Failed @ IRQ-%d Request\n", bankx->irq); return -ENODEV; } -- 2.18.0