Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp505378pxb; Thu, 23 Sep 2021 05:07:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzO1M74SpQM375qI+WwEvuOf+YTioUTgkMF3Px8nSCfmag9BF6hjwy1WATWHOLtph3K3lOQ X-Received: by 2002:a2e:5345:: with SMTP id t5mr4762400ljd.20.1632398829859; Thu, 23 Sep 2021 05:07:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632398829; cv=none; d=google.com; s=arc-20160816; b=ppIX7HpSn7XKesEd31gAessoblhvernGsbyI3Q3t92wsopx6AFYFyxN5DJYP/phi+e wLpq05OXizgSjlyR4eTovPHdz0JipkMT2rU0etKKdXy8Z8rjx89rAXOY0CDQ9wKlUKD4 NoqEAG3txnUaWHoxwKV58rXisLBexThQ5iWp1BkQg9tOC1gBrPbA37njzeJgF0+0q6br Ejkf3JygkOsG3E28t1L96poSLVhNLwWgYNTumufSPPVwm1TyngQgCF4orwSX9xVaOXtN e6cwVZH4I/G4HygbEwz/OMUmQ4RWGN92i93wf2YVN2TidWJdJOEd/EB9JrdGFHZG5GxY EmYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=DJum5VkP4p+KP/c4O3+TS17CCvCXTF2RC/4jex8AIBI=; b=zN54X3gGtijxggG/FpzPDK/g8Ji+vHZom9UmBkejMdO4sGIaJSk7uFaBQFCR6l5hSs ek8NnsgZbquSqQUT7rWfnTszHeflznhzjsRijaaCt8S21jYQk4XtzDmNKLTGh/xMQH5m 7y8vOIwIifX13unlrINsFuPj0g4O+qFLjXGRPNVD0gapbdXCEzs4qzyxR46H66GVZUOW EMLpIoHeDoUspWhxSJgnInufrS1YdgNVc3B4uusg8AwwFBjoHIDSQy9WFcj8FEQzFFKe jQE4jMkdMJErwyPuqgF+Ih+5VrFOqITytjrYCwazgKsG973fEGvz7o9IcmshFPabFpv0 xVbA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 20si5703007edx.466.2021.09.23.05.06.46; Thu, 23 Sep 2021 05:07:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240912AbhIWMEK (ORCPT + 99 others); Thu, 23 Sep 2021 08:04:10 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:53358 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S240934AbhIWMDn (ORCPT ); Thu, 23 Sep 2021 08:03:43 -0400 X-UUID: a6484b7a9a2d44f0813afdf6204c2e28-20210923 X-UUID: a6484b7a9a2d44f0813afdf6204c2e28-20210923 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1200582726; Thu, 23 Sep 2021 20:02:08 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 23 Sep 2021 20:02:06 +0800 Received: from localhost.localdomain (10.17.3.154) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 23 Sep 2021 20:02:06 +0800 From: Yong Wu To: Joerg Roedel , Rob Herring , Matthias Brugger , Will Deacon , Robin Murphy CC: Krzysztof Kozlowski , Tomasz Figa , , , , , , , Hsin-Yi Wang , , , , , Subject: [PATCH v3 19/33] iommu/mediatek: Add list_del in mtk_iommu_remove Date: Thu, 23 Sep 2021 19:58:26 +0800 Message-ID: <20210923115840.17813-20-yong.wu@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20210923115840.17813-1-yong.wu@mediatek.com> References: <20210923115840.17813-1-yong.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lack the list_del in the mtk_iommu_remove, and remove bus_set_iommu(*, NULL) since there may be several iommu HWs. we can not bus_set_iommu null when one iommu driver unbind. This issue is not so important, No need fix tags. Signed-off-by: Yong Wu --- drivers/iommu/mtk_iommu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index faea4a0d922f..2818b984c905 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -980,8 +980,7 @@ static int mtk_iommu_remove(struct platform_device *pdev) iommu_device_sysfs_remove(&data->iommu); iommu_device_unregister(&data->iommu); - if (iommu_present(&platform_bus_type)) - bus_set_iommu(&platform_bus_type, NULL); + list_del(&data->list); if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_MM)) { device_link_remove(data->smicomm_dev, &pdev->dev); -- 2.18.0