Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 23 Sep 2021 09:00:43 -0400
From:   Hamza Mahfooz <someguy@effective-light.com>
Subject: Re: [PATCH v2] aio: convert active_reqs into a hashtable
To:     Benjamin LaHaise <bcrl@kvack.org>
Cc:     linux-kernel@vger.kernel.org,
        kernel test robot <yujie.liu@intel.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, linux-aio@kvack.org
Message-Id: <7H1WZQ.H8D3XK8HUSNQ3@effective-light.com>
In-Reply-To: <20210919145645.GE16005@kvack.org>
References: <20210919144146.19531-1-someguy@effective-light.com>
        <20210919145645.GE16005@kvack.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Precedence: bulk


On Sun, Sep 19 2021 at 10:56:45 AM -0400, Benjamin LaHaise 
<bcrl@kvack.org> wrote:
> You're doing this wrong.  If you want faster cancellations, stash an 
> index
> into iocb->aio_key to index into an array with all requests rather 
> than
> using a hash table.

Would that not mean that, we would have to keep track of the indices of 
the
array that are not being held by an `aio_kiocb`?