Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp664561pxb;
        Thu, 23 Sep 2021 08:11:55 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyJ1bQW+4HIAzCxh3RSQ1S3+QTAq5KqyM562D/hYkn1xYRy3LuW2MTLz6x9lQix9WMQqBli
X-Received: by 2002:a50:e004:: with SMTP id e4mr6150459edl.164.1632409915366;
        Thu, 23 Sep 2021 08:11:55 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1632409915; cv=none;
        d=google.com; s=arc-20160816;
        b=PL/E4KrA4PlbiS2NGMYiSUuCtzkdYk5gpIJLdXmF0aBhvotUFy9xkxnJcZOi27go4T
         UEPE56S/6KnduHl94VzgUAL2cmATmSqmPAv5CZtXoBd8zyhSyw/TUAjKRjuRuBwyZijW
         ntLf+uRoOXXiTzYisZ06PlbFomkhPtaN8KXwANCv7nISwgKoinf8EGG1vdLtZIu5+lTI
         fGABNvbKXvsgckJu1sxHWH6V0OKiRAfPkV+2892iby/aFuDR37FEwANc/hcA4Qk+QvnH
         xFUxMqj/SvKbyqo/MB1ZoS1yjM0hFk59Crfhnxsm15JDady2jpRPdwlbKe5/FG2bbcRe
         Rf4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:content-language
         :in-reply-to:mime-version:user-agent:date:message-id:from:references
         :cc:to:subject:dkim-signature;
        bh=ZCUa17o+e4+Mf3nyTsyOm+AoHjZCOO95Zwlk5h9H3sA=;
        b=daRJBU8expw/NuwVK/DgASJSdDgavZetM26S5Bgv8CQo59qzSTAcOD6ExhYQq+Iofq
         5Jx4tIeyO5HfZ4NLAmPFLJuUaeubvCayz94jJn55SBsOW+AgJzOeAyIGFPpeOT1kOFSY
         FUWO7UBsz8kDsnJg4LLPV5B5xMJ10OksRx5xe/A5++T5hQptvSydOtIbAbAIZnf7sf90
         R2Qykxgxk2yeDf9/D/766h2x33U+YKawszE2zfr7oqNXVUsVIpzNPVdN4pB/Fjehtm/L
         wCNK/a32Vb3lcmMEtkRbWSSqHNIg2MPK+InQJ5Oo8vHr74RO5/zyZCd9WHsakHTPs5ky
         SUeQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OpjLqQ3w;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id p2si5789981ejj.156.2021.09.23.08.11.23;
        Thu, 23 Sep 2021 08:11:55 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OpjLqQ3w;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S241835AbhIWPLB (ORCPT <rfc822;llc123456a@gmail.com> + 99 others);
        Thu, 23 Sep 2021 11:11:01 -0400
Received: from mail.kernel.org ([198.145.29.99]:57794 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S241792AbhIWPLA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Sep 2021 11:11:00 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 34A0561211;
        Thu, 23 Sep 2021 15:09:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1632409769;
        bh=oA+WWs5P3iaZypn5jU4SpKYZzff2WutgvUss6C8I1ls=;
        h=Subject:To:Cc:References:From:Date:In-Reply-To:From;
        b=OpjLqQ3wJS0mnuI98GptpCEetjJ7ryrKPRZawRxcJyOjz39Wm0twQ88tzZObVtMa9
         QirClY/g+GQBLZejLEdyBfzOjNXKsC8u85V5dflPNMap/uUNEpb4PbYBWqazCivDFw
         H1CeAhEm7ctFniGz5gqTchtFCM7PmG7d14tcezwZGUo7yhVbFREvm4RmiW4Vx6F0wc
         4WM7ylAKNg00kdQNmWhhvx9MxVp5DT7oMWgkYHMm2QA9FOmnbvua9/xgug/pzRWpYI
         mEno+UW5OxERAGrRNu1ijGqrngs6+dF99CMPNCbq3VGnxP2JfOZVFXYMhHrksK8y0S
         S0mBdZrDOo02w==
Subject: Re: [PATCH] erofs: fix misbehavior of unsupported chunk format check
To:     Gao Xiang <hsiangkao@linux.alibaba.com>,
        linux-erofs@lists.ozlabs.org, Liu Bo <bo.liu@linux.alibaba.com>
Cc:     LKML <linux-kernel@vger.kernel.org>
References: <20210922095141.233938-1-hsiangkao@linux.alibaba.com>
From:   Chao Yu <chao@kernel.org>
Message-ID: <926fb1a9-174e-26de-c9ed-70aa0a01d394@kernel.org>
Date:   Thu, 23 Sep 2021 23:09:25 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20210922095141.233938-1-hsiangkao@linux.alibaba.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021/9/22 17:51, Gao Xiang wrote:
> Unsupported chunk format should be checked with
> "if (vi->chunkformat & ~EROFS_CHUNK_FORMAT_ALL)"
> 
> Found when checking with 4k-byte blockmap (although currently mkfs

That means for 4k-byte blockmap, chunkformat should be zero, right?

> uses inode chunk indexes format by default.)
> 
> Fixes: c5aa903a59db ("erofs: support reading chunk-based uncompressed files")
> Cc: Liu Bo <bo.liu@linux.alibaba.com>
> Cc: Chao Yu <chao@kernel.org>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,