Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 7/9] xen/x86: hook up xen_banner() also for PVH
To:     Juergen Gross <jgross@suse.com>
Cc:     Stefano Stabellini <sstabellini@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>
References: <4efa804e-3250-227f-00c7-347581366cd4@suse.com>
 <5af11027-cf9d-cf78-9f48-b2ce2edd6e62@suse.com>
 <2ded8c58-b9c3-89dc-6883-1794d1c4126a@suse.com>
 <d9b6e98c-4e75-73f3-1e6d-42df300cfd49@suse.com>
 <89cb2d39-2bfc-dccf-8e92-39e4e952750d@suse.com>
 <f613a83c-2b29-23eb-ca78-a8a75a67f651@suse.com>
 <e095eec1-f35b-ca35-9ad1-54c817e61408@suse.com>
From:   Jan Beulich <jbeulich@suse.com>
Message-ID: <1bcb3b62-8327-7da8-abdb-65ee965714a7@suse.com>
Date:   Thu, 23 Sep 2021 17:31:57 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <e095eec1-f35b-ca35-9ad1-54c817e61408@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmU4TnZOTE00NXNrdEQyM1NvZnovR3JTZjgwbEFQZWFSWTc3bXRsSzhidWlz?=
 =?utf-8?B?SWxZMDlaTGk1KzdsZFh5WXlMdjBIWGZOZEFjSk1MZ2g1NDd6bHdNRmJBV0s2?=
 =?utf-8?B?Rzlkc2JXSTk5aWY5TEMrbVN2RExGKzVIQ3hoeC9PSTFnRU9va0V0aXlnNHFZ?=
 =?utf-8?B?ajFkZ3hlMXd6MjhDNjZxWlFjaCt6SmNObEd5RXBzMFFYalUvdkdtbFc5aDNp?=
 =?utf-8?B?K01tbVEzclJ3SVBxS2dpRkJsc1lBOHNBRDhYU1FWR0J4enNSNnZoV0MwcW1q?=
 =?utf-8?B?Q1JQNEhpZ2lSdmtnbTl2eTBNaFZiMVRKbk81QklsOTJrY3o1UG43V1NPMGNS?=
 =?utf-8?B?VHEwZ1ZvWE1jb05xQ1JGK3ZBRWYwaUpwRmIyQ1AvSkR2d0hub0toS1JvMHlV?=
 =?utf-8?B?R2RRSCtjNHlBSzB4T0RGN0RydVpobnBHSTNFVGJBb0ZVYXFlT3ZMVVBBK21k?=
 =?utf-8?B?dVN3cytjdFp5RVpPMXIwZHB5ZkxSU3hFSWlDdmxRSVlKaVNWQ0NSMEMwc0xv?=
 =?utf-8?B?NldGMVNmNTlTd1lxUXVoeTBoYmc5SHFwM3ZoUmEzNGFLMWtjSWozaDlVc2J3?=
 =?utf-8?B?aC9GYnk0b0FKQm5PVWFmS2FIZnpqNnFqblh2VWdvbHhud2FTR3RQMUh6TTFR?=
 =?utf-8?B?UGs0dnY0NFJoTnVDdHBWa0dJQyt2a3JzOEJPTXNyRWpXVUF0cjB4K3NGMkVi?=
 =?utf-8?B?SFB3Zm8zOHBjaFFWczJUcFYzbUxLVEcwYUoxRXR0YkQxTkdtVHF4eWxROXFm?=
 =?utf-8?B?VHNaemFLSWlrNVk0SDRWRFN2MFdONThzMVJDTmxWNTdnUWZ4OFRZTzZlMDB2?=
 =?utf-8?B?MDN4a2tpelcwcVVFZEw3U0x3Y21Mcm52MHpWanA2YXlockYrcy9ZRlZmcGZu?=
 =?utf-8?B?N2FxdFp0aVNaZmI1NmdpUklYTmFSLzBranRLZGxPbS9KQk5Vb2d5T1pKN3pT?=
 =?utf-8?B?WktUcCs5bFZpZCtQcUFTNnc3alJqUnpaTnRvU0RKek5OQi9CTTFVMzEzQ24r?=
 =?utf-8?B?ZDFMR2hVbXNvaHcrRW1VSGNyc1h3M3pydllHVU5kZFRlNElWSEI1NktBUzhr?=
 =?utf-8?B?bTFCTFhuOExYbjJKL2VVNnMrM1NDZCtWbHg3V3pYVGhxQUNEd3F5SUV6UlIr?=
 =?utf-8?B?WFNrdFcvWmpXdVZzR0grZW5kUzJScjBZYnVoWW1HN1lmVmthR3lEektzZVlJ?=
 =?utf-8?B?bkNiMU1KQzFIMFNnQUMvWkt5c2VyeXI3eFV4Z0c1MEF3VldrenhGMGw5MWpK?=
 =?utf-8?B?RnU3eTFha3VRTjZaaFRqTE1UZEE0Z0xMSTg2UjBQR2VOdFJ4azl2ZFFhSFNO?=
 =?utf-8?B?SndveDl4Z2xmRGtFZXdlVDljdjNZSU9FUVFUc2lPS2hJSXpHZVJ5d1lhU0N4?=
 =?utf-8?B?OVluOTRmYUNhVFl3TUtUQ2ZvWTNSTVROTWxBRGpnbFN6USs0TzNqdDhnRVE5?=
 =?utf-8?B?Z0VMQ1lzb0RJaEp5Zmg3U0drVFpPVDRuZ2x6N0dlRW45YmJzUWswQitKTVNu?=
 =?utf-8?B?NWZOQTVQWVN0VnNLOTlxNVVTak1SSFNJSzF5OFlVM3RGUDROWGlWWi9TSkVB?=
 =?utf-8?B?LzBoVWl6VjAzWVgrYTJUUVdZUEEyeFdYZExDMS9YNFBhUnRVSC8zRlFvUlVQ?=
 =?utf-8?B?VHZsL2REN3lLR2lJaWt6SCtEUDNYbUx0RW5FZkVWU2NGbTlVSFRCcVVFRWZu?=
 =?utf-8?B?VWU2cEY5SjhjVFZ1ZGhqMEExVWt5Q0dYWmlZZGVUUUJra0NoaC81TWRKZUkr?=
 =?utf-8?Q?N2skWF7X/M1xfwoMvyk0TScRY+xX2COGtiQV7yD?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 416953b3-d528-477b-5289-08d97ea74868
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2021 15:31:58.9939
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 188gB6kPrY2aEcMVPD2BV3o8uiFr/2HV5Kmev+AYknyl1GYtXsls50A7LqsuzoMnhCG+CdRbMWdmtIM8qGMwqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6863
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 23.09.2021 17:25, Juergen Gross wrote:
> On 23.09.21 17:19, Jan Beulich wrote:
>> On 23.09.2021 17:15, Juergen Gross wrote:
>>> On 23.09.21 17:10, Jan Beulich wrote:
>>>> On 23.09.2021 16:59, Juergen Gross wrote:
>>>>> On 07.09.21 12:11, Jan Beulich wrote:
>>>>>> This was effectively lost while dropping PVHv1 code. Move the function
>>>>>> and arrange for it to be called the same way as done in PV mode. Clearly
>>>>>> this then needs re-introducing the XENFEAT_mmu_pt_update_preserve_ad
>>>>>> check that was recently removed, as that's a PV-only feature.
>>>>>>
>>>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>>>>
>>>>>> --- a/arch/x86/xen/enlighten.c
>>>>>> +++ b/arch/x86/xen/enlighten.c
>>>>>> @@ -261,6 +261,18 @@ int xen_vcpu_setup(int cpu)
>>>>>>     	return ((per_cpu(xen_vcpu, cpu) == NULL) ? -ENODEV : 0);
>>>>>>     }
>>>>>>     
>>>>>> +void __init xen_banner(void)
>>>>>> +{
>>>>>> +	unsigned version = HYPERVISOR_xen_version(XENVER_version, NULL);
>>>>>> +	struct xen_extraversion extra;
>>>>>
>>>>> Please add a blank line here.
>>>>
>>>> Oops.
>>>>
>>>>>> +	HYPERVISOR_xen_version(XENVER_extraversion, &extra);
>>>>>> +
>>>>>> +	pr_info("Booting paravirtualized kernel on %s\n", pv_info.name);
>>>>>
>>>>> Is this correct? I don't think the kernel needs to be paravirtualized
>>>>> with PVH (at least not to the same extend as for PV).
>>>>
>>>> What else do you suggest the message to say? Simply drop
>>>> "paravirtualized"? To some extent it is applicable imo, further
>>>> qualified by pv_info.name. And that's how it apparently was with
>>>> PVHv1.
>>>
>>> The string could be selected depending on CONFIG_XEN_PV.
>>
>> Hmm, now I'm confused: Doesn't this setting control whether the kernel
>> can run in PV mode? If so, that functionality being present should have
>> no effect on the functionality of the kernel when running in PVH mode.
>> So what you suggest would end up in misleading information imo.
> 
> Hmm, yes, I mixed "paravirtualized" with "capable to run
> paravirtualized".
> 
> So the string should depend on xen_pv_domain().

But that's already expressed by pv_info.name then being "Xen PV".

Jan