Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp690870pxb; Thu, 23 Sep 2021 08:42:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8UQrtgvB7PxT8q7Jf5Tro01msRCiShJdCzm1q4H053lGg1a0DFkaepElKaIpu02fdmnmO X-Received: by 2002:a05:6e02:2144:: with SMTP id d4mr3988488ilv.250.1632411742830; Thu, 23 Sep 2021 08:42:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632411742; cv=none; d=google.com; s=arc-20160816; b=cUsyENuGUUkoZAV7arxpC9wPKlaoCV+VEZPhqoWPrBVHz/fCVQoVVmnZwMKcy/Yo0L 51Ws5HccLCgceg7APzpKHMmJh0eJST/UF7+I0G9CKgHp09LMjOwHibkuTUJRhfckqN7v 1LymCvHUwUdcsCy2lM7VzwILaoRC8pCZ/gJgzDe+Bj65yVqONsFSFFlZKZ/xQ+QbT+SX 8hKXSGL3BZuBfzNwdUQlxEe+HsBqxWQaRTVk723VI15Yx4QcFo0BQ7OCR0/JEJGOGH+D 7Ait9qWWPUXLo2Raz0MCR5o0qNfUZTmvqSWVldr4oxKxq5hIpJ5NwLCH30oybblk1zRm eiaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:cc :references:to:from:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=GoAZ0/CRy27WnTWJaxXB1eOiw+SfG4rWLmsGg9C3DZ8=; b=STBHjhgvAX/sSazGhy/8bvXI49JPkmEjwoNzXCdvuvd+0m4Lj9aan4FOOeafJzw891 qmpaTwi1gkNeSQ3FostoDWhN+yuoGKY0kWTCvbAr4nOaYPRRmoohsUnqzf/5b5KjEFyb z/G1bUQu53PsMKHnefeqGExKfNALSzgG4MYU9fIwW2JtHQRJFHQhy2H+jBbOfqPReBoM edYsBnQj6vrEz879lItAY+OmE1FlK+0WzbyxpuHUmWcYBiSFQsS5drQLZjoPyFvqEz4Q 6aA35Xep2FkxuEKgD8Q44TgEO78d5qcjyrviEtWVJoYTKWL6HXyNHa9M85LPwF5so8Ma nH+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paragon-software.com header.s=mail header.b=ruF27QuU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=paragon-software.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d188si7230464iog.62.2021.09.23.08.42.04; Thu, 23 Sep 2021 08:42:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@paragon-software.com header.s=mail header.b=ruF27QuU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=paragon-software.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242085AbhIWPmh (ORCPT + 99 others); Thu, 23 Sep 2021 11:42:37 -0400 Received: from relaydlg-01.paragon-software.com ([81.5.88.159]:39386 "EHLO relaydlg-01.paragon-software.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241995AbhIWPme (ORCPT ); Thu, 23 Sep 2021 11:42:34 -0400 Received: from dlg2.mail.paragon-software.com (vdlg-exch-02.paragon-software.com [172.30.1.105]) by relaydlg-01.paragon-software.com (Postfix) with ESMTPS id 7B18082328; Thu, 23 Sep 2021 18:41:00 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paragon-software.com; s=mail; t=1632411660; bh=GoAZ0/CRy27WnTWJaxXB1eOiw+SfG4rWLmsGg9C3DZ8=; h=Date:Subject:From:To:References:CC:In-Reply-To; b=ruF27QuU0NH2Xs6prrDvO3iHpgeOH2BEKOh2il5sPT9sK6Pt9tM5ln4hXxKcTdsGV NgSqoF3xc1096WRzUWcM4+iirYSHoEBC2RbMP5enVOUw19KP0pwX/O31gr4K3b+m0Z 4JUXrIABtEsM0HX0MSaF4o+k9N4VxFf0UZnXMY1w= Received: from [192.168.211.73] (192.168.211.73) by vdlg-exch-02.paragon-software.com (172.30.1.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 23 Sep 2021 18:41:00 +0300 Message-ID: <93b2af74-22c2-4f36-8ad7-c1cb035e00f4@paragon-software.com> Date: Thu, 23 Sep 2021 18:40:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: [PATCH v2 1/6] fs/ntfs3: Fix logical error in ntfs_create_inode Content-Language: en-US From: Konstantin Komarov To: References: CC: , In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.211.73] X-ClientProxiedBy: vdlg-exch-02.paragon-software.com (172.30.1.105) To vdlg-exch-02.paragon-software.com (172.30.1.105) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We need to always call indx_delete_entry after indx_insert_entry if error occurred. Signed-off-by: Konstantin Komarov --- fs/ntfs3/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c index d583b71bec50..d51bf4018835 100644 --- a/fs/ntfs3/inode.c +++ b/fs/ntfs3/inode.c @@ -1575,7 +1575,7 @@ struct inode *ntfs_create_inode(struct user_namespace *mnt_userns, if (!S_ISLNK(mode) && (sb->s_flags & SB_POSIXACL)) { err = ntfs_init_acl(mnt_userns, inode, dir); if (err) - goto out6; + goto out7; } else #endif { -- 2.33.0