Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <a3dad3d1-6216-c289-d0fe-ffb36950481c@paragon-software.com>
Date:   Thu, 23 Sep 2021 19:12:52 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.1
Subject: Re: [PATCH v2] fs/ntfs3: Remove deprecated mount options nls
Content-Language: en-US
To:     Kari Argillander <kari.argillander@gmail.com>,
        <ntfs3@lists.linux.dev>
CC:     <linux-kernel@vger.kernel.org>,
        =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali@kernel.org>
References: <20210921171901.49176-1-kari.argillander@gmail.com>
From:   Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
In-Reply-To: <20210921171901.49176-1-kari.argillander@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 21.09.2021 20:19, Kari Argillander wrote:
> Some discussion has been spoken that this deprecated mount options
> should be removed before 5.15 lands. This driver is not never seen day
> light so it was decided that nls mount option has to be removed. We have
> always possibility to add this if needed.
> 
> One possible need is example if current ntfs driver will be taken out of
> kernel and ntfs3 needs to support mount options what it has.
> 
> Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
> ---
> Patch is compile and checkpatch tested.
> 
> v2:
> 	-Do not delete {}
> ---
>  fs/ntfs3/super.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
> index 6a535b144ff9..800897777eb0 100644
> --- a/fs/ntfs3/super.c
> +++ b/fs/ntfs3/super.c
> @@ -246,10 +246,6 @@ static const struct fs_parameter_spec ntfs_fs_parameters[] = {
>  	fsparam_flag_no("prealloc",		Opt_prealloc),
>  	fsparam_flag_no("acsrules",		Opt_noacsrules),
>  	fsparam_string("iocharset",		Opt_iocharset),
> -
> -	__fsparam(fs_param_is_string,
> -		  "nls", Opt_iocharset,
> -		  fs_param_deprecated, NULL),
>  	{}
>  };
>  
> 
> base-commit: 6354467245ff8dd04b54e39790f2ee4d21d5419e
> 

Applied, thanks!