Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Minchan Kim <minchan.kim@gmail.com>
Date:   Thu, 23 Sep 2021 09:47:44 -0700
From:   Minchan Kim <minchan@kernel.org>
To:     Brian Geffon <bgeffon@google.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Nitin Gupta <ngupta@vflare.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Jonathan Corbet <corbet@lwn.net>, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-block@vger.kernel.org,
        Suleiman Souhlal <suleiman@google.com>,
        Jesse Barnes <jsbarnes@google.com>
Subject: Re: [PATCH v4] zram: Introduce an aged idle interface
Message-ID: <YUyvsJz+aMCtlRxD@google.com>
References: <20210917210640.214211-1-bgeffon@google.com>
 <20210923130115.1344361-1-bgeffon@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210923130115.1344361-1-bgeffon@google.com>
Precedence: bulk

On Thu, Sep 23, 2021 at 06:01:15AM -0700, Brian Geffon wrote:
> This change introduces an aged idle interface to the existing
> idle sysfs file for zram.
> 
> When CONFIG_ZRAM_MEMORY_TRACKING is enabled the idle file
> now also accepts an integer argument. This integer is the
> age (in seconds) of pages to mark as idle. The idle file
> still supports 'all' as it always has. This new approach
> allows for much more control over which pages get marked
> as idle.
> 
>   v3 -> v4:
>         - Remove base10 restriction.
> 
>   v2 -> v3:
> 	- Correct unused variable warning when
> 	  CONFIG_ZRAM_MEMORY_TRACKING is not enabled.
>   v1 -> v2:
> 	- Switch to using existing idle file.
> 	- Dont compare ktime directly.
> 
> Signed-off-by: Brian Geffon <bgeffon@google.com>
Acked-by: Minchan Kim <minchan@kernel.org>