Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp757010pxb; Thu, 23 Sep 2021 09:57:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAssJiDu4nyXCRuuh5ZPPYakkWECdWDekLLNd8hUeh3P35yAFRZiOomac3sLpUrkY5BtHD X-Received: by 2002:a17:906:c005:: with SMTP id e5mr6218417ejz.480.1632416268206; Thu, 23 Sep 2021 09:57:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632416268; cv=none; d=google.com; s=arc-20160816; b=cefKEXS0aOWDYO7aCfzelKgPCXydYwWu9w5PeUEGwC9kEkwMhc6O0CDPRSMdOu+V0p dPvLG2DZRhbmCH5s6G9Rocf4i5K/WX28VVG/qddSQx+pCmbuliyU1hS3LjmmdXxcI2dr AHA73HYoVj+Y/+1UolaVTzjGTO0mCNHwGm55KqWxNxmm0eZi2P9p2VFpdfdKs20e3fUC ze/1SFAzcWjITTRCf0ROqQ7fq8oUIBfFlRM8OAnj4+fwqFMyNzlrbrQ8ILzE0jZJjW07 cyWYANiQG/bhnaNC08u1mSGpdSzzEGgKEaIeb07dt7WNcM04RmKGpc1oncGzu6RaBoeY g+4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=DWiYE5PlDpcOkC5MUYl+fxwBrXWREwOnybuqcTDEovo=; b=JD437lDA+n6koHAE4tb7z2oaLmYN3IIHdbm+c8fT6Aqe8bGqkBHeMCkRH+XhkJY0av oaUCqCBecn9hfgyJMiXBOuLWDv3mDVmJOz6AlU1Kph8DKl/xWh71JDFE53PSDLCNGv3O TCBTpg2qebwdVIGhu5rtnY7ONbdjaSPL2paZr/dTEpSlmbNzMyv1urSPCd6x5JpTvRUM 2qPuCsevIOIdyXpOZDJa7V0v2v0ipnGnkx4He/d+qgLeKuIdysfxCnN/fRI0fkw/bzbA Ot9HcPgWWXXy5UFvFIILXC6Rd43Q2RVfxtUIfq1uo8Tb6NGgV5Cm7/ULXdXX5FQkzrA+ jHsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gx23si8025100ejb.285.2021.09.23.09.57.22; Thu, 23 Sep 2021 09:57:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242457AbhIWQ4d (ORCPT + 99 others); Thu, 23 Sep 2021 12:56:33 -0400 Received: from kanga.kvack.org ([205.233.56.17]:45554 "EHLO kanga.kvack.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240732AbhIWQ4U (ORCPT ); Thu, 23 Sep 2021 12:56:20 -0400 X-Greylist: delayed 1025 seconds by postgrey-1.27 at vger.kernel.org; Thu, 23 Sep 2021 12:56:20 EDT Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C79E900002; Thu, 23 Sep 2021 12:37:43 -0400 (EDT) Date: Thu, 23 Sep 2021 12:37:43 -0400 From: Benjamin LaHaise To: Hamza Mahfooz Cc: linux-kernel@vger.kernel.org, kernel test robot , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-aio@kvack.org Subject: Re: [PATCH v2] aio: convert active_reqs into a hashtable Message-ID: <20210923163743.GZ24576@kvack.org> References: <20210919144146.19531-1-someguy@effective-light.com> <20210919145645.GE16005@kvack.org> <7H1WZQ.H8D3XK8HUSNQ3@effective-light.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7H1WZQ.H8D3XK8HUSNQ3@effective-light.com> User-Agent: Mutt/1.4.2.2i Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 23, 2021 at 09:00:43AM -0400, Hamza Mahfooz wrote: > Would that not mean that, we would have to keep track of the indices of > the > array that are not being held by an `aio_kiocb`? Correct. This is a better solution than the hash table and would mean that the requests list could likely be replaced by the table. -ben -- "Thought is the essence of where you are now."