Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 23 Sep 2021 17:23:21 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     "Joshi, Mukul" <Mukul.Joshi@amd.com>
Cc:     "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bp@alien8.de" <bp@alien8.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCHv3 2/2] drm/amdgpu: Register MCE notifier for Aldebaran RAS
Message-ID: <YUy4CdcUWJzQfM4N@yaz-ubuntu>
References: <20210913021311.12896-2-mukul.joshi@amd.com>
 <20210922193620.15925-1-mukul.joshi@amd.com>
 <YUyPM7VfYFG/PJmu@yaz-ubuntu>
 <DM4PR12MB52639349DF98DB01A3B155EFEEA39@DM4PR12MB5263.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DM4PR12MB52639349DF98DB01A3B155EFEEA39@DM4PR12MB5263.namprd12.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3cnQWxwLm0PrSrOrRRS0O2Oypsue5dDZgYvDpEg5KrIr9YnAfcbfrgwRJV8T?=
 =?us-ascii?Q?EwCUGNU/8EvmC5PZdkG64KhlnOvVPnijoUGS8M9uga0gYvfIGPKBzNPjtACq?=
 =?us-ascii?Q?VT65/RfNmiYqs7ml4Jy9c43Fe9cKpOMmNxeVWNXIiJCvrn8ipvu3ihKGCWO1?=
 =?us-ascii?Q?YA+jBuXKeazjx5pGXawxZBxQLsDOIwxSaqFbdF74ojr/Qhzgk1koCyK+ln6/?=
 =?us-ascii?Q?15SBnJjq+rK5Q6sD2E2IOa8YpObzK5Zp6EmPBqGwEVLScfJcWwf1cqVtfsp+?=
 =?us-ascii?Q?nXmEDOVWRnfvKPHzNh0PRfkqnvF56a2BLXUxvfST4/HJ243SXq4IVY53ViE0?=
 =?us-ascii?Q?JWxlvYK2uO13bnNQGTONTl7hpcG8P/85bMxJ93lzf43NQszyO/EZOCE6U4Zt?=
 =?us-ascii?Q?iKTbiaZWppUe7DgbQmEPqckNVQelZDL/diY6xVOcFhXeoaEX8rhg7EcqYeXJ?=
 =?us-ascii?Q?B6J4WrcCzuuax1CPvo7gIcXDbGLQdEG1xl3HIanFK/85Sm/V17wZT35FgP5r?=
 =?us-ascii?Q?EnsnEF5n8HI+07Hp8FVPoSNRKcvzc1SqmMmwTu9Slbhyr6/vwH+2jKZDrQBA?=
 =?us-ascii?Q?ZB3IpDItt1gWn/57CYENkP6jhpFlZhm7XIdrBSy728KGDl91AwXJYjPAZNnJ?=
 =?us-ascii?Q?OPTRgGSv4y+z1st67tfHtVOrQ+JyFdRkkaxH6u0xkclCIpmSRallFFk+L0Cd?=
 =?us-ascii?Q?wssF5f7kpQTwrz/I6LurNNrxIQfbOVChhKW8KtcWT52v2gH9O87bPrdaeQ/o?=
 =?us-ascii?Q?KAganVyUiSLfc9AbAFW2ydjaj9fR7TjwJYMIUP8zJiufdpFgp1kzcGGxLPOa?=
 =?us-ascii?Q?S4wXvJnSnl5u29je3esJqThpjmlTLfIVDvW1f9pYff+UeeEIKvEqE9cl13Nc?=
 =?us-ascii?Q?C0xH+FVL2oI6sBEjV82RzQ9gJLGkVlyT271GsxPiQQ+kOrssdXUxfIacrUZ2?=
 =?us-ascii?Q?NYmxU0gCwL0Z/KykQsLfL7Vpa3r/7JexSalUfALPqlt+qfzw8aYIRNxyQmz4?=
 =?us-ascii?Q?B4/Ib76uhcOTIj5P1YwIqR5E6q/2tGAINt3IyKEBZpJqTIdHmgC+GW3CL7ov?=
 =?us-ascii?Q?bfJkhNw9hRZIlOoRDDJ2txpdXJGk8v3nFgetN6n2CwqLNY2hUrstOBw16/qu?=
 =?us-ascii?Q?C3ga8340UsE/Z9kpR5WN/qRysJ+XWcDQZL6iiZwfE9/PIYxEUbY9YDUvHUpC?=
 =?us-ascii?Q?sqx9gtf7i7GUraeRtU1qJnOQa1/FA+K5g/zQnOTCWwj2GmeLj0GpZWYH9N8d?=
 =?us-ascii?Q?w+m0AJ17q9XzyC/tnuZmQLNjCTb3S8EMqrYqrVX/iroI+14GD7t/WVu8pQgD?=
 =?us-ascii?Q?szmSep2xbwYj+EymK1n9/WDe?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33db7421-c078-4ada-0020-08d97eb6dcff
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2021 17:23:30.7492
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PutWnFBdSgCxZD1gzLhCsjq4nkLg5q60VewALkMnxUwlkWzWDvOG4atFWbVfuy8G56joGxT5L4m9+OCySsoJuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0081
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 23, 2021 at 11:30:55AM -0400, Joshi, Mukul wrote:
...
> > > +		return NOTIFY_DONE;
> > > +
> > > +	/*
> > > +	 * If it is correctable error, return.
> > > +	 */
> > > +	if (mce_is_correctable(m))
> > > +		return NOTIFY_OK;
> > 
> > Shouldn't this be "NOTIFY_DONE" if "don't care" about this error?
> 
> The thinking is we want to stop calling further consumers since it's a correctable error in GPU UMC and we are not taking any action about the correctable errors.

Shouldn't the error still be reported to EDAC for decoding and counting? I
think users want this.

But it looks to me that either NOTIFY_OK or NOTIFY_DONE will allow this, so
it's not a big deal. Was this intended to be NOTIFY_STOP?

Thanks,
Yazen