Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v6 05/10] x86/tdx: Handle port I/O
To:     "Kuppuswamy, Sathyanarayanan" 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>
Cc:     Dave Hansen <dave.hansen@intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kirill Shutemov <kirill.shutemov@linux.intel.com>,
        Sean Christopherson <seanjc@google.com>,
        Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
        linux-kernel@vger.kernel.org
References: <20210922225239.3501262-1-sathyanarayanan.kuppuswamy@linux.intel.com>
 <20210922225239.3501262-6-sathyanarayanan.kuppuswamy@linux.intel.com>
 <c2fa7839-49d5-3e1c-97c4-c1b77e11ef93@amd.com>
 <6cb4efa4-6f40-37f4-8807-e44b2c069021@linux.intel.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <0f2a09ca-b098-03ba-a166-6f31c718220b@amd.com>
Date:   Thu, 23 Sep 2021 12:59:43 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <6cb4efa4-6f40-37f4-8807-e44b2c069021@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUtCK3V3Mko5VjJQZDlCbmJ1STd2aTJlN1dIaFErMVlwelJtSGo2b3FibFV2?=
 =?utf-8?B?M2JuSnhYZU5yQUJqWjhkY2ttblc5S3ppVXRuNTd5MFIvK3VMcTZyNWpnSU1V?=
 =?utf-8?B?WXN0d2NjU3BjZEJSdDFHR21qV3BsRTU2WEFLZUo5M21NNTVJMHRMNmQ3YnBx?=
 =?utf-8?B?ZnRndWRkc2JENC8vTklWY2dlTFRmQzRWV1V0NVVIemxLUzlpbFZzSWVyZlYx?=
 =?utf-8?B?R2tqSjlpL2pDSUtieEJVaDVjeXhhSjdQSTlxdlZ3Y1RYMnU4U05ITGlITHlJ?=
 =?utf-8?B?TnQ5aFErR1ZTYjMxR2ZEYlZYa253djUrNWdJN0VBcGx0M1pnYUJmRXdyS2d2?=
 =?utf-8?B?QkI2a005RmdDSUVjajJJT0FFMGx1ZmVGTkdnOWlOemErSzBNKzNMdW1VSTFr?=
 =?utf-8?B?QnppRnNxaUUwaTltWTROeGNvZEM0OEdGTlNKeDhVOE91Z2VscE5uVGRXNjRQ?=
 =?utf-8?B?R3VhcEliUXlmNzBxcUFIMmpPc0hwVHYvbExrVDA5cy9WenJ6SzJwYkNVbUpu?=
 =?utf-8?B?Vkx1MmhUWUdHMit4L1NobmNGei9yMjc1ZHpLRjNDNjZiL2hqeTlrYm0zOFRT?=
 =?utf-8?B?U0NheC9XNmxsbk9YM1JpSlA5ZVplQmp4V0JhOXFJZzFuRmFaT3dLd3R1Z1NC?=
 =?utf-8?B?QVBIeHNPTVNZN205V3ZCL1dBQytRS0RmVVhSaXRFUE1UeUJCV0hPbUpnS0o5?=
 =?utf-8?B?b2NGbFlGUDh0TFRDeTQ1MFBFN09PMFFoYjZGVVJxRVRhakhGaXBUYUhCZGwz?=
 =?utf-8?B?cTFQVXVSRlpYMzUxU3ZLbk5HUVhvZEdXajZQT08zcDU5aWpvNE5jcGxuU1k2?=
 =?utf-8?B?Z1FvdjBVY3hieDhhTkg3ZUNmWkVYTzJQMEVsa2xwZE5PUXh5S3dQUjNQVTMv?=
 =?utf-8?B?L1B0VFM3UHYzZTI3Y2d1Z3YwUnU3UGhnV2xGQ3V6bVBuTWx3Wk9IWHZxYmhT?=
 =?utf-8?B?QVhONzBPdlRHSVZudTlqV0tBUkxxVk5iUjhPY2ZnbXpPcVhueUl4TjVCeXR2?=
 =?utf-8?B?cS9kWVNRa3BzcnNEMExlSzdXbEJISXJaNThDeEVMaDU5WFBxNXZQQnltK0ZF?=
 =?utf-8?B?aEduVEY4eXk3djdEdkx4VThFc3J0R1lFZ00wcE5TREQ2RkJRb1pLQzR5OFJZ?=
 =?utf-8?B?enJrZU5GVVRyUDlhK3RqNGVrQVh5a2NKV1RkSVpYMUhvdFkrRzhianpYeHRq?=
 =?utf-8?B?NVoyY1dseWpuMlhSRXNJOVpsL1FxWnNmTVpFMXg5Um1nK3U1eHk3R2xERUFk?=
 =?utf-8?B?V1dVdnNUOW5SVko5WjJWMFhwUkRzeEVheUZBc0FkTnRKbHBPTm1DcUdOcFhu?=
 =?utf-8?B?LzBRRnBmRkI4UlViRmUrRUd4SVp3ZXBLTXF5VFp1ZlBQeVFwMW1raEYzb2ty?=
 =?utf-8?B?RkpweHEremFHK2tIKzFTS3RkY01LbXRvV3RaVC9KQzV5NU1UckY4Y0lybWQr?=
 =?utf-8?B?RTkxUzIxbVZCOXpjRllwa096eUdRdXNzelJac1d5NE5RZ2w0YWJwU0NtZ0tG?=
 =?utf-8?B?WFk5OVNkNHZReUtqUUlTc2tTam11L2tBY2FzNXMzN2kwNUxWaVhYbkNkNk9j?=
 =?utf-8?B?ckY0dnNtbU5WYzNDZ0xTN080Z2tVSklFSE9JV0hTaHF2NU5aemhWSXo4Q1FP?=
 =?utf-8?B?ZE1mRkJpRlpBYUt0eGh1eWY3NmlTYklwWFBXckE1Q1JzQ3MxS3U1SVhZejdN?=
 =?utf-8?B?cStBeHRJZGJ3Tzg0VzFzWkhBdHZvdjdlSUdTZWdxVFU5VEZYNzQySUpYMG1a?=
 =?utf-8?Q?2tMNefljkomtQIYPfnphu6ieJSu/3YplfdNjzvA?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e8e5f08-f6ed-42af-0e5a-08d97ebbed5a
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2021 17:59:45.9455
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mHJxC/AwgWc8guf7z92Ppw13ahi9J35wCK4p4a9Fm0H8Jy6oF6W6TL5REWvYN7/40le8BVD/bpXJG9Q4lc+xug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5463
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/23/21 12:24 PM, Kuppuswamy, Sathyanarayanan wrote:
> 
> 
> On 9/23/21 9:32 AM, Tom Lendacky wrote:
>> On 9/22/21 5:52 PM, Kuppuswamy Sathyanarayanan wrote:
>>> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
>>>
>>> TDX hypervisors cannot emulate instructions directly. This includes
>>> port IO which is normally emulated in the hypervisor. All port IO
>>> instructions inside TDX trigger the #VE exception in the guest and
>>> would be normally emulated there.
>>>
>>> Also string I/O is not supported in TDX guest. So, unroll the string
>>> I/O operation into a loop operating on one element at a time. This
>>> method is similar to AMD SEV, so just extend the support for TDX guest
>>> platform.
>>>
>>> Add a new confidential guest flag CC_ATTR_GUEST_UNROLL_STRING_IO to
>>> add string unroll support in asm/io.h
>>>
>>> Co-developed-by: Kuppuswamy Sathyanarayanan 
>>> <sathyanarayanan.kuppuswamy@linux.intel.com>
>>> Signed-off-by: Kuppuswamy Sathyanarayanan 
>>> <sathyanarayanan.kuppuswamy@linux.intel.com>
>>> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>>> Reviewed-by: Andi Kleen <ak@linux.intel.com>
>>> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
>>> ---
>>>
>>> Changes since v5:
>>>   * Changed prot_guest_has() to cc_platform_has().
>>>
>>> Changes since v4:
>>>   * Changed order of variable declaration in tdx_handle_io().
>>>   * Changed tdg_* prefix with tdx_*.
>>>
>>> Changes since v3:
>>>   * Included PATTR_GUEST_UNROLL_STRING_IO protected guest flag
>>>     addition change in this patch.
>>>   * Rebased on top of Tom Lendacks protected guest change.
>>>
>>> Changes since v2:
>>>   * None
>>>
>>> Changes since v1:
>>>   * Fixed comments for tdg_handle_io().
>>>   * Used _tdx_hypercall() instead of __tdx_hypercall() in tdg_handle_io().
>>>
>>>   arch/x86/include/asm/io.h   |  7 +++++--
>>>   arch/x86/kernel/cpu/intel.c |  1 +
>>>   arch/x86/kernel/tdx.c       | 35 +++++++++++++++++++++++++++++++++++
>>>   include/linux/cc_platform.h | 11 +++++++++++
>>>   4 files changed, 52 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h
>>> index fa6aa43e5dc3..67e0c4a0a0f4 100644
>>> --- a/arch/x86/include/asm/io.h
>>> +++ b/arch/x86/include/asm/io.h
>>> @@ -40,6 +40,7 @@
>>>   #include <linux/string.h>
>>>   #include <linux/compiler.h>
>>> +#include <linux/cc_platform.h>
>>>   #include <asm/page.h>
>>>   #include <asm/tdx.h>
>>>   #include <asm/early_ioremap.h>
>>> @@ -310,7 +311,8 @@ static inline unsigned type in##bwl##_p(int 
>>> port)            \
>>>                                       \
>>>   static inline void outs##bwl(int port, const void *addr, unsigned 
>>> long count) \
>>>   {                                    \
>>> -    if (sev_key_active()) {                        \ > +    if 
>>> (sev_key_active() ||                        \
>>> +        cc_platform_has(CC_ATTR_GUEST_UNROLL_STRING_IO)) {        \
>>
>> Would it make sense to make sev_key_active() and sev_enable_key generic 
>> and just re-use those instead of adding CC_ATTR_GUEST_UNROLL_STRING_IO 
>> and having multiple conditions here?
>>
>> You can set the key in the TDX init routine just like SEV does.
> 
> Any reason for using sev_enable_key over CC attribute? IMO, CC attribute 
> exist
> to generalize the common feature code. My impression is SEV is specific to 
> AMD
> code.

When the SEV series was initially submitted, it originally did an 
sev_active() check. For various reasons a static key and the 
sev_key_active() call was requested.

My suggestion was to change the name to something that doesn't have 
SEV/sev in it that can be used by both SEV and TDX. The sev_enable_key can 
be moved to a common file (maybe cc_platform.c) and renamed. Then 
arch/x86/include/asm/io.h can change the #ifdef from 
CONFIG_AMD_MEM_ENCRYPT to CONFIG_ARCH_HAS_CC_PLATFORM.

Not sure if anyone else feels the same, though, so just my suggestion.

Thanks,
Tom

> 
>>
>> Thanks,
>> Tom
>>
>