Date: Fri, 15 Dec 2006 09:08:43 -0800
From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Zack Weinberg" <zackw@panix.com>
Cc: "Stephen Smalley" <sds@tycho.nsa.gov>, jmorris@namei.org,
       "Chris Wright" <chrisw@sous-sol.org>, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/4] permission mapping for sys_syslog operations
Message-Id: <20061215090843.3bff4ab9.randy.dunlap@oracle.com>
In-Reply-To: <eb97335b0612141721g2e983574k4ea698caa316de6d@mail.gmail.com>
References: <20061215001639.988521000@panix.com>
	<20061215002334.039728000@panix.com>
	<20061214170229.d0f06a57.randy.dunlap@oracle.com>
	<eb97335b0612141721g2e983574k4ea698caa316de6d@mail.gmail.com>
Organization: Oracle Linux Eng.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1135
Lines: 31

On Thu, 14 Dec 2006 17:21:25 -0800 Zack Weinberg wrote:

> On 12/14/06, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > > +#define security_syslog_or_fail(type) do {           \
> > > +             int error = security_syslog(type);      \
> > > +             if (error)                              \
> > > +                     return error;                   \
> > > +     } while (0)
> > > +
> >
> > From Documentation/CodingStyle:
> >
> > Things to avoid when using macros:
> >
> > 1) macros that affect control flow: ...
> 
> It says "avoid", not "never use".  If you can think of another way to
> code this function that won't completely obscure the actual operations
> with the security checks, I will be happy to change it.

The usual answer is to just open-code it.  You may dislike that,
but hiding control flow in macros is held as really bad by
more than just me.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/