Date: Fri, 15 Dec 2006 09:13:26 -0800
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Pavel Machek <pavel@ucw.cz>, lkml <linux-kernel@vger.kernel.org>,
       jesper.juhl@gmail.com, akpm <akpm@osdl.org>
Subject: Re: [PATCH/v2] CodingStyle updates
Message-Id: <20061215091326.4d121119.randy.dunlap@oracle.com>
In-Reply-To: <4582B11C.9070305@s5r6.in-berlin.de>
References: <20061207165508.e6bf0269.randy.dunlap@oracle.com>
	<20061215120942.GA4551@ucw.cz>
	<4582AEC8.7030608@s5r6.in-berlin.de>
	<20061215142206.GC2053@elf.ucw.cz>
	<4582B11C.9070305@s5r6.in-berlin.de>
Organization: Oracle Linux Eng.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1039
Lines: 34

On Fri, 15 Dec 2006 15:28:44 +0100 Stefan Richter wrote:

> Pavel Machek wrote:
> >> Pavel Machek wrote:
> >> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >> >> +Use one space around (on each side of) most binary and ternary operators,
> >> >> +such as any of these:
> >> >> +	=  +  -  <  >  *  /  %  |  &  ^  <=  >=  ==  !=  ?  :
> >> > 
> >> > Actually, this should not be hard rule.
> [...]
> > sometimes grouping around operator is useful,
> [...]
> 
> I agree.
> 
> By the way, the longer CodingStyle becomes, the less people will read it.

That's a good point IMO.

Maybe we could just summarize it with something like:

Use spaces around binary operators for readability but not to imply
any kind of grouping.

But I suppose that Pavel doesn't agree with that.  Oh well.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/