Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp912995pxb; Thu, 23 Sep 2021 13:22:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+zNsWJfRIJ8XsUvdR97cw04WYyCOsURSuKLnuszr1B1tbLVRjBbliL/Gx/TtClEl+qbnJ X-Received: by 2002:a05:6e02:1111:: with SMTP id u17mr5072521ilk.262.1632428538045; Thu, 23 Sep 2021 13:22:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632428538; cv=none; d=google.com; s=arc-20160816; b=iU0e9zrXqGgoi8ja0LnVk0u2BrZs9GVJsqbb/wrUnAhG3Qif3lB0GBGvCNtSxtLhv7 y5lorDpdj64QMpb0uz4eSNHD5weDcvn4A5yl5x8BzOrd5T7HanfwcmP/3tnPU3+jshMr 508e1Xp6sxkZLNigfjvk+6mFExNp9hHm3vO9JeJiBMpmqTMNW9N17fCc0NMeYjvysn2d UfUIYrzirNKfUF5haWD6R7xQaIXT1tPaKpczPhsLB18kKIMof29f8UyYGmgTmfJKLHof CJchtbBP9lqCLXoAgLang/IGgtCJH4qmoQhhBb0ZC+XQg9e7KCwWHQreA5RfZRgc199y cy8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=epEYiPa1v2yRHB56PEurnTlU6IObtXpXTtcKNyJNW0k=; b=dhchsBdf1ivBcu24TMqSEknWs19XF8RAfqqsI4oivvg/N4vj1RXZXhy4cWG5KXAwsT QOnZ8Qdtj8lA+NALi/DtPoe30QsR4X988c3egCLWHkP+lj3F5lt3g4qR4fxoRxi5lyMc 3PbT3TZQ6HiT0jDKYFFB8KRgsObI8miKFVRm0EJzszqZ6eS8UB2WhKppqoMr4dJEkp9O sedWR9N0Lkcbv6Gcs9Ks/jmg9XP4cKqQSpqh4OH9KQ1nTJc69HMdYplWKmIXHrf6eP34 Tf4knD5Vq6v0X0VftCFRp2zHBUuN4Y3sQ64A7Vo5aov3AZnChRMaj0sOmMmzPfRar8Wd R+xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=tDVlkBZl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x11si7491366iom.45.2021.09.23.13.21.43; Thu, 23 Sep 2021 13:22:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=tDVlkBZl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243105AbhIWUVW (ORCPT + 99 others); Thu, 23 Sep 2021 16:21:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243084AbhIWUVV (ORCPT ); Thu, 23 Sep 2021 16:21:21 -0400 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5231C061574 for ; Thu, 23 Sep 2021 13:19:49 -0700 (PDT) Received: by mail-io1-xd2c.google.com with SMTP id r75so9762142iod.7 for ; Thu, 23 Sep 2021 13:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=epEYiPa1v2yRHB56PEurnTlU6IObtXpXTtcKNyJNW0k=; b=tDVlkBZlYy8Pu0FssYMC5ZtYowrWslch1iEi0XyjJMi7g5iPMlEDpeD2XIkRv6C8qT D3xWy1Bzih5e2F7G73DT2kHQyoRx3G/HJRGhmRa0wA64lWXZ3XzFwkwN5Ad7HSVc1wwY CZwrzY0QzjvSvtfbbYjwJrmRt1jGyHk8b7b+bGaPbKIQFMlRlMqMOdljr1LJb0pkjjf6 ue6OE4Nzs/BoYVY7r2sBOOOdKpSWJvmWTdd2xt8Y04u5k+G/pbLnGoq/2E56rAtCPTaq SxMfKLuoOJSO3JXPjZLbV7o42ad7UyjvnkJlCTsqB+3DbiYBJbOlKk7NXFHipVT94CBN zmAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=epEYiPa1v2yRHB56PEurnTlU6IObtXpXTtcKNyJNW0k=; b=nx3/TSpVLhzhFdi3GOdaJjYVcmcEUqVlrP5y75a3JUvEacdmjUNselgCWxzWT6ppkc QSX+HOvddn1+qfd5mFW/kfAr2ivvT9Sh3lN0jDdxQzYIIiQj8Etq/7RBDAqhrCZwQVfq gPPN6zUbYyEtIE7Bv+X2sqkzEdqR7xlTjLFt8RO3Nlf8Qsc4+cZYW9IgngsvTpj3IaL/ TBN286nSw/sewkGw7fDD16+Lmgirbzok7PrN0C2xHMWzqSysfZsJf+OVkziZRt/I2slg r13MzI+yP5YRAfGNrkcnFJBvy97RBOR9WYKgfRs+eF2hofkWE4b+3tTdROK8vJb0Y+z7 N26g== X-Gm-Message-State: AOAM5303KHDAa8QPQxzLg+vO5b1bsOspqXr85ijQRhyATBOwngmLt1os QrsDKwIUxar35T0g0sLmOGx0I9zXeY+i34ncIiaRQA== X-Received: by 2002:a02:711e:: with SMTP id n30mr5847277jac.3.1632428388978; Thu, 23 Sep 2021 13:19:48 -0700 (PDT) MIME-Version: 1.0 References: <1629132650-26277-1-git-send-email-sbhanu@codeaurora.org> In-Reply-To: From: Doug Anderson Date: Thu, 23 Sep 2021 13:19:37 -0700 Message-ID: Subject: Re: [PATCH V1] arm64: dts: qcom: sc7180: Use maximum drive strength values for eMMC To: Bjorn Andersson Cc: Adrian Hunter , Ulf Hansson , Rob Herring , Asutosh Das , Sahitya Tummala , pragalla@codeaurora.org, nitirawa@codeaurora.org, Ram Prakash Gupta , Sayali Lokhande , sartgarg@codeaurora.org, cang@codeaurora.org, Linux MMC List , LKML , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Andy Gross , Shaik Sajida Bhanu , Stephen Boyd , Matthias Kaehlcke Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bjorn, On Thu, Aug 19, 2021 at 6:44 AM Doug Anderson wrote: > > Hi, > > On Tue, Aug 17, 2021 at 6:58 AM Doug Anderson wrote: > > > > > pinconf-data { > > > pins = "sdc1_data"; > > > bias-pull-up; > > > - drive-strength = <10>; > > > + drive-strength = <16>; > > > > I could be convinced that this is the right thing to do, but I want to > > really make sure that it has had sufficient testing. Specifically as > > this patch is written we'll be updating the drive strength for all > > boards. Increasing the drive strength can sometimes introduce new > > problems (reflections, noise, ...) so we have to be confident that > > we're not breaking someone that used to work by increasing the drive > > strength here. How much has this been tested? > > From further discussion internally, it sounds as if this should be > fine and fixes more than just this one eMMC part. Thus: > > Reviewed-by: Douglas Anderson We've been running with this patch in the Chrome OS kernel. If it looks OK to you, it'd be great for it to land in your tree. Thanks! -Doug