Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210921110556.v6.1.I2351df94f18d5d8debc22d4d100f36fac560409a@changeid>
In-Reply-To: <20210921110556.v6.1.I2351df94f18d5d8debc22d4d100f36fac560409a@changeid>
From:   Doug Anderson <dianders@chromium.org>
Date:   Thu, 23 Sep 2021 14:02:21 -0700
Message-ID: <CAD=FV=XNSb-ZNoHzjUQJ2JntF3D4nAoKQ_OLo_7jLomnvdFJ6Q@mail.gmail.com>
Subject: Re: [PATCH v6 1/2] drm/bridge: parade-ps8640: Use regmap APIs
To:     Philip Chen <philipchen@chromium.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Sam Ravnborg <sam@ravnborg.org>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Robert Foss <robert.foss@linaro.org>,
        dri-devel <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Tue, Sep 21, 2021 at 11:06 AM Philip Chen <philipchen@chromium.org> wrote:
>
> Replace the direct i2c access (i2c_smbus_* functions) with regmap APIs,
> which will simplify the future update on ps8640 driver.
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Philip Chen <philipchen@chromium.org>
> ---
>
> (no changes since v4)
>
> Changes in v4:
> - Remove excessive error logging from the probe function
>
> Changes in v3:
> - Fix the nits from v2 review
>
> Changes in v2:
> - Add separate reg map config per page
>
>  drivers/gpu/drm/bridge/parade-ps8640.c | 94 ++++++++++++++++++--------
>  1 file changed, 64 insertions(+), 30 deletions(-)

Pushed both patches to drm-misc-next:

13afcdd7277e drm/bridge: parade-ps8640: Add support for AUX channel
692d8db0a5ca drm/bridge: parade-ps8640: Use regmap APIs

I made a few whitespace fixes reported by `dim apply-branch` (DRM
committer tool) and also re-arranged your Signed-off-by to be above
the Reviews/Acks.

-Doug