Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210921052821.91-1-caihuoqing@baidu.com> <20210921052821.91-2-caihuoqing@baidu.com>
In-Reply-To: <20210921052821.91-2-caihuoqing@baidu.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Thu, 23 Sep 2021 19:12:20 -0300
Message-ID: <CAOMZO5CDgFHVyVAF6a5WKwsAE60t5zBBu-T+hScUO6WsmTQUvQ@mail.gmail.com>
Subject: Re: [PATCH v5 1/3] iio: imx8qxp-adc: Add driver support for NXP
 IMX8QXP ADC
To:     Cai Huoqing <caihuoqing@baidu.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-iio@vger.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Cai,

On Tue, Sep 21, 2021 at 2:29 AM Cai Huoqing <caihuoqing@baidu.com> wrote:

> +error_iio_device_register:
> +       clk_disable_unprepare(adc->ipg_clk);
> +error_adc_ipg_clk_enable:
> +       clk_disable_unprepare(adc->clk);
> +error_adc_clk_enable:
> +       regulator_disable(adc->vref);

Please rename these labels to indicate the action that will be performed.

Something like this:

error_ipg_clk_disable:
       clk_disable_unprepare(adc->ipg_clk);
error_adc_clk_disable:
       clk_disable_unprepare(adc->clk);
error_regulator_disable:
       regulator_disable(adc->vref);