Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp988755pxb; Thu, 23 Sep 2021 15:19:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHsGgZtOffD6Uc1AueEnGnSpG31x7hDhATg6NncmGJDxfaz4ioUIZngnfBNWahfw6j/A5k X-Received: by 2002:a92:c5a4:: with SMTP id r4mr5549130ilt.130.1632435545565; Thu, 23 Sep 2021 15:19:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632435545; cv=none; d=google.com; s=arc-20160816; b=NKZUnSUSb3W893t3KZUbaTLVoBd6sFMTLt9SNMVwhhVvlLTMZ6+K9xU87/7hJy3H10 Qq8lNpQ4uZwrO/nO2HYrjfG9vy/apICChexdxc16mPPSVSMoS1WVpysoY/f7rw4p37d/ vPM/0dw9EZt29MKhJA5wxYQfYpkt3bbueAXkwcoEinMiBbXz2h2eQFVuleXmh9TJd9hv UiO8XiPgceZAwdD2z7BkbEm0L0VNa7cOiGE1bmdJx3/r7b7TfwfHVP8iPmzRJg1oC/c8 JYdvhhCcGgDEDWaAxfDMt/NUIYc7dv18i6qTT7zW+0vxrYAAUm1z2mzH0QDvrawoaQXk 736A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=Yg/PmAw3snRiaGc9Gd0C/ykg77E3ZXNbEk+gRVy6iPE=; b=rAW03/Bef5BjJhUJSw32Jb+X/Pv0fLli+l9p5i3uWLYOpx6iaY3f8d2tLeVy4MYXU9 //zNvM8f4EJ4fbv/4zBas5UUiOfTxvK0GDCROFW7HYiXopJv6LL7cb4Wb8nLyioAL7NU hxhT9ffzl/++z9MGzIerlS4y6tzAtwaA6vYIfyE1MftKhLYBp18f7rrpLzG9LRt1AlCt zu3O7DbXdjqd6HJNwFdhAskKpgZsX+nJoFoHh4L8/LRizUckqlGETEKIxF+Qf/IxEmoU hrQA3cWil1h5GL5IAmyh52cRRFaDGCgN8c0/BMkTFMiUUmO1F18wk2/QQHe2Dt+FSpvc cOQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z11si7863365iom.108.2021.09.23.15.18.53; Thu, 23 Sep 2021 15:19:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243390AbhIWWRy (ORCPT + 99 others); Thu, 23 Sep 2021 18:17:54 -0400 Received: from fgw20-4.mail.saunalahti.fi ([62.142.5.107]:18053 "EHLO fgw20-4.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236039AbhIWWRx (ORCPT ); Thu, 23 Sep 2021 18:17:53 -0400 Received: from localhost.localdomain (85-76-102-236-nat.elisa-mobile.fi [85.76.102.236]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id a281e6f2-1cb9-11ec-8d6d-005056bd6ce9; Fri, 24 Sep 2021 01:00:17 +0300 (EEST) From: Aaro Koskinen To: Steve Glendinning , UNGLinuxDriver@microchip.com, "David S. Miller" , Jakub Kicinski , Andre Edich , netdev@vger.kernel.org, linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Aaro Koskinen Subject: [PATCH] smsc95xx: fix stalled rx after link change Date: Fri, 24 Sep 2021 01:00:16 +0300 Message-Id: <20210923220016.18221-1-aaro.koskinen@iki.fi> X-Mailer: git-send-email 2.17.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After commit 05b35e7eb9a1 ("smsc95xx: add phylib support"), link changes are no longer propagated to usbnet. As a result, rx URB allocation won't happen until there is a packet sent out first (this might never happen, e.g. running just ssh server with a static IP). Fix by triggering usbnet EVENT_LINK_CHANGE. Fixes: 05b35e7eb9a1 ("smsc95xx: add phylib support") Signed-off-by: Aaro Koskinen --- drivers/net/usb/smsc95xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index 7d953974eb9b..26b1bd8e845b 100644 --- a/drivers/net/usb/smsc95xx.c +++ b/drivers/net/usb/smsc95xx.c @@ -1178,7 +1178,10 @@ static void smsc95xx_unbind(struct usbnet *dev, struct usb_interface *intf) static void smsc95xx_handle_link_change(struct net_device *net) { + struct usbnet *dev = netdev_priv(net); + phy_print_status(net->phydev); + usbnet_defer_kevent(dev, EVENT_LINK_CHANGE); } static int smsc95xx_start_phy(struct usbnet *dev) -- 2.17.0