Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210825082251.2484-1-caihuoqing@baidu.com> <CAOMZO5DKGv1GQBpwr0ff0YC1yDmCH2A5Xpq7jzUA2h75bmN6eQ@mail.gmail.com>
 <20210918022636.GA18195@LAPTOP-UKSR4ENP.internal.baidu.com>
In-Reply-To: <20210918022636.GA18195@LAPTOP-UKSR4ENP.internal.baidu.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Thu, 23 Sep 2021 19:17:16 -0300
Message-ID: <CAOMZO5Aauz0Kb18xYrBc-4dX-ZAeOOGxraFbbYOz0Lz1LFZJ6A@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: freescale: Add helper dependency on COMPILE_TEST
To:     Cai Huoqing <caihuoqing@baidu.com>
Cc:     Dong Aisheng <aisheng.dong@nxp.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Stefan Agner <stefan@agner.ch>,
        Linus Walleij <linus.walleij@linaro.org>,
        GPIO SUBSYSTEM <linux-gpio@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Cai,

On Fri, Sep 17, 2021 at 11:26 PM Cai Huoqing <caihuoqing@baidu.com> wrote:

> > I am not sure why you need the && OF, as we have a "select PINCTRL_IMX",
> > that already depends on OF.
> No, it's just an invalid dependency. PINCTRL_IMX can be selected without OF

I don't understand your statement.

From drivers/pinctrl/freescale/Kconfig:

config PINCTRL_IMX
      tristate
      depends on OF

So PINCTRL_IMX depends on OF, which means that it can only be selected
when CONFIG_OF=y.