Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 1/1] mm: Fix the uninitialized use in
 overcommit_policy_handler
To:     Andrew Morton <akpm@linux-foundation.org>,
        Chen Jun <chenjun102@huawei.com>
CC:     <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        <feng.tang@intel.com>, <mhocko@suse.com>, <rui.xiang@huawei.com>
References: <20210923020524.13289-1-chenjun102@huawei.com>
 <20210923192312.53dbe65db0375038c99defaa@linux-foundation.org>
From:   Kefeng Wang <wangkefeng.wang@huawei.com>
Message-ID: <2e27177d-2db2-de2e-96ba-fe9048c82978@huawei.com>
Date:   Fri, 24 Sep 2021 10:41:29 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20210923192312.53dbe65db0375038c99defaa@linux-foundation.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 2021/9/24 10:23, Andrew Morton wrote:
> On Thu, 23 Sep 2021 02:05:24 +0000 Chen Jun <chenjun102@huawei.com> wrote:
>
>> An unexpected value of /proc/sys/vm/overcommit_memory we will get,
>> after running the following program.
>>
>> int main()
>> {
>>      int fd = open("/proc/sys/vm/overcommit_memory", O_RDWR)

Hi Andrew，

missing  ';' here,

> Thanks.  I added a cc:stable to this, so the fix will be backported
> into earlier kernels.

...  and the Fixes tag miss a ')' in the end ,  please help to add them :)

Reviewed-by: Kefeng Wang <wangkefeng.wang@huawei.com>