Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1300062pxb; Fri, 24 Sep 2021 01:05:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaXV9a2O9SpJAF/0lvUFDAPBnE9hMJfo8F6fS4qLMp9dMn3cMotgYq3msGa38wVHDnF6VS X-Received: by 2002:a17:907:20cb:: with SMTP id qq11mr9588067ejb.488.1632470754883; Fri, 24 Sep 2021 01:05:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632470754; cv=none; d=google.com; s=arc-20160816; b=0yhpZfxmerI+RK8FIDPhHp3devnLl3DNbiiShE+l/3TUILdI0ACmnA2WesGKjZQza5 t0iJZXH2eLjwy3tqxxZwV5IQqQigd5Ud1/RPv+QDpEA3ZP5jiYlYKpO2cOPr9+nv4F1T E/eK+4kaugBw+wUmZ4IwYgAakDaMWX/NmUp7I7ioUIepXM7K5ekFJmNTv9Epbwww1RCd k0p+0N2Vd9dO98HYwZO2hySXX1wLavNk543Lb1dnqn6S+T6K2eWhoOf/bfo1k/RPfSCh dnXSSBFBsQcUJcKKr565Sf446Jkr0XTfZpSUjhyi+54iSXKcsbTTHIxQWQp0RB5YOsDw KoMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=TSws/164fiyq3oktWfzcBH/e+yGW2wBhhF/5uUAH+OQ=; b=YQXGqFZR/P24WQscj3Ba4AbcrIcj8IU9vgZ3H5SwO72DoGabFlkCEIEvFl3FM+UZge gSPdzbaw6QEFMnVr6yfDj980bDIQnZNXAuk/HqVJiaSU+xHtpv91M6ItL5ADu0nAruWg vhY6VnC8AWf50s/doLQKOgrC8gzrnDg8/0ndwv0Nx2AdIyvMwO9IB2QQaICOdfvM2Z7N DhsvEapMttHT5LZ+W5HHIxFo3ZCDSVgHyY1tJ2Y+dCrs6WHtmo/lH+xsyK547Ip4A2iJ nYDBk4HdvGSDP4JnhSNsSq/C2HQ23O83o2exCmj7r9i/sQyGNcFXFNgyfwAFCf2Qu8qB iZ1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=ohpMaCMT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s2si7998149edy.454.2021.09.24.01.05.22; Fri, 24 Sep 2021 01:05:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=ohpMaCMT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244522AbhIXIBn (ORCPT + 99 others); Fri, 24 Sep 2021 04:01:43 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:51171 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244482AbhIXIBl (ORCPT ); Fri, 24 Sep 2021 04:01:41 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632470408; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=TSws/164fiyq3oktWfzcBH/e+yGW2wBhhF/5uUAH+OQ=; b=ohpMaCMT9xB+3PGmbW5nwPG3NB3jnJY57Mpy9E1+1KBCZqafbc8YYANc4MDhE5/r2EFXPjiQ 4Mas7Wf/MzK8tf8anw9An8oqGond+M3Aj1Dj09Dwj/5U5zxTvqwRmymIa1Lv9ezES2PDZ6G8 pRsGDOo185miwLA2iFGIjLyH1EY= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 614d857b648642cc1c339f70 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 24 Sep 2021 07:59:55 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id AC15DC43617; Fri, 24 Sep 2021 07:59:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id B3E77C4338F; Fri, 24 Sep 2021 07:59:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org B3E77C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Stephen Boyd Cc: pillair@codeaurora.org, ath10k@lists.infradead.org, govinds@codeaurora.org, kuabhs@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, youghand@codeaurora.org Subject: Re: [PATCH] ath10k: Don't always treat modem stop events as crashes References: <002501d7af73$ae0a7620$0a1f6260$@codeaurora.org> Date: Fri, 24 Sep 2021 10:59:47 +0300 In-Reply-To: (Stephen Boyd's message of "Wed, 22 Sep 2021 15:20:07 -0700") Message-ID: <87bl4itnd8.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stephen Boyd writes: > Quoting pillair@codeaurora.org (2021-09-21 22:35:34) >> On 9/5/21 4:04 PM, Stephen Boyd wrote: >> >> > +static int ath10k_snoc_modem_notify(struct notifier_block *nb, unsigned long > [...] >> >> > + >> >> > + return NOTIFY_OK; >> >> > +} >> >> >> >> Thanks for posting the patch. It would be preferable to use a different flag >> instead of ATH10K_SNOC_FLAG_UNREGISTERING, >> >> since we are not unloading the ath10k driver. Weird, I don't see pillair's email on patchwork[1] and not in the ath10k list either. Was it sent as HTML or something? [1] https://patchwork.kernel.org/project/linux-wireless/patch/20210905210400.1157870-1-swboyd@chromium.org/ -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches