Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1312268pxb; Fri, 24 Sep 2021 01:28:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLz3Y6ajSrO4Uu5uoax6KiEZwmfvhJWE1oezANZhgsEwoDGiV1KXz1DWedhj9Hd9CZmH9I X-Received: by 2002:a92:d84f:: with SMTP id h15mr6971062ilq.42.1632472139109; Fri, 24 Sep 2021 01:28:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632472139; cv=none; d=google.com; s=arc-20160816; b=MQteagINRBLInY3hGeGr1b/TBWAphq/BSk6ImG7c8m7+m863Yse3M764x5AQHDcIu3 n9nOuzfFBA6K/P3EPnItX4sEYk7SohlkceGyP7fXh5faZ4TmgTsYHho5PFS+EgB3Zf54 WzW9PaFcPwVkfwVqeLiGGMqZceeg2QaD5slYk8ICC7lT/vVyHy2Sr08WXXgDFHIUMdFo 905UulkZN4OaO0w0Rw5fxoJ8hxLd5pPgm4qfhEgjkc7LKgA3M5R28/5SPSJDKWqMi6Wf Klg2j/8koeFAv+/Ja0akdf9eJ52JntPYlWEhrEzUAfUWst4cKmG9rKWBqfjt4EPbTwGs J8DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bRlGREeuAoK+lh4KtlKZ9ZDT4cemhOq8FBacRlioAUI=; b=tTp6mOApU/cW1+cN5tXVrhZC4V91xa8f8iQX/BsZfTYjKI8YKMk9D2Su3fIpViCE8Q yKlmPVnrCKUf+syPmDAdLbKDQgoIJEkoKfQlHwBwX4rwRyXdDOJgA4gAMjbnA8JgkYnw 74Ct+w42pXOwXDzyVGDUOnFeZBU9KeceI5I7MlzeuiX6ywItCaAiLm095DXx3L0D8+Bv hIqIq0XsWJ/Zd4lkTws8jlDgWtRT73NzY1fvrPH5bTRjDAIeBSqlXZJetiqT00n1rLGf E+9fBeiro4qnuUGYSfIL68UUIsosIV+VxxHOmqVpEDEonkyygNPldo+BC5UU3kOGQUIV J+NQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=GUDvEX9c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n15si7339875ilk.96.2021.09.24.01.28.48; Fri, 24 Sep 2021 01:28:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=GUDvEX9c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244735AbhIXI2V (ORCPT + 99 others); Fri, 24 Sep 2021 04:28:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244655AbhIXI2U (ORCPT ); Fri, 24 Sep 2021 04:28:20 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C708FC061574; Fri, 24 Sep 2021 01:26:47 -0700 (PDT) Received: from zn.tnic (p200300ec2f0dd600c2485b7778a62ff5.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:d600:c248:5b77:78a6:2ff5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 66E4D1EC0419; Fri, 24 Sep 2021 10:26:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1632472002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=bRlGREeuAoK+lh4KtlKZ9ZDT4cemhOq8FBacRlioAUI=; b=GUDvEX9cS6n1r1QzFO8dhq/ojrTmnJTTPEoWo1eFkmMfp0ja9z0Bj5GxycjaO4ENxNlxFw AeIV1VQ5yJsoxb/saiyVv129jBVz6xxbsLc6twG56agsBXq8HXXmJTyO8SG1y5e0H9QUzm HT6o1s9H1Lv8o8GW0XOt3dG/+2+FelQ= Date: Fri, 24 Sep 2021 10:26:40 +0200 From: Borislav Petkov To: Smita Koralahalli Cc: x86@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Luck , "H . Peter Anvin" , yazen.ghannam@amd.com Subject: Re: [PATCH 3/5] x86/mce: Use msr_ops in prepare_msrs() Message-ID: References: <20210915232739.6367-1-Smita.KoralahalliChannabasappa@amd.com> <20210915232739.6367-4-Smita.KoralahalliChannabasappa@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210915232739.6367-4-Smita.KoralahalliChannabasappa@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 15, 2021 at 06:27:37PM -0500, Smita Koralahalli wrote: > Replace MCx_{STATUS, ADDR, MISC} macros with msr_ops. > > Also, restructure the code to avoid multiple initializations for MCA > registers. SMCA machines define a different set of MSRs for MCA registers > and msr_ops initializes appropriate MSRs for SMCA and legacy processors. > > Initialize MCA_MISC and MCA_SYND registers at the end after initializing > MCx_{STATUS, DESTAT} which is further explained in the next patch. > > Make msr_ops exportable in order to be accessible from mce-inject module. > > Signed-off-by: Smita Koralahalli > --- > arch/x86/kernel/cpu/mce/core.c | 1 + > arch/x86/kernel/cpu/mce/inject.c | 27 +++++++++++++-------------- > 2 files changed, 14 insertions(+), 14 deletions(-) https://git.kernel.org/tip/8121b8f947be0033f567619be204639a50cad298 -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette