Date: Fri, 15 Dec 2006 12:26:59 -0800
From: Randy Dunlap <randy.dunlap@oracle.com>
To: =?ISO-8859-1?Q?J=F6rn?= Engel <joern@lazybastard.org>
Cc: Pavel Machek <pavel@ucw.cz>, Scott Preece <sepreece@gmail.com>,
       kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH/v2] CodingStyle updates
Message-Id: <20061215122659.ebccdede.randy.dunlap@oracle.com>
In-Reply-To: <20061215201127.GA32210@lazybastard.org>
References: <20061207165508.e6bf0269.randy.dunlap@oracle.com>
	<20061215120942.GA4551@ucw.cz>
	<4582AEC8.7030608@s5r6.in-berlin.de>
	<20061215142206.GC2053@elf.ucw.cz>
	<7b69d1470612150652p609c38d2n9bff58bdb0a1edb7@mail.gmail.com>
	<20061215150717.GA2345@elf.ucw.cz>
	<20061215090037.05c021af.randy.dunlap@oracle.com>
	<20061215201127.GA32210@lazybastard.org>
Organization: Oracle Linux Eng.
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1267
Lines: 41

On Fri, 15 Dec 2006 20:11:27 +0000 J?rn Engel wrote:

> On Fri, 15 December 2006 09:00:37 -0800, Randy Dunlap wrote:
> > On Fri, 15 Dec 2006 16:07:17 +0100 Pavel Machek wrote:
> > 
> > > Not in simple cases.
> > > 
> > > 	3*i + 2*j should be writen like that. Not like
> > > 	(3 * i) + (2 * j)
> > 
> > I would just write it as:
> > 	3 * i + 2 * j
> 
> So would I.  But I definitely wouldn't write
> 	for (i = 0; i < 10; i += 2)

I would and do (the above).

> because I prefer the grouping in
> 	for (i=0; i<10; i+=2)
> 
> Pavel may have picked a bad example, but there are cases when spaces can
> be used to group code.  Just as empty lines can be used to group code.
> And in both cases the reason should be "readability".

Agreed.

> Which variant is the most readable is a highly personal matter and may
> alos change over time for any group of people.  I'd vote against a stone
> tablet with 10 commandments of taste.  "Make it readable, use common
> sense" is so much better, imo.

then send patches  :)

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/