Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964852AbWLOUw2 (ORCPT ); Fri, 15 Dec 2006 15:52:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964850AbWLOUw2 (ORCPT ); Fri, 15 Dec 2006 15:52:28 -0500 Received: from nic.NetDirect.CA ([216.16.235.2]:43717 "EHLO rubicon.netdirect.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964852AbWLOUw1 (ORCPT ); Fri, 15 Dec 2006 15:52:27 -0500 X-Originating-Ip: 24.148.236.183 Date: Fri, 15 Dec 2006 15:48:09 -0500 (EST) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Jan Engelhardt cc: Stefan Richter , Zach Brown , Linux kernel mailing list Subject: Re: lots of code could be simplified by using ARRAY_SIZE() In-Reply-To: Message-ID: References: <2F8F687E-C5E5-4F7D-9585-97DA97AE1376@oracle.com> <4581DAB0.2060505@s5r6.in-berlin.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Net-Direct-Inc-MailScanner-Information: Please contact the ISP for more information X-Net-Direct-Inc-MailScanner: Found to be clean X-Net-Direct-Inc-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.754, required 5, ALL_TRUSTED -1.80, BAYES_00 -15.00, RCVD_IN_SORBS_DUL 2.05) X-Net-Direct-Inc-MailScanner-From: rpjday@mindspring.com Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 881 Lines: 30 On Fri, 15 Dec 2006, Jan Engelhardt wrote: > > >>> Indeed, there seems to be lots of potential clean-up there. > >>> Including duplicate macros like: > >>> > >>> ./drivers/ide/ide-cd.h:#define ARY_LEN(a) ((sizeof(a) / sizeof(a[0]))) > >> > >> not surprisingly, i have a script "arraysize.sh": > >... > > > >This could also come in the flavor "sizeof(a) / sizeof(*a)". > >I haven't checked if there are actual instances. > > Even sizeof a / sizeof *a > > may happen. yes, sadly, there are a number of those as well. back to the drawing board. rday p.s. you know, once i nail this script, somebody better apply the end result. :-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/