Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1 2/4] mfd: arizona: Add missing entries SPI to device ID
 table
To:     Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>
CC:     <linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>
References: <20210923194645.53046-1-broonie@kernel.org>
 <20210923194645.53046-3-broonie@kernel.org>
From:   Richard Fitzgerald <rf@opensource.cirrus.com>
Message-ID: <538c0c79-d568-be03-e524-01f5c6429554@opensource.cirrus.com>
Date:   Fri, 24 Sep 2021 10:24:17 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20210923194645.53046-3-broonie@kernel.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23/09/2021 20:46, Mark Brown wrote:
> Currently autoloading for SPI devices does not use the DT ID table, it uses
> SPI modalises. Supporting OF modalises is going to be difficult if not
> impractical, an attempt was made but has been reverted, so ensure that
> module autoloading works for this driver by adding SPI IDs for parts that
> only have a compatible listed.
> 
> Fixes: 96c8395e2166 ("spi: Revert modalias changes")
> Signed-off-by: Mark Brown <broonie@kernel.org>
> Cc: patches@opensource.cirrus.com
> ---
>   drivers/mfd/arizona-spi.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/arizona-spi.c b/drivers/mfd/arizona-spi.c
> index aa1d6f94ae53..8b44af297b7c 100644
> --- a/drivers/mfd/arizona-spi.c
> +++ b/drivers/mfd/arizona-spi.c
> @@ -216,9 +216,12 @@ static int arizona_spi_remove(struct spi_device *spi)
>   }
>   
>   static const struct spi_device_id arizona_spi_ids[] = {
> +	{ "wm1814", WM1814 },
>   	{ "wm5102", WM5102 },
>   	{ "wm5110", WM5110 },
>   	{ "wm8280", WM8280 },
> +	{ "wm8997", WM8997 },
> +	{ "wm8998", WM8998 },

WM1814, WM8997 and WM8998 do not have a SPI interface, which is why they
aren't in the table of SPI IDs.