Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1530307pxb; Fri, 24 Sep 2021 06:37:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJye/eiL33fWzANChna3ti4Gn4E++rOfDMenjd3IW/1GFC9UjsbZ/s5Wy/w0BzEnec9w9yHS X-Received: by 2002:a17:906:a08a:: with SMTP id q10mr11220666ejy.100.1632490644833; Fri, 24 Sep 2021 06:37:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632490644; cv=none; d=google.com; s=arc-20160816; b=j+jWiRCLXGkau34imEbNFmMMM6DHhKq4iAJNeRF/ogPVVydt54nhO614NNXrVxXhCe /UjaQVbPr84s54M4jyPRFYbtMCyu+Ikxg/6Bdu/b7FzxuHuGAh/259CeNkPNpUJt+tdv 2M4Vmkf/3+oZ6S7ED015W6o63teQmL5MSDq+BhVJABQfqcum+Ob4uKLeKqLmg3FrsJjK crf7TCxJ+DCHtwDM4gVkRO836/cFOlDfm1lm+tUAW+7Dr7hSrL4ASRsthU/wkvepOjFZ GEws2zbWBAIdy11tZ3ewlg8E4us40c9TyWiKVwMjeueFPEIeHmlnxpnaFSFQxSPoMnQ6 +cEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=f7PJQ49f2XQNsVpC/1cTituVVFDqoofyOlji1lyJ65Y=; b=b9a1MDSR+8XjKLZ+H5C5ZIJ4yEotqO4TmK0CGtnrHpnYO+IbdXLHXwyuqEWsQ5hg1d NJTFK1sS4Qmdu2dlKTkqX1ygMDi9/gFtZpUDRQJweMIX9JlDw+1wd24slz+txwiGZ9tf 2OQ3n+P/7Ixve2fEVTsL6otJMbvWqLvR/jTUC2VDPVcp9oshEPXbdRn+Re2KvJfDcBwp JaJjX40OzdwaZDcUS19HL57+nt2uqykg2E5V6V6DoFRn+f5w5vtG+/pRCHLMwiFNGgu4 1mjrIa0Ix1AYDHPjT0DXwvkSjh6Oq3fumnji/OcRZJylXU+WkU5i+HZVuHx2i6DuxD5/ +41Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=MPJHXJSK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j21si9436328edq.15.2021.09.24.06.37.00; Fri, 24 Sep 2021 06:37:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=MPJHXJSK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346602AbhIXNgc (ORCPT + 99 others); Fri, 24 Sep 2021 09:36:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345857AbhIXNg1 (ORCPT ); Fri, 24 Sep 2021 09:36:27 -0400 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F76FC06129D for ; Fri, 24 Sep 2021 06:33:23 -0700 (PDT) Received: by mail-qt1-x82f.google.com with SMTP id x9so9470761qtv.0 for ; Fri, 24 Sep 2021 06:33:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=f7PJQ49f2XQNsVpC/1cTituVVFDqoofyOlji1lyJ65Y=; b=MPJHXJSK62fiV7bY72s9psPD0qwrmH4+DSCY4SIpcq1V/qq7c2BkdfsmcaxbnZE5i3 /DvF7FLnGlJFR6hfvLptQEy4IBMwpL963K/d7znelDInDKeXM0ZsyLxMQZHM7JZs5Ip0 QynG3Y2Jovo34yHzcQ+gjUZ5rgopklx4kDUOC5yH5h4IbzUe6HYE4oTChIK1TS04Y5NT 05EQCx9I1GD+unY3XX8rWaoIWbDoqEkxUd6D+SCxH47Tkt5pmURs2/PItpfgV9dwkNrl HYwRyR7RVlx5RtzLQAja7xmQJ5bm/9tbwJEXxjUi5kS/Fr4IkllyvWCWlP3oDNzBjA/6 0qnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=f7PJQ49f2XQNsVpC/1cTituVVFDqoofyOlji1lyJ65Y=; b=eAhS7h+dlBVfXMh5FTBQdZ5edrp5NGpfKsk2rR5SQBJ9VhamBNkWTMKBiya3x7kEcf o2yojAEBzNgp5rFVgMZrcfoRIrDqQvmYeIAt8GY7+T+TI4tbB0GkkFkUvm7GhDf5rlSh aR8Z4sjZfgtKcWIBO0Ll12ZB99AhueQKB/UEcL6AqwXQlzdaj0BCFJiCne7jUbQgWUIp O1GXHEOF7joL2QfEhFlBFgrqHSuLxWhxn2PkDfGKJurgliMnzDQ43/zZGQ795wWS+WhV PT2uOz7Sc2C1uDHJuAW3IHZyub0HZLpgorAfnJ7FrxCcvluloUUJqJzX5cQnW+yPJVDH rdJQ== X-Gm-Message-State: AOAM530BJSeo0YPzI3T4mxdvcgfD5kah741mPVrHeQsz+JkM3ar5DYiM dFvI9oabyyO5s1c6lYtvrp8M3w== X-Received: by 2002:ac8:687:: with SMTP id f7mr4255449qth.165.1632490402674; Fri, 24 Sep 2021 06:33:22 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id d11sm862534qtb.39.2021.09.24.06.33.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 06:33:21 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1mTlKL-005A7W-6H; Fri, 24 Sep 2021 10:33:21 -0300 Date: Fri, 24 Sep 2021 10:33:21 -0300 From: Jason Gunthorpe To: Lino Sanfilippo Cc: Jarkko Sakkinen , peterhuewe@gmx.de, p.rosenberger@kunbus.com, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] tpm: fix potential NULL pointer access in tpm_del_char_device() Message-ID: <20210924133321.GX3544071@ziepe.ca> References: <20210910180451.19314-1-LinoSanfilippo@gmx.de> <204a438b6db54060d03689389d6663b0d4ca815d.camel@kernel.org> <50bd6224-0f01-ca50-af0e-f79b933e7998@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50bd6224-0f01-ca50-af0e-f79b933e7998@gmx.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 24, 2021 at 03:29:46PM +0200, Lino Sanfilippo wrote: > So this bug is triggered when the bcm2835 drivers shutdown() function is called since this > driver does something quite unusual: it unregisters the spi controller in its shutdown() > handler. This seems wrong Jason