Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210924033547.939554938@goodmis.org> <20210924000717.310b492a@rorschach.local.home>
 <CACGkJdtsHWBstw_Gzb-Dq4Xs_eAW1jsARr5wbh0yE_=NsPA5bw@mail.gmail.com>
 <20210924091627.645a8fd3@gandalf.local.home> <20210924223549.c41a89befe11534dfd56f01c@kernel.org>
In-Reply-To: <20210924223549.c41a89befe11534dfd56f01c@kernel.org>
From:   Eugene Syromyatnikov <evgsyr@gmail.com>
Date:   Fri, 24 Sep 2021 16:18:10 +0200
Message-ID: <CACGkJdspTL=tnDOSvY3ub235rr+6eUBU1uBhHFZbqBkegcRvnw@mail.gmail.com>
Subject: Re: [PATCH 0/2] tracing: Have trace_pid_list be a sparse array
To:     Masami Hiramatsu <mhiramat@kernel.org>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        linux-trace-devel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Sep 24, 2021 at 3:35 PM Masami Hiramatsu <mhiramat@kernel.org> wrot=
e:
>
> On Fri, 24 Sep 2021 09:16:27 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> > I'm optimizing the top tiers for size, because they are likely to be em=
pty.
> > Why add memory for something that will never be used, and can't be remo=
ved.
> > Note, the middle and lower tiers can be reused when they go empty, whic=
h is
> > a likely use case (at least when I test this using hackbench).

Makes sense;  I was thinking about worse case scenarios=E2=80=94tracing
thousands+ processes, but those probably not as common and important.

> > I looked into xarray and it appears to be optimized for storing somethi=
ng,
> > where as I'm just interested in a sparse bitmask.
>
> I guess he suggested that store the bitmask in xarray. Anyway, both are
> OK to me. This is needed for reducing the memory.

Yes, the idea was to store pointers to bitset leaves in XArray and
leverage its radix tree implementation, at cost of somewhat lesser
efficiency (since XArray indices are longs and thus it employs more
intermediate levels on 64-bit architectures).

--=20
Eugene Syromyatnikov
mailto:evgsyr@gmail.com
xmpp:esyr@jabber.{ru|org}