Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Marciniszyn, Mike" <mike.marciniszyn@cornelisnetworks.com>
To:     Guo Zhi <qtxuning1999@sjtu.edu.cn>,
        "Dalessandro, Dennis" <dennis.dalessandro@cornelisnetworks.com>,
        "dledford@redhat.com" <dledford@redhat.com>
CC:     "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c
Thread-Topic: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c
Thread-Index: AQHXr64eLoiKpRDRD0iedvDFbFrfHauzRfXQ
Date:   Fri, 24 Sep 2021 14:46:09 +0000
Message-ID: <CH0PR01MB71538BE2332867B20A4A77BEF2A49@CH0PR01MB7153.prod.exchangelabs.com>
References: <20210922123341.601450-1-qtxuning1999@sjtu.edu.cn>
In-Reply-To: <20210922123341.601450-1-qtxuning1999@sjtu.edu.cn>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9nAxP51Af1AThMaJKPspA4LxvN9G7Ol6FeVTuULr8uk782xcVy8Q6wgKFixi?=
 =?us-ascii?Q?MVqGU78encaifz1xMBVcrU4JsDZ8T1RoJWjGryiVzm3+PmbXhyib5Cie5rzU?=
 =?us-ascii?Q?dMpCrctAAJDvAKwDtCum8JqyB4yEX0/TFuRrVBfd8fJJpRpWo3H+W8dMaD8+?=
 =?us-ascii?Q?lmxd0nKnO+hD1mDOxyaepRn1V/2Eycp80aahLd/m52MaI3v0lD9riFVB5tJh?=
 =?us-ascii?Q?JYxWYXC+voGevtUYXrKgkNSG8RznDlY42DeqRP50Z1HBj8lyS515Nl1fAOBF?=
 =?us-ascii?Q?Ezta/jXJLyBGcrJciX2vNsu8xhS2L1f1HNaYA1u0nt5skwkLG4jJuAfFJt33?=
 =?us-ascii?Q?R3eRD/zPuiN9eEMzG41RdahF0r+17es+gG74EUmvN4j7gsyFJ0uQFUiYd06X?=
 =?us-ascii?Q?K8v9KA30+qIA2KwoDYAIVPmMydCa+U5RmqUcUitExLadvDwpAxCwQVSI1SpV?=
 =?us-ascii?Q?x+ps0fm8MzWd/g3vsV9ypOuuYuBaUcFny9O4Ri8UXCk/amkMS1+/UgAJ6wS6?=
 =?us-ascii?Q?SjWohtqqA7/KwWETi3UxkWzhBxO/dHMvXqSdRqvZgaXpXWAIYRXIcPqje9Vc?=
 =?us-ascii?Q?z3HGPKxRFTONMXgQTgAUBHQvclemMCbeMYugcAG+9JBbfiiJvRauvFJvbEkP?=
 =?us-ascii?Q?uqPdK2D8PWsmbRCjdZ0gmrpWEHyRhjW9pyJXQODkK2EDlB7q7VNjOLeLDzIZ?=
 =?us-ascii?Q?6LZg0fUNbagAI+fmzY3THlKmwQAXwpnRaPn/hrCbfKj9Sf+gboBmNdqbEnMs?=
 =?us-ascii?Q?aPCkxXD6REC1hc+X+k29l/vFedUawM050yyazcN+nie/nQJiO4E7LV+SFgm6?=
 =?us-ascii?Q?LY0ekRY9yvq9a+HMtn4njLFPeVEhcIEIc5ukOSyejfgpKG4//sKHFyoniJ3z?=
 =?us-ascii?Q?Tb4Zjw3XpCioAC/jvM+sIOyA/ZMriyzBmbQcpqqmrPiwFvcm/buXKAtOkKL6?=
 =?us-ascii?Q?6J4bcBdPwGIDVouW9sGCloysgernJyCnMX+e2reJgsbNHx4nRUXXZkYuXvri?=
 =?us-ascii?Q?87Fx8v31wawlkKxtTWybn33E/jx8uoYCTamIGSjsaFygEIkMTYVjACZVYIeF?=
 =?us-ascii?Q?navBkin3jz7aXeBiA8AVDnNsQ/YJOzwozKuhvDDV93jfMc8EiCT1h3DPmDbT?=
 =?us-ascii?Q?/WYA14UiwST5Cj0M1mEyD/oWZyDFG4ISVF+6iOdu9nNxM4jeP/ZdBCbswZAE?=
 =?us-ascii?Q?lpq/bKfg9uOEIPqKT7L7zVgPhfBzhpdVLpGFEaF0tq8aHbACywt0EtRc7ziW?=
 =?us-ascii?Q?BKkWFdGhL6R6hCfz9XYMRCM1e+f5Uaox/mi4autN9CoYVxEmkkgpxGB0BQYT?=
 =?us-ascii?Q?P1s=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: cornelisnetworks.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR01MB7153.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7108bd5-a5c2-40b0-f55a-08d97f6a0c20
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2021 14:46:09.5756
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4dbdb7da-74ee-4b45-8747-ef5ce5ebe68a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EDSc8Msk8sXxkKVw1IVdCjexuIrfz8uymQWRkk1pG0s2C2qf3Am1VIbV81xJHJ7kSb7jjIVWSuXC2RPcty1MIIY4FTJklbfkmFdnN7J4kaimWkNy/Jn+VgPOYeC1kvOm
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR01MB5893
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c
>=20
> Pointers should be printed with %p or %px rather than cast to (unsigned l=
ong
> long) and printed with %llx.
> Change %llx to %p to print the pointer.
>=20
> Signed-off-by: Guo Zhi <qtxuning1999@sjtu.edu.cn>
> ---
>  drivers/infiniband/hw/hfi1/ipoib_tx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/infiniband/hw/hfi1/ipoib_tx.c
> b/drivers/infiniband/hw/hfi1/ipoib_tx.c
> index e74ddbe4658..7381f352311 100644
> --- a/drivers/infiniband/hw/hfi1/ipoib_tx.c
> +++ b/drivers/infiniband/hw/hfi1/ipoib_tx.c
> @@ -876,13 +876,13 @@ void hfi1_ipoib_tx_timeout(struct net_device
> *dev, unsigned int q)
>  	struct hfi1_ipoib_txq *txq =3D &priv->txqs[q];
>  	u64 completed =3D atomic64_read(&txq->complete_txreqs);
>=20
> -	dd_dev_info(priv->dd, "timeout txq %llx q %u stopped %u stops %d
> no_desc %d ring_full %d\n",
> +	dd_dev_info(priv->dd, "timeout txq %p q %u stopped %u stops %d
> no_desc
> +%d ring_full %d\n",
>  		    (unsigned long long)txq, q,
>  		    __netif_subqueue_stopped(dev, txq->q_idx),
>  		    atomic_read(&txq->stops),
>  		    atomic_read(&txq->no_desc),
>  		    atomic_read(&txq->ring_full));
> -	dd_dev_info(priv->dd, "sde %llx engine %u\n",
> +	dd_dev_info(priv->dd, "sde %p engine %u\n",
>  		    (unsigned long long)txq->sde,

Gho,

As Denny mentioned, I'm assuming that the case is no longer required?

Submit a v2 with that change and I will Ack.

Mike