Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 24 Sep 2021 12:20:01 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Richard Fitzgerald <rf@opensource.cirrus.com>
Cc:     Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org,
        patches@opensource.cirrus.com
Subject: Re: [PATCH v1 2/4] mfd: arizona: Add missing entries SPI to device
 ID table
Message-ID: <20210924112000.GB4840@sirena.org.uk>
References: <20210923194645.53046-1-broonie@kernel.org>
 <20210923194645.53046-3-broonie@kernel.org>
 <538c0c79-d568-be03-e524-01f5c6429554@opensource.cirrus.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="aVD9QWMuhilNxW9f"
Content-Disposition: inline
In-Reply-To: <538c0c79-d568-be03-e524-01f5c6429554@opensource.cirrus.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--aVD9QWMuhilNxW9f
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Sep 24, 2021 at 10:24:17AM +0100, Richard Fitzgerald wrote:
> On 23/09/2021 20:46, Mark Brown wrote:

> > Currently autoloading for SPI devices does not use the DT ID table, it uses
> > SPI modalises. Supporting OF modalises is going to be difficult if not
> > impractical, an attempt was made but has been reverted, so ensure that
> > module autoloading works for this driver by adding SPI IDs for parts that
> > only have a compatible listed.

> >   static const struct spi_device_id arizona_spi_ids[] = {
> > +	{ "wm1814", WM1814 },
> >   	{ "wm5102", WM5102 },
> >   	{ "wm5110", WM5110 },
> >   	{ "wm8280", WM8280 },
> > +	{ "wm8997", WM8997 },
> > +	{ "wm8998", WM8998 },

> WM1814, WM8997 and WM8998 do not have a SPI interface, which is why they
> aren't in the table of SPI IDs.

They're listed as valid DT compatibles for SPI so will now generate
warnings on boot, the driver should not list those compatibles if
they're not valid.

--aVD9QWMuhilNxW9f
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFNtGAACgkQJNaLcl1U
h9D2WQf/eTTq2Hocs/KfMqObp+AeluMMwH+MICNpX08gwVxATkmWLlvKc94QFsHM
13sUYgtR6z79/iBRnkUni/UAwly7+GbEX6oxkL6icY06XB/wxXH/k2lDWODrS3tm
ga9s7OTXzarzcq+UTH4UH1EOrgXk+UNKQj0TnrFL1pal8ncVBfdtHX4eZajIa0SS
+dOHE+2BdORdbakvhAxmK7LR5AEu9HrTMJHKKI+QqBMnJCrYlBx0IesM9k+PR/q7
AREOCim9TZCm8THMQHaP8WbuxBVuWTHwnfdll0N6yuctwrlBA9P75yA2qKF93tT/
1mThFAGQcdSYPFQmhVaOlNDfQmtKbA==
=tPuv
-----END PGP SIGNATURE-----

--aVD9QWMuhilNxW9f--