Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 24 Sep 2021 23:09:10 +0200
From:   Tommaso Merciai <tomm.merciai@gmail.com>
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc:     Forest Bond <forest@alittletooquiet.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Lucas Henneman <lucas.henneman@linaro.org>,
        Madhumitha Prabakaran <madhumithabiw@gmail.com>,
        Yujia Qiao <rapiz@foxmail.com>,
        Marcos Antonio de Jesus Filho <mdejesusfilho@gmail.com>,
        Edmundo Carmona Antoranz <eantoranz@gmail.com>,
        Aldas =?utf-8?B?VGFyYcWha2V2acSNaXVz?= <aldas60@gmail.com>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Deepak R Varma <mh12gx2825@gmail.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6655: Replace camel case variable name
Message-ID: <20210924210910.GA10906@tom-desktop>
References: <20210922225138.668520-1-tomm.merciai@gmail.com>
 <6695e45f-4530-ab39-923d-8347649762bb@embeddedor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6695e45f-4530-ab39-923d-8347649762bb@embeddedor.com>
Precedence: bulk

On Wed, Sep 22, 2021 at 06:12:37PM -0500, Gustavo A. R. Silva wrote:
> 
> 
> On 9/22/21 17:51, Tommaso Merciai wrote:
> > Work in progress: replace camel case variables
> > 
> > PortOffset -> port_offset
> > 
> > Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
> > ---
> 
> When someone gives you feedback and you have to respin your
> patch, you should version the patches that you resend, and
> mention what changed, here:
> 
> Changes in v2:
>  - Variable should be port_offset instead of port_off_set.
  
  Thanks, you're right. Resend V2.

  Tommaso

> 
> I encourage you to take a look at this:
> 
> https://kernelnewbies.org/Outreachyfirstpatch
> 
> It will be of great help if you are trying to land
> your first patches. :)
> 
> --
> Gustavo