Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <6421f256407262afd658ffa74ec9430581528a7d.1632467477.git.geert+renesas@glider.be>
 <20210924141232.4419-1-johan@kernel.org>
In-Reply-To: <20210924141232.4419-1-johan@kernel.org>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Fri, 24 Sep 2021 17:14:38 +0200
Message-ID: <CAMuHMdUKtitgin5zwya=1q1HEwJx6Fy_H8C5jGbDBgagSfwdKQ@mail.gmail.com>
Subject: Re: [PATCH] serial: 8250: allow disabling of Freescale 16550 compile test
To:     Johan Hovold <johan@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Sep 24, 2021 at 4:13 PM Johan Hovold <johan@kernel.org> wrote:
> The SERIAL_8250_FSL option is used to enable a workaround for a
> break-detection erratum for Freescale 16550 UARTs in the 8250 driver and
> is currently also used to enable support for ACPI enumeration.
>
> It is enabled on PPC, ARM and ARM64 whenever 8250 console support is
> enabled (since the quirk is needed for sysrq handling).
>
> Commit b1442c55ce89 ("serial: 8250: extend compile-test coverage")
> enabled compile testing of the code in question but did not provide a
> means to disable the option when COMPILE_TEST is enabled.
>
> Add a conditional input prompt instead so that SERIAL_8250_FSL is no
> longer enabled by default when compile testing while continuing to
> always enable the quirk for platforms that may need it.
>
> Fixes: b1442c55ce89 ("serial: 8250: extend compile-test coverage")
> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Johan Hovold <johan@kernel.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds