Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   ebiederm@xmission.com (Eric W. Biederman)
To:     Manfred Spraul <manfred@colorfullife.com>
Cc:     Alexander Mihalicyn <alexander@mihalicyn.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Milton Miller <miltonm@bga.com>,
        Jack Miller <millerjo@us.ibm.com>,
        Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@suse.com>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        Andrei Vagin <avagin@gmail.com>,
        Christian Brauner <christian@brauner.io>
References: <20210706132259.71740-1-alexander.mikhalitsyn@virtuozzo.com>
        <20210709181241.cca57cf83c52964b2cd0dcf0@linux-foundation.org>
        <CAJqdLrpx+xEMGQLZo7jS5BTAw-k2sWPrv9fCt0x8t=6Nbn7u+w@mail.gmail.com>
        <CALgW_8VUk0us_umLncUv2DUMkOi3qixmT+YkHV4Dhpt_nNMZHw@mail.gmail.com>
        <CAJqdLrofd76x_hziq7F3wY3jqZfE1LNZbQ8sD6MUFXbPHVcdVw@mail.gmail.com>
        <CALgW_8WHq051ifcYPta5reoVZ10=fA5Rb1EZuyaievK+OUw99Q@mail.gmail.com>
        <CAJqdLrpxnMThqersqiVsTNr1Y25V8jmDcW_sKWi0ziJXCsi2gw@mail.gmail.com>
        <87y2ab9w8u.fsf@disp2133>
        <00ce7bff-e432-8244-1765-12460817baab@colorfullife.com>
Date:   Fri, 24 Sep 2021 11:45:07 -0500
In-Reply-To: <00ce7bff-e432-8244-1765-12460817baab@colorfullife.com> (Manfred
        Spraul's message of "Thu, 23 Sep 2021 18:36:16 +0200")
Message-ID: <87pmsxorcc.fsf@disp2133>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [PATCH 0/2] shm: omit forced shm destroy if task IPC namespace was changed
Precedence: bulk

Manfred Spraul <manfred@colorfullife.com> writes:

> Hi Eric,
>
> I'd like to restart the discussion, the issue should be fixed.

Agreed.

I am going to come right out and say having read through everything
my suggests were confused and wrong.

Somehow I thought the cleanups I was suggesting world result in
shm_clist only being modified from the task that owns the list.
Which would result in no need to use a per-task list.

Having looked through my suggestions again I was completely wrong.

The only useful bit I have to contribute from that original suggestion
is let's please have smallish patches that change one thing at a time.

That code is sufficiently interesting that it is way too easy to get
lost in big patches.


I am not going to discuss my broken suggestions right now because every
time I look into them I go into a rabbit hole and I don't get anything
productive done on fixing these issues, just something close and
frustrating.  Apologies if I derailed your patch.

Eric