Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 24 Sep 2021 20:04:49 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     Tony Luck <tony.luck@intel.com>, X86 ML <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] x86/mce: Get rid of the ->quirk_no_way_out()
 indirect call
Message-ID: <YU4vYSKnfdxzJFgZ@yaz-ubuntu>
References: <20210917105355.2368-1-bp@alien8.de>
 <20210917105355.2368-5-bp@alien8.de>
 <YUyUhfTfY/3KtDTZ@yaz-ubuntu>
 <YUyZDAGloQB/M4ts@zn.tnic>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YUyZDAGloQB/M4ts@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FE75Fsfh72Tj4kUPvcACXvj73S6KkBvNahPX83BU+MiIDA1ph7vHj6bxSd/J?=
 =?us-ascii?Q?gbVTugP0vJ/JVM6XT9lLstCYm+Vi8e0eXHn5ZhT9/tvc6OTxWh5e9iDE8C48?=
 =?us-ascii?Q?8XFRyYBmO18K9jNcI/swHDL1jG0+koZ45+Ssmzz4nGMEC68ppZHu/Njfy4sp?=
 =?us-ascii?Q?Ic0R6Jz7Z6CH9OOeV2WSqH4llKR42vlZU8d0kAcEWHnupmzvnXhvh7wai4Tl?=
 =?us-ascii?Q?fTfvGhaAOhNXvof185Zre7TAth2F9Z6//P/sOUE6VG0gmaZaVXoGckw6YNs8?=
 =?us-ascii?Q?zAWgiwETDWJFGN04OUwmU9ygTJ4fqYWGbQ4ocfU+9QVz5ddBejVDC942/pOQ?=
 =?us-ascii?Q?pLPyYLRJWcocmT5HU4Xn08lr5q98OgQi8Y1ulqwaR70r1ax+NcMYsXnVhjzo?=
 =?us-ascii?Q?6P3vLIjRAQ4DQBULoTwPK3VPwgfPjSyypZ8y5ikxuqJuwj9QPwYyNMCdSE0J?=
 =?us-ascii?Q?WR6PMUGu9Gq+BRbDHHaXt2sDIq+h/eGm+TwppQi9RtZLUZeKn1sgg2t9tJZ2?=
 =?us-ascii?Q?5v9hxH0a8dqHY+kZfGa87NCCGlcW7I7oI9Qmuwb+DvM4rBhPkj+Ln/DlDR5w?=
 =?us-ascii?Q?njjQzBtV6dyPZbFEsZKcyjb/w+HeLNEi4K+bAOPYVAZlrH7sXq64KiCCnYhW?=
 =?us-ascii?Q?ER8UMOjCLQa107Bwmc5Jg6ZfUVhXLNe/LaCXTWfFdn2mrWRk5ZSMrexpBGUz?=
 =?us-ascii?Q?So89ie9ssntCFCW9VLfAxcC9CPIGWfvfoXTjwd32FTjLoZkNrAES8ETDR2em?=
 =?us-ascii?Q?jAflgJukgh17Ab+Ohdj5UHg34GE/yfL+2V6PL9fJNkpmrPrxXzNSPXeDlOXJ?=
 =?us-ascii?Q?5qk3V0K9T1tcqB36BzzhpEFyZvg66Hu/ihEOOszgyLUWvElBKF/bDryC1LBQ?=
 =?us-ascii?Q?t13msuYK511j2SSL7Bpt/LZB4i2mdeyQFtBJNif41ThmUHRnJB7b1iAIx40n?=
 =?us-ascii?Q?bWC5Q9SjlD23kablpFiKgD4eMq/w4ePvcxY6SD+iwlnMOg0QoaRvubInvchq?=
 =?us-ascii?Q?auGCyLi4drJnO4YgZZzD0oFB7FrpzbnZwJssx1zAsqpjSDYNGUwWT4gkoQ+1?=
 =?us-ascii?Q?URM0GcP9X2hZDA7Z8+DSlOKTlQ+dH+m7WlNICoXDptM9SfzanAgQyuHFQs6a?=
 =?us-ascii?Q?KrZWczawXaR3k6SvZD5QD4mSGx/xOzeRjy/xNTGzh9P1XyzB48Wk7nb9Ms/A?=
 =?us-ascii?Q?oXZzGgFjXn7Q6DWy5VnNxHOf8Ew0ksMqTZ2jUwfJXnpt3vxLyqbySvT9SA5d?=
 =?us-ascii?Q?0QJASWw1Cpc6uW1Dr5ieR2I+CbORQTVDvjhuC5VSxTsy5gVQ8xnHx/9Kh6li?=
 =?us-ascii?Q?7iUZN4Qado6JlxbYDaj3iJoF?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c7229d70-cbd5-4e6a-f650-08d97f969925
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2021 20:05:04.2888
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wiNQUN6LfVmMs1BxzQ9Qc4soRlxB4ry831ZOix8j1bDcNQHyTp8Frp/Tle7atml4S8tLp7OuX6z/UyN+0Cn2ZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB2947
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 23, 2021 at 05:11:08PM +0200, Borislav Petkov wrote:
> On Thu, Sep 23, 2021 at 02:51:49PM +0000, Yazen Ghannam wrote:

...

> > Do you recommend this create another quirk flag and follow this patch? Or
> > should the quirks be grouped together somehow?
> 
> Does that quirk match machines with mce_flags.smca=1 per chance?
> 
> :-)
> 

Yes, at the moment it does. So I'll use that. Thanks!

> Also, your test:
> 
> +	if ((m->mcgstatus & (MCG_STATUS_EIPV|MCG_STATUS_RIPV)) != 0)
> +		return;
> 
> should be
> 
> +	if ((m->mcgstatus & (MCG_STATUS_EIPV|MCG_STATUS_RIPV)) ==
> 			    (MCG_STATUS_EIPV|MCG_STATUS_RIPV))
> +		return;
> 
> methinks.
> 
> Unless I'm misunderstanding the erratum ofc...
> 
> --

The check is intended to catch the case where both bits are 0. But I'll
double-check with the hardware folks.

Thanks,
Yazen