Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp2184684pxb; Fri, 24 Sep 2021 23:47:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjpKyXCZm4wrDbQ65I3QiEJQUbOuBV/x8f82d5omF5vqE85I/pvYJjdb12Lm9GTDgGfACp X-Received: by 2002:a17:906:3054:: with SMTP id d20mr15368721ejd.294.1632552441707; Fri, 24 Sep 2021 23:47:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632552441; cv=none; d=google.com; s=arc-20160816; b=M88VfeXCVSX027aKe+arKlg2FStOVn9p70Y1Jr5DIi4YO35/d3tgJsSeY2a5YL3iNL 3RzWFYR/o4v4ktP0HQeKW3ag8PaEE6UAqaSku/46w0BevQ6Bp01bgfkgKFfUHYkr06+Y rcFmlqcig+TdyA4EXN1X+IHE6OSg794tO/F3eca9UFnE2usYOmyGbLw7Elhyof0ALM4P 90JFiHMPdvUSqTnQoOCQb9ZaHGWdI0fldXbWCyMg0GG+wDQe0UbeT3MrBNnAe+0Uroa/ Yf1W1o6CtJqMM8fPdoSkfF87cHCDYn5ET3Ap2JD8Gfm0/8TnbO0Unj6+EVpcb+8JK1lM K5Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:subject:reply-to:cc:from:to:dkim-signature:date; bh=DV8F1Jf7EBf3HE0dfQzQxsqQ6nT1sRzn8zHjolegFeM=; b=J+7jpKdKf/dG+zKNzzoQL96igtmIJe5Hsu0Abt51pMjEqcBUZ/f7uXdrSkY1GZKUdf C4vXdpmz5hN6lSlavLupTnOHobBWKWvnqpjzO7DjRjvVBv/EJs/jeTImzrHzk3bVu0y4 o9cEgAHMSAf5xdCPbDmowBi3kqjVa9bTKLTFlAWAbKwNzNTbbz5CcMfnnIJKHgmgYhWc Sk9lp/9bbqyipeSaUjZSPoW4iyqWTg/tJEuYcPSJEEZM0el9emTSZ6JVkXT4dTKF9kFr 3EeOsoq/JGgJY7lt8wjSmmpz+kC6/NeAutSdWa/HJmfDZ0GsVhZntcFX9rnWRNYSSAHe tGpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail header.b=VpPIReeC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z8si3924631edd.87.2021.09.24.23.46.58; Fri, 24 Sep 2021 23:47:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail header.b=VpPIReeC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347603AbhIYC0F (ORCPT + 99 others); Fri, 24 Sep 2021 22:26:05 -0400 Received: from mail-4324.protonmail.ch ([185.70.43.24]:54639 "EHLO mail-4324.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343687AbhIYC0C (ORCPT ); Fri, 24 Sep 2021 22:26:02 -0400 Date: Sat, 25 Sep 2021 02:24:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1632536667; bh=DV8F1Jf7EBf3HE0dfQzQxsqQ6nT1sRzn8zHjolegFeM=; h=Date:To:From:Cc:Reply-To:Subject:From; b=VpPIReeCPjfz8t9kees+LdbmaGCXAK5qdpivX0MDE7qLkyR7Hh2sJ5rG+uUzndB4m +kSCK84znUo1afvVSwL075biijo9EXfRlJO5T9rG8I+Z4MTLl0l6B5NS2J0DRKUV1P 8YNdmUZ8G4LAbiUun7tr/PNsYMBjSHHl3qQLzId4= To: Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai From: Yassine Oudjana Cc: Yassine Oudjana , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Reply-To: Yassine Oudjana Subject: [PATCH] ASoC: wcd9335: Use correct version to initialize Class H Message-ID: <20210925022339.786296-1-y.oudjana@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The versioning scheme was changed in an earlier patch, which caused the ver= sion being used to initialize WCD9335 to be interpreted as if it was WCD937X, wh= ich changed code paths causing broken headphones output. Pass WCD9335 instead o= f WCD9335_VERSION_2_0 to wcd_clsh_ctrl_alloc to fix it. Fixes: 19c5d1f6a0c3 ("ASoC: codecs: wcd-clsh: add new version support") Signed-off-by: Yassine Oudjana --- sound/soc/codecs/wcd9335.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index d885ced34f60..bc5d68c53e5a 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -4859,7 +4859,7 @@ static int wcd9335_codec_probe(struct snd_soc_compone= nt *component) =20 =09snd_soc_component_init_regmap(component, wcd->regmap); =09/* Class-H Init*/ -=09wcd->clsh_ctrl =3D wcd_clsh_ctrl_alloc(component, wcd->version); +=09wcd->clsh_ctrl =3D wcd_clsh_ctrl_alloc(component, WCD9335); =09if (IS_ERR(wcd->clsh_ctrl)) =09=09return PTR_ERR(wcd->clsh_ctrl); =20 --=20 2.33.0