Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp2233354pxb; Sat, 25 Sep 2021 01:29:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoCTA+SR/2aw+GChxDWf+HhlIsMRdN9uZRjCs69uZFVb+XsnxTWyNAAUAnh+ZNNc5OduCu X-Received: by 2002:a6b:b883:: with SMTP id i125mr12614674iof.144.1632558559489; Sat, 25 Sep 2021 01:29:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632558559; cv=none; d=google.com; s=arc-20160816; b=d4YddeGBazsODVR0sAwIMV8blswiHGWgQZJIcL5zJK5N+2Bp0m98aiJ/vwt+iHBx7f Nuge9VMXcGkUe6jywmgauc5GT6H/7yqlgPqdoZYVnbc/SgcWI7MF7yqV5lTfb7nm2UxR uGKt9fV+f9yZ9MGQ8J9eb6WWB4lPUgwWXNanghHpVIibPY8i8ItYpBThQLHZZlc5Q1sL B8MkpdGlMJYZBc70Y3nDXG3rh1MoOdn5P6HpFD/VIZwb/ca8h91GxTp7+PXgXrbttnQz 6cv2G4Dev1LNJPZf2xf+HlVadNgma2/e8QwjbdrRnUui+PbT4CmwTVfsmiC9PJLBHB3s LbDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=aeFE9VnkcUgyVuVVWgFYBJsnKleQHf0uTwH9Vrmv6a0=; b=JKQwEp3VFYCrk+G+nC9Gb6jWf/abFj6r2jiYA7rqB2Pt7/sN4kdrCcHZPkHgCBjhPi ZPQThz/fMxO8Qz27dbatIPE4QDMs2T1AqgBVW3Uf3K4bUpyKzv39NMkko2ZPcsf4xuL+ ZHBPpsmpc/D9Flepf4cakkHqMsbyt0fqZQlDq5J8Cl3ARz6gFa4Y3JUvESRE7sTEiCC/ WC3R456yrRQwThwjXeEXiliRJhLli1NSRMc3bxBTCF1ASoJOYGHaxAxTOj9yMNQAdjC+ 3h0HgakL6LbiUJXSkhMPd/cFEcL++UH5Td41PQx821H0rj6u7nt5e4aglCcFuZNqkePy jGTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e24si13753830jak.17.2021.09.25.01.29.08; Sat, 25 Sep 2021 01:29:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233807AbhIYI1f (ORCPT + 99 others); Sat, 25 Sep 2021 04:27:35 -0400 Received: from a.mx.secunet.com ([62.96.220.36]:53568 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230162AbhIYI1c (ORCPT ); Sat, 25 Sep 2021 04:27:32 -0400 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 2E2E2200BC; Sat, 25 Sep 2021 10:06:17 +0200 (CEST) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t4gy4JVMN4x0; Sat, 25 Sep 2021 10:06:16 +0200 (CEST) Received: from mailout2.secunet.com (mailout2.secunet.com [62.96.220.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id A7778200BB; Sat, 25 Sep 2021 10:06:16 +0200 (CEST) Received: from cas-essen-02.secunet.de (unknown [10.53.40.202]) by mailout2.secunet.com (Postfix) with ESMTP id 9BA5C80004A; Sat, 25 Sep 2021 10:06:16 +0200 (CEST) Received: from mbx-essen-01.secunet.de (10.53.40.197) by cas-essen-02.secunet.de (10.53.40.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 25 Sep 2021 10:06:16 +0200 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-01.secunet.de (10.53.40.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 25 Sep 2021 10:06:16 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id D5BAA3183C35; Sat, 25 Sep 2021 10:06:15 +0200 (CEST) Date: Sat, 25 Sep 2021 10:06:15 +0200 From: Steffen Klassert To: Nicolas Dichtel CC: , , , , , , Subject: Re: [PATCH ipsec] xfrm: fix rcu lock in xfrm_notify_userpolicy() Message-ID: <20210925080615.GA3027429@gauss3.secunet.de> References: <0000000000003533d205cc8a624b@google.com> <20210922085006.13570-1-nicolas.dichtel@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210922085006.13570-1-nicolas.dichtel@6wind.com> X-ClientProxiedBy: cas-essen-01.secunet.de (10.53.40.201) To mbx-essen-01.secunet.de (10.53.40.197) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 22, 2021 at 10:50:06AM +0200, Nicolas Dichtel wrote: > As stated in the comment above xfrm_nlmsg_multicast(), rcu read lock must > be held before calling this function. > > Reported-by: syzbot+3d9866419b4aa8f985d6@syzkaller.appspotmail.com > Fixes: 703b94b93c19 ("xfrm: notify default policy on update") > Signed-off-by: Nicolas Dichtel Applied, thanks Nicolas!