Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030787AbWLPIkT (ORCPT ); Sat, 16 Dec 2006 03:40:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030788AbWLPIkS (ORCPT ); Sat, 16 Dec 2006 03:40:18 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:4854 "EHLO spitz.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030787AbWLPIkR (ORCPT ); Sat, 16 Dec 2006 03:40:17 -0500 Date: Sat, 16 Dec 2006 08:40:08 +0000 From: Pavel Machek To: "Robert P. J. Day" Cc: Linux kernel mailing list Subject: Re: lots of code could be simplified by using ARRAY_SIZE() Message-ID: <20061216084007.GC4049@ucw.cz> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 709 Lines: 21 Hi! > there are numerous places throughout the source tree that apparently > calculate the size of an array using the construct > "sizeof(fubar)/sizeof(fubar[0])". see for yourself: > > $ grep -Er "sizeof\((.*)\) ?/ ?sizeof\(\1\[0\]\)" * > > but we already have, from "include/linux/kernel.h": > > #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) Hmmm. quite misleading name :-(. ARRAY_LEN would be better. -- Thanks for all the (sleeping) penguins. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/