Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210921212732.1334-1-linux.amoon@gmail.com> <CAFBinCBHDTCkBBxP9u-Qh_k6ZSswJ_5XDL9oq2CSEkWG23dXfw@mail.gmail.com>
In-Reply-To: <CAFBinCBHDTCkBBxP9u-Qh_k6ZSswJ_5XDL9oq2CSEkWG23dXfw@mail.gmail.com>
From:   Anand Moon <linux.amoon@gmail.com>
Date:   Sat, 25 Sep 2021 23:03:43 +0530
Message-ID: <CANAwSgQaw=1VAwQaW5PnE=5LxK1M9COCPiwTVi+iN=2D_y10fA@mail.gmail.com>
Subject: Re: [PATCHv3] regulator: pwm-regulator: Make use of the helper
 function dev_err_probe()
To:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc:     linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-amlogic@lists.infradead.org,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Martin,

On Sat, 25 Sept 2021 at 22:42, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Hi Anand,
>
> On Tue, Sep 21, 2021 at 11:27 PM Anand Moon <linux.amoon@gmail.com> wrote:
> [...]
> > @@ -353,13 +353,8 @@ static int pwm_regulator_probe(struct platform_device *pdev)
> >
> >         drvdata->pwm = devm_pwm_get(&pdev->dev, NULL);
> >         if (IS_ERR(drvdata->pwm)) {
> > -               ret = PTR_ERR(drvdata->pwm);
> > -               if (ret == -EPROBE_DEFER)
> > -                       dev_dbg(&pdev->dev,
> > -                               "Failed to get PWM, deferring probe\n");
> > -               else
> > -                       dev_err(&pdev->dev, "Failed to get PWM: %d\n", ret);
> > -               return ret;
> > +               return dev_err_probe(&pdev->dev, PTR_ERR(drvdata->pwm),
> > +                                    "Failed to get PWM\n");
> >         }
> From functional perspective you're patch is looking good now.
> I just noticed that the coding-style in the pwm-regulator driver is
> not not use any curly brackets for the if block when there's only one
> statement
>
> with the curly brackets removed (and if there are no other changes to
> this patch) then you can add my:
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
Thanks, I will update the patch in the next version.
>
> Best regards,
> Martin

Thanks
-Anand