Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "allan.nielsen@microchip.com" <allan.nielsen@microchip.com>,
        "joergen.andreasen@microchip.com" <joergen.andreasen@microchip.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "vinicius.gomes@intel.com" <vinicius.gomes@intel.com>,
        "michael.chan@broadcom.com" <michael.chan@broadcom.com>,
        "vishal@chelsio.com" <vishal@chelsio.com>,
        "saeedm@mellanox.com" <saeedm@mellanox.com>,
        "jiri@mellanox.com" <jiri@mellanox.com>,
        "idosch@mellanox.com" <idosch@mellanox.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "kuba@kernel.org" <kuba@kernel.org>, Po Liu <po.liu@nxp.com>,
        Leo Li <leoyang.li@nxp.com>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
        "horatiu.vultur@microchip.com" <horatiu.vultur@microchip.com>
Subject: Re: [PATCH v5 net-next 2/9] net: mscc: ocelot: export struct
 ocelot_mact_entry
Thread-Topic: [PATCH v5 net-next 2/9] net: mscc: ocelot: export struct
 ocelot_mact_entry
Thread-Index: AQHXsSiI4fkHFW2crUKhjuf/UEcWf6u1IkeA
Date:   Sat, 25 Sep 2021 19:19:46 +0000
Message-ID: <20210925191945.vivi35k2uxbsdeyf@skbuf>
References: <20210924095226.38079-1-xiaoliang.yang_1@nxp.com>
 <20210924095226.38079-3-xiaoliang.yang_1@nxp.com>
In-Reply-To: <20210924095226.38079-3-xiaoliang.yang_1@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UjmJHhT7UZ/1Mg+wytI6Y6oAU47PhHOSeEm+GTp0zxO6qMQQkPSBFsEpfBk0?=
 =?us-ascii?Q?t0QMu+OpH9CXoh3rNZknwdmb2Ty/fJgYV3KnbO1B+Jbhg+rFMrz29+nWZKdT?=
 =?us-ascii?Q?/09QcM8pkFh0s1K9ruKrxLu0OvJZyx58P2BIGTdThNCpg53CSFpr5Bs4/Dlj?=
 =?us-ascii?Q?LgMDB/ZFZizCXy468OvPJtQyqP4jJCqyUphJWJkuVxhm5wbCRpte2M+u3vTT?=
 =?us-ascii?Q?+6u4XJaqjrazPb+E5S8d4Co3kTR9ivLZMXUjPTZxFkMvmwVOWzx3wIW5Hcse?=
 =?us-ascii?Q?fMfeOd5dYQeKW5wEN848TLUlRIuszw3XqB1HZ3IC9UXJIpUsgN77Zlv/8BMN?=
 =?us-ascii?Q?695h4R1SZ2dHqy09PgvRm6wlqjSuH8TiSavzA5k77X7h92CctBdU8gPVDijR?=
 =?us-ascii?Q?sG33HokITALvqJ4OxyDFUrF/sE2tSrS0O+0g/HFUMsMD/kBLa+DlLUZcoidw?=
 =?us-ascii?Q?BnxmU2wAGZWIwxBtW7fuRSq0CLQyOjuLJhZyCrPQ7sy+zyj77FY5c1z3XpGh?=
 =?us-ascii?Q?JRkx6yMLktvg1L9rGLXomQzjA2MWfeMP0tdmVHfmEZjuzIgCmF4gyiL/hZYv?=
 =?us-ascii?Q?8kpaJKbk5n6UemJkSbkuLPlAoYND7DNQsnUz1MMnCyh326LgQG9vINpQmIDn?=
 =?us-ascii?Q?0PyY6JbbKV2pLmAA/3S1OvTwwqK1y12M6v6WjbxcoaEMaqvpH1hsPwOIezlc?=
 =?us-ascii?Q?aaRuiZAKOsMGDnSRloYiUS/w0Ksx51XVPhkC6DX3be4YuVRybqrb8nhVcYQq?=
 =?us-ascii?Q?vj4hQXigoPMbtk0IjvaVACFLN5XxFh4KPAMyyfy/EUlmxrhazsnCSI6Dn/WB?=
 =?us-ascii?Q?4IRVLSso/8RtfRDz8HWWgI56hYJN5pcT7vWRhtFkwd+RlucgDkzM65S65cte?=
 =?us-ascii?Q?R0EkZs76x7VIAD73Tw1sg5TJWF5lxhPEvzOnpkJUIeiNDYJrRCO4KkpMJEBS?=
 =?us-ascii?Q?6ZXLXWN+k7epZOfux6lu1W4iedk6RXH4ueQyJloI0PTcgIyXl30Od94BxpKZ?=
 =?us-ascii?Q?6WgOAxAVKwb26jftEhlwkTmGmC2dpqrBfCKvKaJRrrdMac4Eep3qJbbamMEZ?=
 =?us-ascii?Q?QnP3kITE+TuogFMjGDh9ZgKqHppRwLTatBwlxkkgHAzkGXE5mky7VPhqDjoq?=
 =?us-ascii?Q?a1JMska96M/vyH0AQxzwlfqHypQ+T958yAvVFs4sysbV/z//MBX6Gt++s0Eo?=
 =?us-ascii?Q?nzAsoKheozmigfwVfRoIwXJF4ZEoepLBTu1uDs06iQN5ZUEDD5bt7EjC7tT+?=
 =?us-ascii?Q?qTkQsWc2osWfOvMC3KvG+C9/GCBAsArljlLwLBtMJlbIfYaYNUS3g9F5lN6m?=
 =?us-ascii?Q?HlN6CZDnD0yDXjMrCp9uVDcA?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3370C30DDAB9574298E75A793F5C3737@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a16b1c44-c5fe-46c3-c003-08d980596fa8
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Sep 2021 19:19:46.2661
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LXB+KzmKxOn3vjapEjEY2q8Mv+09mmbGdpBxNS15seqjWk797yNsLNbEdjhgX/6tVSr4Afk88WnN7AAb0BP3og==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4685
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 24, 2021 at 05:52:19PM +0800, Xiaoliang Yang wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>=20
> Felix DSA needs to use this struct to export MAC table write and lookup
> operations as well, for its stream identification functions, so export
> them in preparation of that.
>=20
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
> ---

I don't think this patch is my doing, is it? Can you please drop me from
the author and the sign-off? Thanks.

>  drivers/net/ethernet/mscc/ocelot.c |  6 ------
>  drivers/net/ethernet/mscc/ocelot.h | 13 -------------
>  include/soc/mscc/ocelot.h          | 19 +++++++++++++++++++
>  3 files changed, 19 insertions(+), 19 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/ms=
cc/ocelot.c
> index 9f481cf19931..35006b0fb963 100644
> --- a/drivers/net/ethernet/mscc/ocelot.c
> +++ b/drivers/net/ethernet/mscc/ocelot.c
> @@ -14,12 +14,6 @@
>  #define TABLE_UPDATE_SLEEP_US 10
>  #define TABLE_UPDATE_TIMEOUT_US 100000
> =20
> -struct ocelot_mact_entry {
> -	u8 mac[ETH_ALEN];
> -	u16 vid;
> -	enum macaccess_entry_type type;
> -};
> -
>  /* Must be called with &ocelot->mact_lock held */
>  static inline u32 ocelot_mact_read_macaccess(struct ocelot *ocelot)
>  {
> diff --git a/drivers/net/ethernet/mscc/ocelot.h b/drivers/net/ethernet/ms=
cc/ocelot.h
> index 1952d6a1b98a..a77050b13d18 100644
> --- a/drivers/net/ethernet/mscc/ocelot.h
> +++ b/drivers/net/ethernet/mscc/ocelot.h
> @@ -54,19 +54,6 @@ struct ocelot_dump_ctx {
>  	int idx;
>  };
> =20
> -/* MAC table entry types.
> - * ENTRYTYPE_NORMAL is subject to aging.
> - * ENTRYTYPE_LOCKED is not subject to aging.
> - * ENTRYTYPE_MACv4 is not subject to aging. For IPv4 multicast.
> - * ENTRYTYPE_MACv6 is not subject to aging. For IPv6 multicast.
> - */
> -enum macaccess_entry_type {
> -	ENTRYTYPE_NORMAL =3D 0,
> -	ENTRYTYPE_LOCKED,
> -	ENTRYTYPE_MACv4,
> -	ENTRYTYPE_MACv6,
> -};
> -
>  /* A (PGID) port mask structure, encoding the 2^ocelot->num_phys_ports
>   * possibilities of egress port masks for L2 multicast traffic.
>   * For a switch with 9 user ports, there are 512 possible port masks, bu=
t the
> diff --git a/include/soc/mscc/ocelot.h b/include/soc/mscc/ocelot.h
> index 682cd058096c..e6773f4d09ce 100644
> --- a/include/soc/mscc/ocelot.h
> +++ b/include/soc/mscc/ocelot.h
> @@ -701,6 +701,25 @@ struct ocelot_skb_cb {
>  	u8 ts_id;
>  };
> =20
> +/* MAC table entry types.
> + * ENTRYTYPE_NORMAL is subject to aging.
> + * ENTRYTYPE_LOCKED is not subject to aging.
> + * ENTRYTYPE_MACv4 is not subject to aging. For IPv4 multicast.
> + * ENTRYTYPE_MACv6 is not subject to aging. For IPv6 multicast.
> + */
> +enum macaccess_entry_type {
> +	ENTRYTYPE_NORMAL =3D 0,
> +	ENTRYTYPE_LOCKED,
> +	ENTRYTYPE_MACv4,
> +	ENTRYTYPE_MACv6,
> +};
> +
> +struct ocelot_mact_entry {
> +	u8 mac[ETH_ALEN];
> +	u16 vid;
> +	enum macaccess_entry_type type;
> +};
> +

Also, I am not sure that ocelot_mact_entry needs to be exported. More
details in the next patch.

>  #define OCELOT_SKB_CB(skb) \
>  	((struct ocelot_skb_cb *)((skb)->cb))
> =20
> --=20
> 2.17.1
> =