Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1631621507.git.wuzongyong@linux.alibaba.com>
 <cover.1632313398.git.wuzongyong@linux.alibaba.com> <296014fa3b765f2088a3183bf04e09863651a584.1632313398.git.wuzongyong@linux.alibaba.com>
 <8341d7ef-d31d-5536-864b-7d5127b7ec9f@redhat.com> <20210926032701.GA32606@L-PF27918B-1352.localdomain>
In-Reply-To: <20210926032701.GA32606@L-PF27918B-1352.localdomain>
From:   Jason Wang <jasowang@redhat.com>
Date:   Sun, 26 Sep 2021 12:19:30 +0800
Message-ID: <CACGkMEuAfvAY8nc2fjHQ007bRPE=pUgDPPgMjhkeA34JTQKSfw@mail.gmail.com>
Subject: Re: [PATCH v3 7/7] eni_vdpa: add vDPA driver for Alibaba ENI
To:     Wu Zongyong <wuzongyong@linux.alibaba.com>
Cc:     virtualization <virtualization@lists.linux-foundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        mst <mst@redhat.com>, wei.yang1@linux.alibaba.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Sep 26, 2021 at 11:27 AM Wu Zongyong
<wuzongyong@linux.alibaba.com> wrote:
>
> On Sun, Sep 26, 2021 at 10:26:47AM +0800, Jason Wang wrote:
> >
> > =E5=9C=A8 2021/9/22 =E4=B8=8B=E5=8D=888:46, Wu Zongyong =E5=86=99=E9=81=
=93:
> > > +
> > > +#ifdef __LITTLE_ENDIAN
> >
> >
> > I think disable the device via Kconfig is better than letting user to m=
eet
> > errors like this.
> >
> > (Or if the device is always using little endian, we don't even need to
> > bother this).
>
> I prefer the second suggestion since there are no use cases that the
> device uses big endian

If this means the device will always use little endian. It's fine.

Thanks

> >
> > Thanks
> >
> >
> > > +static int eni_vdpa_probe(struct pci_dev *pdev, const struct pci_dev=
ice_id *id)
> > > +{
> > > +   struct device *dev =3D &pdev->dev;
> > > +   struct eni_vdpa *eni_vdpa;
> > > +   struct virtio_pci_legacy_device *ldev;
> > > +   int ret, i;
> > > +
> > > +   ret =3D pcim_enable_device(pdev);
> > > +   if (ret)
> > > +           return ret;
> > > +
>