Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Yanfei Xu <yanfei.xu@windriver.com>
To:     andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
        davem@davemloft.net, kuba@kernel.org, p.zabel@pengutronix.de,
        syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH] net: mdiobus: Fix memory leak in __mdiobus_register
Date:   Sun, 26 Sep 2021 12:53:13 +0800
Message-Id: <20210926045313.2267655-1-yanfei.xu@windriver.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rdH2+1eks4AjCGDL/QmM75jftFFB/LAToCH9qyjJ62geV3vua6xolDGLj8AQ?=
 =?us-ascii?Q?P/93udpqI0jgrQPlRWq6fAqnVoWbe4OQalH2ony13MMJ+jz3A1wWS4SGh9Ms?=
 =?us-ascii?Q?U6UC26K8cLKBIB3KSSauOxl1Q2ZMM3atkH2oYqyQPRaXAtTn+owUS9WsLjI1?=
 =?us-ascii?Q?H3n4KeqIbN3mj6yre+RecvhcymH6c0+57Qe/k7y7LXqSpnxRU5HzlxRkGSHA?=
 =?us-ascii?Q?hXHuCT+QlUECVhZDpGYnBLQfAuU4JDDxpwoQrYrCXY0GobTd9aZ4Wwz6W+mK?=
 =?us-ascii?Q?AzIpMD7qoeV8XlJgxbRaghU+RYrNc3NYEYNZ66kmetvUQ6DPDjKIB1mlF5Ps?=
 =?us-ascii?Q?iHWepoZoqx0qKjeGCZRV34l9TXkmeGgXHr3n9KNPyCe7DMfdZLWk+Zkr/ICS?=
 =?us-ascii?Q?Ix1iBOnBc9fW2n/pc3dNnYBUY2EpJj0vZ0K1b47sUcbOIZGBkl3qA+nyTDx4?=
 =?us-ascii?Q?iiRKJVUmt5sqy5w4VZMddR+Siir6zhzWH/lg+hzBbQTXJ5AAp530Aw6VJlxv?=
 =?us-ascii?Q?EpiQLueB/mNenSwHRQpASCkaSBJxFh4aIWZBP6tHkW44npUrW1tnaECqySIY?=
 =?us-ascii?Q?FJ3kjNsLqJztXCDHfaIyhBjmyc0rqyI1ITYGUNYW+zjzV/0dOFAkKZtcjU0d?=
 =?us-ascii?Q?BYAL2xLCPdRHvJUowP4Hq6gNvj5Ait35aW6NivsAVlF3uR8hXkPZodcMSexK?=
 =?us-ascii?Q?QzaKoVh+/8va9S3kRqYXhEExullpDGun/ng+GFRHQ++Zc2WQ/xk+eErEHeJI?=
 =?us-ascii?Q?sJBxnhXHx57wOZw6ZS8MSR/ikwh9OffVbYOnoNhuSckX9jwmoRUU3tRECP94?=
 =?us-ascii?Q?VQSpMhsQHUHrK/86xdxCYofhBsx8rC3bhQQY7vvfstj3m6vIHf0YnGowdAJt?=
 =?us-ascii?Q?Waj2Muavl3WDnpIWX5kJqkmzcgI9MSq63SbJnRtGRXRTlsjwellvCZXjNScx?=
 =?us-ascii?Q?xrENQqMhC05hNjpSve5UyteJgpeCpK44s4eRJR/ejjjOHJXM8Vvs8Sang5RY?=
 =?us-ascii?Q?ib+wuVVWcSg0Hot0VSKPf9FggzGykO0IOPqJCW3n7jZ89tEaLBn+vYrPzwYL?=
 =?us-ascii?Q?TkX4Y/+ONdcmGyOnOqF+x24XguRV6ztOQUzM/kfxM8WQWSexRVc6R2lQk0KM?=
 =?us-ascii?Q?JqCg5PS8aGXSrT8O4Aj9jk23qKoOg+SpVQ4iYm55l2X5Yqn0gw+RINOQmarj?=
 =?us-ascii?Q?LQpyBbV1x4genEtBCn4myQvVPGI0z5A9rr87qjDDALu6drV/wuc6eWPDWDAL?=
 =?us-ascii?Q?0oik4Q5QwRUEg9MRMgoFN4IhwlxyWPA4sDff4Jrd67Vo+E8HmK+SCq0YHU5D?=
 =?us-ascii?Q?aZfDIYdVi9x0QNmMXT3nKmFX?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1dd73702-2c39-4fa7-7a96-08d980a99b29
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2021 04:53:39.3349
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kvbw7KOJ/0tr7Xw2M0msKKMzeHZOiI26BPqoVkTZJlmy6/XeEbVr2K2hSoPIiibw71/n4EcJjrrHjvpai/WHYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2188
X-Proofpoint-GUID: dMZP4dVgUyp1bkn3Bo1NCUGuWP25jLmZ
X-Proofpoint-ORIG-GUID: dMZP4dVgUyp1bkn3Bo1NCUGuWP25jLmZ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-09-25_07,2021-09-24_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0
 mlxlogscore=671 spamscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0
 bulkscore=0 phishscore=0 impostorscore=0 suspectscore=0 priorityscore=1501
 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2109260036
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Once device_register() failed, we should call put_device() to
decrement reference count for cleanup. Or it will cause memory
leak.

BUG: memory leak
unreferenced object 0xffff888114032e00 (size 256):
  comm "kworker/1:3", pid 2960, jiffies 4294943572 (age 15.920s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 08 2e 03 14 81 88 ff ff  ................
    08 2e 03 14 81 88 ff ff 90 76 65 82 ff ff ff ff  .........ve.....
  backtrace:
    [<ffffffff8265cfab>] kmalloc include/linux/slab.h:591 [inline]
    [<ffffffff8265cfab>] kzalloc include/linux/slab.h:721 [inline]
    [<ffffffff8265cfab>] device_private_init drivers/base/core.c:3203 [inline]
    [<ffffffff8265cfab>] device_add+0x89b/0xdf0 drivers/base/core.c:3253
    [<ffffffff828dd643>] __mdiobus_register+0xc3/0x450 drivers/net/phy/mdio_bus.c:537
    [<ffffffff828cb835>] __devm_mdiobus_register+0x75/0xf0 drivers/net/phy/mdio_devres.c:87
    [<ffffffff82b92a00>] ax88772_init_mdio drivers/net/usb/asix_devices.c:676 [inline]
    [<ffffffff82b92a00>] ax88772_bind+0x330/0x480 drivers/net/usb/asix_devices.c:786
    [<ffffffff82baa33f>] usbnet_probe+0x3ff/0xdf0 drivers/net/usb/usbnet.c:1745
    [<ffffffff82c36e17>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
    [<ffffffff82661d17>] call_driver_probe drivers/base/dd.c:517 [inline]
    [<ffffffff82661d17>] really_probe.part.0+0xe7/0x380 drivers/base/dd.c:596
    [<ffffffff826620bc>] really_probe drivers/base/dd.c:558 [inline]
    [<ffffffff826620bc>] __driver_probe_device+0x10c/0x1e0 drivers/base/dd.c:751
    [<ffffffff826621ba>] driver_probe_device+0x2a/0x120 drivers/base/dd.c:781
    [<ffffffff82662a26>] __device_attach_driver+0xf6/0x140 drivers/base/dd.c:898
    [<ffffffff8265eca7>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:427
    [<ffffffff826625a2>] __device_attach+0x122/0x260 drivers/base/dd.c:969
    [<ffffffff82660916>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:487
    [<ffffffff8265cd0b>] device_add+0x5fb/0xdf0 drivers/base/core.c:3359
    [<ffffffff82c343b9>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2170
    [<ffffffff82c4473c>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238

BUG: memory leak
unreferenced object 0xffff888116f06900 (size 32):
  comm "kworker/0:2", pid 2670, jiffies 4294944448 (age 7.160s)
  hex dump (first 32 bytes):
    75 73 62 2d 30 30 31 3a 30 30 33 00 00 00 00 00  usb-001:003.....
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<ffffffff81484516>] kstrdup+0x36/0x70 mm/util.c:60
    [<ffffffff814845a3>] kstrdup_const+0x53/0x80 mm/util.c:83
    [<ffffffff82296ba2>] kvasprintf_const+0xc2/0x110 lib/kasprintf.c:48
    [<ffffffff82358d4b>] kobject_set_name_vargs+0x3b/0xe0 lib/kobject.c:289
    [<ffffffff826575f3>] dev_set_name+0x63/0x90 drivers/base/core.c:3147
    [<ffffffff828dd63b>] __mdiobus_register+0xbb/0x450 drivers/net/phy/mdio_bus.c:535
    [<ffffffff828cb835>] __devm_mdiobus_register+0x75/0xf0 drivers/net/phy/mdio_devres.c:87
    [<ffffffff82b92a00>] ax88772_init_mdio drivers/net/usb/asix_devices.c:676 [inline]
    [<ffffffff82b92a00>] ax88772_bind+0x330/0x480 drivers/net/usb/asix_devices.c:786
    [<ffffffff82baa33f>] usbnet_probe+0x3ff/0xdf0 drivers/net/usb/usbnet.c:1745
    [<ffffffff82c36e17>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
    [<ffffffff82661d17>] call_driver_probe drivers/base/dd.c:517 [inline]
    [<ffffffff82661d17>] really_probe.part.0+0xe7/0x380 drivers/base/dd.c:596
    [<ffffffff826620bc>] really_probe drivers/base/dd.c:558 [inline]
    [<ffffffff826620bc>] __driver_probe_device+0x10c/0x1e0 drivers/base/dd.c:751
    [<ffffffff826621ba>] driver_probe_device+0x2a/0x120 drivers/base/dd.c:781
    [<ffffffff82662a26>] __device_attach_driver+0xf6/0x140 drivers/base/dd.c:898
    [<ffffffff8265eca7>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:427
    [<ffffffff826625a2>] __device_attach+0x122/0x260 drivers/base/dd.c:969

Reported-by: syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com
Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
---
 drivers/net/phy/mdio_bus.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 53f034fc2ef7..6f4b4e5df639 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -537,6 +537,7 @@ int __mdiobus_register(struct mii_bus *bus, struct module *owner)
 	err = device_register(&bus->dev);
 	if (err) {
 		pr_err("mii_bus %s failed to register\n", bus->id);
+		put_device(&bus->dev);
 		return -EINVAL;
 	}
 
-- 
2.27.0