Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 26 Sep 2021 08:44:56 +0000
To:     Aditya Garg <gargaditya08@live.com>,
        "sagi@grimberg.me" <sagi@grimberg.me>,
        "kbusch@kernel.org" <kbusch@kernel.org>
From:   Orlando Chamberlain <redecorating@protonmail.com>
Cc:     "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
        "axboe@fb.com" <axboe@fb.com>, "hch@lst.de" <hch@lst.de>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "james.smart@broadcom.com" <james.smart@broadcom.com>,
        "chaitanya.kulkarni@wdc.com" <chaitanya.kulkarni@wdc.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "trivial@kernel.org" <trivial@kernel.org>
Reply-To: Orlando Chamberlain <redecorating@protonmail.com>
Subject: Re: [PATCH] Urgent bug fix causing Apple SSDs to not work.
Message-ID: <4dae80c3-034c-617b-c766-1858d6ee1220@protonmail.com>
In-Reply-To: <PNZPR01MB4415986CC44AACC100AD1189B8A69@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
References: <PNZPR01MB4415600ACD3C8D9944F15058B8A59@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM> <CAHk-=wgML11x9afCvmg9yhVm9wi5mvnjBvmX+i7OfMA0Vd4FWA@mail.gmail.com> <20210925195425.GB116968@dhcp-10-100-145-180.wdc.com> <7e75e292-3073-f1f9-287a-badf92c8e4e8@grimberg.me> <PNZPR01MB4415F5304CAA1A83442549DBB8A69@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM> <PNZPR01MB4415986CC44AACC100AD1189B8A69@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 26/9/21 18:07, Aditya Garg wrote:
> I checked out the proposal sent by Orlando Chamberlain to replace=20
> NVME_QUIRK_SHARED_TAGS , by NVME_QUIRK_SHARED_TAGS | given in the patch o=
n=20
> http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.htm=
l=20
> <http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.ht=
ml>.=20
> The , still causes panics to the T2 as described before. In the case of |=
, the=20
> kernel boots correctly without panicking the T2, but in case we are havin=
g Linux=20
> on an External Drive, which is my case, then the internal SSD doesn't see=
m to be=20
> recognised at all. I've tested the patch on 5.14.7. A screenshot of the G=
NOME=20
> Disks utility has been attached along with this mail.

I had some issues with the patch not applying automatically as I mixed up t=
abs and spaces,
(due to me copying stuff directly out of vim), so I had issues with getting=
 patches to apply
automatically. I've checked that this file https://github.com/Redecorating/=
mbp-16.1-linux-wifi/blob/anbox-bt/1001-apple-t2-disable-nvme-gen-counter-qu=
irk.patch
applies correctly for me (and github ci), so can you see if it still doesn'=
t work with that?