Message-ID: <45841525.7040406@pobox.com>
Date: Sat, 16 Dec 2006 10:47:49 -0500
From: Jeff Garzik <jgarzik@pobox.com>
User-Agent: Thunderbird 1.5.0.8 (X11/20061107)
MIME-Version: 1.0
To: Alan <alan@lxorguk.ukuu.org.uk>
CC: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pata_via: Cable detect error
References: <20061216143221.47c5e7f3@localhost.localdomain>
In-Reply-To: <20061216143221.47c5e7f3@localhost.localdomain>
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1000
Lines: 25

Alan wrote:
> The UDMA66 VIA hardware has no controller side cable detect bits we can
> use. This patch minimally fixes the problem by reporting unknown in this
> case and using drive side detection.
> 
> The old drivers/ide code does some additional tricks but those aren't
> appropriate now we are in -rc.
> 
> Without this update UDMA66 via controllers run slowly. They don't fail so
> it's a borderline call whether this is -rc material or not.
> 
> Signed-off-by: Alan Cox <alan@redhat.com>

I think it's #upstream-fixes material (-rc material), and applied as such.

Especially considering that libata pata_* drivers are not the primary 
drivers, I think it's best to forward this type of stuff, especially as 
it is indeed IMO a fix worth having.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/