Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp3391359pxb; Sun, 26 Sep 2021 13:51:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZYHiBSJfirXR4PrnW+9IStF7JKrnb8BR7vLPJfEhOnaWjMyZNx8gQ9rVgQszShmGYqqPB X-Received: by 2002:a63:3cf:: with SMTP id 198mr13465221pgd.415.1632689461846; Sun, 26 Sep 2021 13:51:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632689461; cv=none; d=google.com; s=arc-20160816; b=qxDciaEq/IVtzm7z1kMsgBGcy9cGzedVoqlLhxkrEqfupTjq5SHZCgJUiOvwpT4wOf vKUCY74bE2/vCnDhvGhwU2xIkNIpixWZWpjeKLF02wtc3ngbYNaErfrh16f9vs/0b66a LOLDyjgj1t5UC/yCgjY3zvy40+ZWWHh6fewd7bxAL6xewbNRjRpkH+hUGaz5NYM64Fsw 3LPHJfA9AEbo8IS3188SZIv0490T1F/dlZ5H3rOEKsiAZ0bo5ITgHncXVQOQX/6gUjWk DsSulnSYmjLSXcOJF9Dy68onKsZ3A2Lf2x6UfzhJidVX9syDXNS5NaPQqUqmYyBw52Z8 bcWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:from:date:dkim-signature; bh=1Xi2zI3xz++jAU4KL461gSjO8O02r5P5HLSbGNQJnPI=; b=EFpMlMv4g66SNQoyFQglU4gu1GfIhhmFAWgRavVNU6ldhDwneW+hlvKzUeITPxVi64 kapKfh7ffyfoBkU2wZWlqKS51gQXe0N28pR5/D3AMSRXru/Av95xySQwG63BCB9JRbwn dpUIVq7ZWPblVCpbG49fmird4LDKCybH41oEB0g3AvYR3WjLZXcp9L/YfIWGa/Fe3dDM u7ANM/8Kz9PD9qKs43fnhu7gmxRpdYheMGuqhogLUQgwvqDYkyqiLpNrFnFQG9NG9iIK pEGYeUrMsjgS0Eid3EYy4Ajwc/nzvkr+jP06GABuh3G+EZkRKd4HadQNiFt/lY3OOcNw 5nUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=YNUKZmOz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r6si19399366pgm.169.2021.09.26.13.50.49; Sun, 26 Sep 2021 13:51:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=YNUKZmOz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230197AbhIZUvP (ORCPT + 99 others); Sun, 26 Sep 2021 16:51:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230169AbhIZUvO (ORCPT ); Sun, 26 Sep 2021 16:51:14 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2627CC061604 for ; Sun, 26 Sep 2021 13:49:38 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id c1so13866673pfp.10 for ; Sun, 26 Sep 2021 13:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=1Xi2zI3xz++jAU4KL461gSjO8O02r5P5HLSbGNQJnPI=; b=YNUKZmOzFiHeJ2mJa7gvVYN7uN2TvfskQSN1D5sRVykhEQSaJ9ruR/0/YcZL/v6m+1 ej1FfHbYG0ay7WCE+E3fA04decWx+gxNMJh/2AfKb1EJT5DQhro8je6KQpQGeHKkDbsI 2Vo6bqf1guqWezlCcy2Pu6ROHYsiuxXT4kAlFIb+PM88X+oLVX6srxEMUnpVmYtptPL8 WAOiHaRdS1eZovd/jq4qVEL92/LIrjngBpm8KGcaYFTn8I1F9IQaKEEHQjkczzN5zKka GwufIKM8VX78GbMlNVMgRK/KoB016OeVF3XuaLuGYvlJ152+ArnP4IkuG15uKtU0UehI POCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=1Xi2zI3xz++jAU4KL461gSjO8O02r5P5HLSbGNQJnPI=; b=dyjFNBFlFdxYwSNyBg1KaWZoaQlZlLVOHBsJIf1caPaALlT67/a8NDUyKiUIRbATZO xPWh8nL5Frkl1ApgE9y/hR9yTk6b0sSyg+ZOeOVPofG4+vuLrI6sxpiBXNuqYTi0Z+GI p2SIVTD5s9LRq9QHlzb/hYCZZg9NJ6hzwxkLqMPdhqsZly9LzwjiMJlDO0BJE6uf1SMy ReNs5BXliRFCjC1yw3QVwS1eeamLCAaZDbI0GttvSZaDq6u38sS5AtAw5MlVbarw5H3A 7jQM8aZFeligqsrd5yraZXP/KFHOMGymQugYK7YCZYVcUxsDgMFVl/0zOJ8pi++81BH3 OI1g== X-Gm-Message-State: AOAM5325rw/xVYKv4tEy5Jf5BdnJIRR73mB3IAaEBeY0diDOdqdgBXto WzJ/B5P+bIwo5tqqa86RsvmzRQ== X-Received: by 2002:a63:4457:: with SMTP id t23mr583580pgk.354.1632689377421; Sun, 26 Sep 2021 13:49:37 -0700 (PDT) Received: from [2620:15c:17:3:4d45:c2:971a:f134] ([2620:15c:17:3:4d45:c2:971a:f134]) by smtp.gmail.com with ESMTPSA id q13sm6606060pfk.128.2021.09.26.13.49.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Sep 2021 13:49:36 -0700 (PDT) Date: Sun, 26 Sep 2021 13:49:35 -0700 (PDT) From: David Rientjes To: Stephen Kitt cc: Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Vlastimil Babka , James Morris , "Serge E . Hallyn" , linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Kees Cook Subject: Re: [PATCH] mm: Remove HARDENED_USERCOPY_FALLBACK In-Reply-To: <20210921061149.1091163-1-steve@sk2.org> Message-ID: References: <20210921061149.1091163-1-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Sep 2021, Stephen Kitt wrote: > This has served its purpose and is no longer used. All usercopy > violations appear to have been handled by now, any remaining > instances (or new bugs) will cause copies to be rejected. > > This isn't a direct revert of commit 2d891fbc3bb6 ("usercopy: Allow > strict enforcement of whitelists"); since usercopy_fallback is > effectively 0, the fallback handling is removed too. > > This also removes the usercopy_fallback module parameter on > slab_common. > > Link: https://github.com/KSPP/linux/issues/153 > Signed-off-by: Stephen Kitt > Suggested-by: Kees Cook Acked-by: David Rientjes